From patchwork Wed Jan 13 14:50:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362130 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp598345jap; Wed, 13 Jan 2021 06:51:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJy715IAEQPTblG6UcOgSKRpMfXKJPxFH8oLxOyHTkoTsga+s5GXXPSz09Ritq14TdsG7a5+ X-Received: by 2002:a17:902:ed14:b029:da:9da4:3091 with SMTP id b20-20020a170902ed14b02900da9da43091mr2580405pld.29.1610549461926; Wed, 13 Jan 2021 06:51:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549461; cv=none; d=google.com; s=arc-20160816; b=FQs0QqAfORBJc5T4mUCz8sIhCxqR3SKDzhJg7BHBWmxGrgm0Ds5zMdm4+URA1r7gpo ZjD1ofJbBkdAN77W4Rid1TDElDDkzHnAddGfWZ8+HjHztD57P7JfxlbvNxNc57eEDkS+ YI5LFY0t3Fovszn8FlP/pJepbQ20tplujL07Bxi/JohKnDjGzg5yVhD705bcHmyu+yKw Q/cD6I50ocG85Qb4q9AUu4dT3ih/EEeOzB0e0vYwxIx3GyXLOvp9xBFN7+IpXxkBC5tA lR36Pba0w0A+ybE/ZdY4AqA0Jt4i2rOJp7S/H0eVbfAJFIA2lpVIzuJmSeU+VQEiOOC3 avvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=WzI/lAoUWzFaQvYen/OnpeaG7R2v7xtni0hSTQU5Yek=; b=ZTEXl3JZVbXPlx0K1p5Rz9BkNgazPz8GPF/vlSXGn2gRQufYoKkHncEBS2fulJL0hv CiltA6kVB+o9idibIId+w90qwFG4rtOQuKbpR7YEcyr2Fo+xoEcwMFh/k0aMeXJofHxv yiUe2qw7kTXtTOFidSBgojdrqCWtkDZ7sWP6srjMKTdyrhClux+zViQ5nhWTGYwQDRTd j8pV5ovr9wt5CouxhIHTtU5qWCMSEGnXm57mOfZmA9UshyBg2XL3S0cCN1y3GKRyqz16 Jd8E0ZXP09cpSgvza1MVe0gMx1nopUkiOiRQl7bADNJXby0U/Z5hFiKHUk9f/UEJn4ad h2pA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=k1fbqp18; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id z36si2820762pjj.67.2021.01.13.06.51.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:51:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=k1fbqp18; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CFF776EA6E; Wed, 13 Jan 2021 14:50:55 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by gabe.freedesktop.org (Postfix) with ESMTPS id 505516EA66 for ; Wed, 13 Jan 2021 14:50:49 +0000 (UTC) Received: by mail-wr1-x436.google.com with SMTP id d26so2386549wrb.12 for ; Wed, 13 Jan 2021 06:50:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DvtlGdT5MHeh268WloE5stTLPTvRDEZ8rCCQAdX9t84=; b=k1fbqp18yv8PIWF/VtBZ1OCxmUUxm3DEuDCdGpp/1lf2Qusjjl6Jr0LbNjCDkAYjum 1/wwNHwC2fYs6yOsRNYBp7G/0/6EKBrI0OVlE9krnhPcy8pLZI8vfx7yCAVMlSMwGOA+ hnp7cTdcUMYNnIJqWcxy66Lo1P3xlU9yPVOVU+OePlvMmIh7A0BSVnlshSywJYQQwzbU 5uukjwiQHWY6GeoO+bNuzYazh3MQdjtKvFY6BEa2ztaEJRUBzfF1uDCo9++RfRW+OfdJ ZYE/I/DDBlwjWjQBrwAXZdAbnCrtVk//3HRL1I6mCpS4vkKtNu8uXUKBPssO/APhiy0t CkPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DvtlGdT5MHeh268WloE5stTLPTvRDEZ8rCCQAdX9t84=; b=hRIko46Y7ASkijs1r1XYF2Cebs9oJIhkwjK0w2oykWagyFCC8MSydU5J7VJ3Zvm4kf fD8yiPi2iJeesF9gbIfL3CfJT6/V0GDy/3eExOETn63bdA0t8QK0tt6SfT64I+SwvUU7 NIxhVpTcHE/rUjEndUhShBWZMjH8GT6znLqvDavxbfUgSkL2qgx6UCl9pfeP0OpkrbGt cJrSgt4h/Oua0EtJDxPQD/eNKMFDKQ32SmvIzIQZvNr9Mdbru0xSGRZKJFNnIhHvdAUw JdgSvh8rbMv+2tpwDwUAoNB2slrApAlhwwAOsuQfKKBgvrtgP5DvGVCZjoLYL03im9E/ uqig== X-Gm-Message-State: AOAM530Z48EFRcRyfhKqNrgDEC8IQiblhZWhN9paqe5Mq5lv5QWYiCSH LyfkTJS33wki+nJzNio6WBFHsQ== X-Received: by 2002:adf:eec6:: with SMTP id a6mr2949891wrp.239.1610549448015; Wed, 13 Jan 2021 06:50:48 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:47 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 24/31] video: fbdev: s3c-fb: Fix some kernel-doc misdemeanours Date: Wed, 13 Jan 2021 14:50:02 +0000 Message-Id: <20210113145009.1272040-25-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ben Dooks , Jingoo Han , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/s3c-fb.c:104: warning: Function parameter or member 'osd_stride' not described in 's3c_fb_variant' drivers/video/fbdev/s3c-fb.c:174: warning: Function parameter or member 'variant' not described in 's3c_fb_win' drivers/video/fbdev/s3c-fb.c:345: warning: Function parameter or member 'pixclk' not described in 's3c_fb_calc_pixclk' drivers/video/fbdev/s3c-fb.c:345: warning: Excess function parameter 'pixclock' description in 's3c_fb_calc_pixclk' drivers/video/fbdev/s3c-fb.c:742: warning: Function parameter or member 'transp' not described in 's3c_fb_setcolreg' drivers/video/fbdev/s3c-fb.c:742: warning: Excess function parameter 'trans' description in 's3c_fb_setcolreg' drivers/video/fbdev/s3c-fb.c:1142: warning: Function parameter or member 'sfb' not described in 's3c_fb_release_win' drivers/video/fbdev/s3c-fb.c:1172: warning: Function parameter or member 'win_no' not described in 's3c_fb_probe_win' Cc: Jingoo Han Cc: Ben Dooks Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/video/fbdev/s3c-fb.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel Acked-by: Jingoo Han diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c index ba316bd56efd7..d33d7df77a6a5 100644 --- a/drivers/video/fbdev/s3c-fb.c +++ b/drivers/video/fbdev/s3c-fb.c @@ -75,6 +75,7 @@ struct s3c_fb; * @buf_size: Offset of buffer size registers. * @buf_end: Offset of buffer end registers. * @osd: The base for the OSD registers. + * @osd_stride: The OSD stride value. * @palette: Address of palette memory, or 0 if none. * @has_prtcon: Set if has PRTCON register. * @has_shadowcon: Set if has SHADOWCON register. @@ -155,7 +156,7 @@ struct s3c_fb_palette { * @windata: The platform data supplied for the window configuration. * @parent: The hardware that this window is part of. * @fbinfo: Pointer pack to the framebuffer info for this window. - * @varint: The variant information for this window. + * @variant: The variant information for this window. * @palette_buffer: Buffer/cache to hold palette entries. * @pseudo_palette: For use in TRUECOLOUR modes for entries 0..15/ * @index: The window number of this window. @@ -336,7 +337,7 @@ static int s3c_fb_check_var(struct fb_var_screeninfo *var, /** * s3c_fb_calc_pixclk() - calculate the divider to create the pixel clock. * @sfb: The hardware state. - * @pixclock: The pixel clock wanted, in picoseconds. + * @pixclk: The pixel clock wanted, in picoseconds. * * Given the specified pixel clock, work out the necessary divider to get * close to the output frequency. @@ -733,7 +734,7 @@ static inline unsigned int chan_to_field(unsigned int chan, * @red: The red field for the palette data. * @green: The green field for the palette data. * @blue: The blue field for the palette data. - * @trans: The transparency (alpha) field for the palette data. + * @transp: The transparency (alpha) field for the palette data. * @info: The framebuffer being changed. */ static int s3c_fb_setcolreg(unsigned regno, @@ -1133,6 +1134,7 @@ static void s3c_fb_free_memory(struct s3c_fb *sfb, struct s3c_fb_win *win) /** * s3c_fb_release_win() - release resources for a framebuffer window. + * @sfb: The base resources for the hardware. * @win: The window to cleanup the resources for. * * Release the resources that where claimed for the hardware window, @@ -1160,6 +1162,7 @@ static void s3c_fb_release_win(struct s3c_fb *sfb, struct s3c_fb_win *win) /** * s3c_fb_probe_win() - register an hardware window * @sfb: The base resources for the hardware + * @win_no: The ID of the window to be registered * @variant: The variant information for this window. * @res: Pointer to where to place the resultant window. *