From patchwork Wed Feb 24 23:05:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 386884 Delivered-To: patch@linaro.org Received: by 2002:a02:290e:0:0:0:0:0 with SMTP id p14csp755644jap; Wed, 24 Feb 2021 15:05:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJwsVKK5W3KY3S/EZN8IF+8q3+zVbXnf2EPry1FwDQbAEm5JXLliaUyKS5/RlSHJY7mRhSs+ X-Received: by 2002:a63:fa52:: with SMTP id g18mr194366pgk.193.1614207936306; Wed, 24 Feb 2021 15:05:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614207936; cv=none; d=google.com; s=arc-20160816; b=z8ZPn2/FIOiICN1lUcYTyfTRyeRlsz+djNHhg4PyL7brd3IzUTiOc5aOWneN2KK2tn //g3EdWXFf9IPdJXwzoX9X2Qqcn340Fx9t/nqqRo79Vs5hxN3O8IjBz4KtugcCdbxaBZ /bYDbpsTl1Cl5AOxPYg7IdCFlO6vvxbTd4VxmWvzDdZjEibkBxcXL2/p53bvdtKcUTch b39syy8/OIRP9kJ6EKc0Wn01SAZq52JPQyweVN9uasSxjEoweOCggpBp+WYAwRAh4JSw j/xPnmSEeEKk8dwFAOrf4MTOgofFdEjM1mR2ZV90nLKFHiNfpTSg/E91rxN3WOponYA6 rgAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:message-id:date:subject:to:from :dkim-signature:delivered-to; bh=gG0Ji7IU0tTkYU7WSoqF8eA5dPoB9+Ogc0TJDcOFWIM=; b=iMHUUTI90fP/7rGWPiTfDaX30kwJHkh1/y7L5nAIFVBBZ2WDg5sC9pXKL/q6M6nOSH d8umLJ+gb0t4Gi2+3GpFRjKc8uZLsvgTo9fKyP86qTbR+H18h0Y5DHmqXJMtwiHkTxpT qHjjBtUfU53/FU9E96dzoAOxpnuW7q5zC9k2l/TyZ6kXm7G+KtVKZla0eTx4YfIjqTT0 boaCI2oaNe0BYBwSHz+ABIdq18ziaYmcAO1fR5DUZCVWpq5t7NAZ4XRzqmMH+W4JFGiH 6jA213VHTXbhn0sVEGtNcyvy6Sy4LDnxCwhM0XQ0PvaLZrtxmVt/DjcWFdTBVCx6mWSE fwiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=MzOp94cS; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id m15si3188119pgs.106.2021.02.24.15.05.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 15:05:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=MzOp94cS; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8DAC26EC04; Wed, 24 Feb 2021 23:05:32 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by gabe.freedesktop.org (Postfix) with ESMTPS id C15FA6EC05 for ; Wed, 24 Feb 2021 23:05:31 +0000 (UTC) Received: by mail-lf1-x12d.google.com with SMTP id h125so5633837lfd.7 for ; Wed, 24 Feb 2021 15:05:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=RlKikzIt/rONQFY4pZWTu3Ycq1cfYGrrRaic2XmO02k=; b=MzOp94cSmfjpzUawBnjMSye+NAvtXmGFYcpJw12vAjojlYfUUv0Wv2wWyXZBP9Yjg0 7cJ1Pj76XmGaR9u5QOaIk4Dqh9IhMnY0PJEt356JmFijQQrVlYXs1/hNfZdVSxI7KHLZ ZILg+3nxMnwA+TmLtEvlcoQQOmfGSb0BAcpzszhRRp4TnNsrpJYbtOMirN4A7StPWcyV Nd1hpgpA7KOjz25aRlKhTowffmA1PnWOyGLsJBCGri9khSEYrO6dclcx5i/xv+Y/1z9S upXNXFQSy4bOrUZ12V6ebgkH0ToFg5OkyA5jIHWkImj9KKH8e7Mj+8OCiTKQbb7nmFF7 nQsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=RlKikzIt/rONQFY4pZWTu3Ycq1cfYGrrRaic2XmO02k=; b=VK0RHJP0SVYrd1R2qRxx+qizX/t5xiRjkDd6IKpx8+ToabgUzu5FslVKsoMXW9IgJ9 BjWR3egSVH66vHwjn1QwYoRZJNtMSxSRZn18On7Nu9JSQYr8VWqKbsEEeVKlO9ntcap+ ozmY0fAN2I+gOz4oCgWos1GERBbVj5RNznPzR/7DNTfD3VOFUTO3hBMw5u/89QhCoYf/ z7x//cYwhk5/XtPYrZKkNRRXfT0H7Lp+wmGz+L7IMWjVNX3Io9TrBL5FmuIqvIBwKAEl xN2Wf0qFEozPCFlzezkME07hMyjLi/JQy2EOhLBMftJRg/pfGVzY/2PYxFRwr3dKaYzK Zcvg== X-Gm-Message-State: AOAM531h2DkJkmlJyS9IgT6MUbIk8xSjX3OR+3OicjyzvXFh9JkSDO2J J/5qYlhtAXQkIZYH3Ito7CCPsA== X-Received: by 2002:a19:ca01:: with SMTP id a1mr186246lfg.372.1614207930020; Wed, 24 Feb 2021 15:05:30 -0800 (PST) Received: from eriador.lan ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id b28sm776114lfo.190.2021.02.24.15.05.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 15:05:29 -0800 (PST) From: Dmitry Baryshkov To: Rob Clark , Sean Paul Subject: [PATCH] drm/msm/dsi_pll_7nm: Fix variable usage for pll_lockdet_rate Date: Thu, 25 Feb 2021 02:05:28 +0300 Message-Id: <20210224230528.1216677-1-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The PLL_LOCKDET_RATE_1 was being programmed with a hardcoded value directly, but the same value was also being specified in the dsi_pll_regs struct pll_lockdet_rate variable: let's use it! Based on 362cadf34b9f ("drm/msm/dsi_pll_10nm: Fix variable usage for pll_lockdet_rate") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/pll/dsi_pll_7nm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.30.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel Reviewed-by: Abhinav Kumar diff --git a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_7nm.c b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_7nm.c index 0458eda15114..e29b3bfd63d1 100644 --- a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_7nm.c +++ b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_7nm.c @@ -325,7 +325,7 @@ static void dsi_pll_commit(struct dsi_pll_7nm *pll) pll_write(base + REG_DSI_7nm_PHY_PLL_FRAC_DIV_START_LOW_1, reg->frac_div_start_low); pll_write(base + REG_DSI_7nm_PHY_PLL_FRAC_DIV_START_MID_1, reg->frac_div_start_mid); pll_write(base + REG_DSI_7nm_PHY_PLL_FRAC_DIV_START_HIGH_1, reg->frac_div_start_high); - pll_write(base + REG_DSI_7nm_PHY_PLL_PLL_LOCKDET_RATE_1, 0x40); + pll_write(base + REG_DSI_7nm_PHY_PLL_PLL_LOCKDET_RATE_1, reg->pll_lockdet_rate); pll_write(base + REG_DSI_7nm_PHY_PLL_PLL_LOCK_DELAY, 0x06); pll_write(base + REG_DSI_7nm_PHY_PLL_CMODE_1, 0x10); /* TODO: 0x00 for CPHY */ pll_write(base + REG_DSI_7nm_PHY_PLL_CLOCK_INVERTERS, reg->pll_clock_inverters);