From patchwork Wed Mar 3 13:43:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 392095 Delivered-To: patch@linaro.org Received: by 2002:a02:290e:0:0:0:0:0 with SMTP id p14csp5133479jap; Wed, 3 Mar 2021 05:44:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJyLf4vZ+mIdjvu+SHSqkyzczB5CjCqgyWLc/SnFw8vurD2ZFWrc6xPIOE9J+ygoEb4btAK5 X-Received: by 2002:aa7:8c10:0:b029:1ee:ff57:8b96 with SMTP id c16-20020aa78c100000b02901eeff578b96mr1307717pfd.72.1614779081131; Wed, 03 Mar 2021 05:44:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614779081; cv=none; d=google.com; s=arc-20160816; b=pMrvHuBYGuOyg2qiBmg9BLHkk+6sli+AoaEMgfPXUWSDwrGaym7pOrv1hsRsqha6h7 AQsqepgGfOkj71+2/0fjP7w7T8Ii5Ra/sgSroQ9y5BTad8gsDxmKIwKwkMHz5wvG5CJq HUDtmqE7vST7eHNWBmAogNKvp1LVUeJJb92wC30NimAJ7UBe1OsSST6b+zRGsBxNyKu7 SdFX8bsXnrYk/fY6kA4+z+6rRqY8v5JmmsBwA357RwzBHoBDwpfUYAR0ZySB0eLm6P+n 8J29YvMFo9N7uR5YItXLVQmzlh8AfGgauYbYxrz+uSBfpgjoWfg4YMLghUrCLf3pBME1 bY2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=ASeG9SvhGv8QEt+8kqJJUHPbQOrtdaY6Ttm3xqRQFuY=; b=HI9oavAz8M6Ao4uE7k9oiJFoHOkp7r713zAaPASAnEby4Gn6ZLVITuO4+7i5BOLhv3 aqguYb38ThtMgUrNWHs6PlaBDPKc+0qREFEw5FTwrUI9bymYQkhigULyqsg1B4YLcxkB vjXng5xUEtvYZY5VIiAixWwHZDbxArOQXxmSoCNTFKKBnIj8oJHwyETYlLw+HoOJGf2E c4sqAc4/xUpPAzUGAmc2Ap/kHnSQxKrRNCXcEu/rRA3kbByCTwFR3+a9VdjmptO5htLM FjZIo9Qtnh/Xj4tVun9Ci7x+xNRdMh6FWvGZFAG9z1ldleyqlu4t7KwNo8UNaTXAkKDw q73Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=fth9eihh; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id k28si23418559pgb.391.2021.03.03.05.44.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 05:44:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=fth9eihh; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E5C1E6E930; Wed, 3 Mar 2021 13:44:12 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by gabe.freedesktop.org (Postfix) with ESMTPS id A157B6E906 for ; Wed, 3 Mar 2021 13:44:10 +0000 (UTC) Received: by mail-wm1-x333.google.com with SMTP id l22so5231020wme.1 for ; Wed, 03 Mar 2021 05:44:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yJ/EY0CpLytL31e4vbvBGoD9fXz/ITb5FniloFYVPls=; b=fth9eihhtdzQbeSYvJf7E98nX3F1qwaKJid/2LAs8W8ejpmJFd5zCTTAu4t22jj694 4q5PYQxQxmsJL4MzqFOwHepz7BE3Ig0p+xL0EH0m3wXa7KowSJaYJrOmawSXWuNcjVo8 sPAf4GjUb7uB7kBrcejlHDObUvjzfH8jPeovCJ0/2uXTKy0bsQpNFjvrGPIqYZAljZQP m3z4DKaEqxXv1osCoSW+anx0GtTEaeiBOA4hqedbmew4eadlIw0bhmrb6d/5j5b0FxSQ wxrxxCwZY0uqH5JUbDmmLAYfrRMDknTei8gcYxkuRxquA/AGG3Xx8QvzLP8Zwg2CHACt Fgvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yJ/EY0CpLytL31e4vbvBGoD9fXz/ITb5FniloFYVPls=; b=GkzEkt/SEQy6BjFFIGokuBrT1xMaeBgk4vyqv+8eWtSld+23Q9zOT/0D2hCn84uqQI KA4vrEvtrYpRnLwlq9p1d/mYQ8beNIhnWCgBk0YDQ0309ZLBdppr8VshK1yg3q1igVyl wF7jqG+M2zytzht/+28vTn/R726WZ5U8SPgD34GmGd8H0J/4HJczgrq40PaqutjAFhCO 4gPNy/DeWmZSwPx+qY3jiHnZ7gGtxDI7MJMTaLSUyJVBoKhJKsrdrp9P3Kk0iFGWepnK KEyHOoThVh8K6b5KTtS89FtFiXPKYvUMnkkVK860YyRWuBBar48FngZVOkSGQWc/1EcA RbOw== X-Gm-Message-State: AOAM532dgUdderfXjduLYi+e32B4xA+H7LidgjiJmDXY7BIN95wsBe5O eU65s+XnQftePNY0TUKIzd7vbA== X-Received: by 2002:a1c:de05:: with SMTP id v5mr5495703wmg.25.1614779049321; Wed, 03 Mar 2021 05:44:09 -0800 (PST) Received: from dell.default ([91.110.221.155]) by smtp.gmail.com with ESMTPSA id w18sm6109524wrr.7.2021.03.03.05.44.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 05:44:08 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 34/53] drm/vmwgfx/vmwgfx_fence: Add, remove and demote various documentation params/headers Date: Wed, 3 Mar 2021 13:43:00 +0000 Message-Id: <20210303134319.3160762-35-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210303134319.3160762-1-lee.jones@linaro.org> References: <20210303134319.3160762-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Roland Scheidegger , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, =?utf-8?q?Christian_K=C3=B6nig?= , linaro-mm-sig@lists.linaro.org, VMware Graphics , linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:82: warning: Function parameter or member 'event' not described in 'vmw_event_fence_action' drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:113: warning: Function parameter or member 'f' not described in 'vmw_fence_obj_destroy' drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:261: warning: Function parameter or member 'work' not described in 'vmw_fence_work_func' drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:720: warning: Function parameter or member 'fman' not described in 'vmw_fence_fifo_down' drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:963: warning: Function parameter or member 'fence' not described in 'vmw_fence_obj_add_action' drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:963: warning: Function parameter or member 'action' not described in 'vmw_fence_obj_add_action' drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:1021: warning: Function parameter or member 'tv_sec' not described in 'vmw_event_fence_action_queue' drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:1021: warning: Function parameter or member 'tv_usec' not described in 'vmw_event_fence_action_queue' Cc: VMware Graphics Cc: Roland Scheidegger Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones Signed-off-by: Zack Rusin Link: https://patchwork.freedesktop.org/patch/msgid/20210115181313.3431493-27-lee.jones@linaro.org --- drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c index 378ec7600154b..23523eb3cac2a 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c @@ -58,13 +58,11 @@ struct vmw_user_fence { /** * struct vmw_event_fence_action - fence action that delivers a drm event. * - * @e: A struct drm_pending_event that controls the event delivery. * @action: A struct vmw_fence_action to hook up to a fence. + * @event: A pointer to the pending event. * @fence: A referenced pointer to the fence to keep it alive while @action * hangs on it. * @dev: Pointer to a struct drm_device so we can access the event stuff. - * @kref: Both @e and @action has destructors, so we need to refcount. - * @size: Size accounted for this object. * @tv_sec: If non-null, the variable pointed to will be assigned * current time tv_sec val when the fence signals. * @tv_usec: Must be set if @tv_sec is set, and the variable pointed to will @@ -87,7 +85,7 @@ fman_from_fence(struct vmw_fence_obj *fence) return container_of(fence->base.lock, struct vmw_fence_manager, lock); } -/** +/* * Note on fencing subsystem usage of irqs: * Typically the vmw_fences_update function is called * @@ -250,7 +248,7 @@ static const struct dma_fence_ops vmw_fence_ops = { }; -/** +/* * Execute signal actions on fences recently signaled. * This is done from a workqueue so we don't have to execute * signal actions from atomic context. @@ -708,7 +706,7 @@ int vmw_wait_dma_fence(struct vmw_fence_manager *fman, } -/** +/* * vmw_fence_fifo_down - signal all unsignaled fence objects. */ @@ -948,8 +946,8 @@ static void vmw_event_fence_action_cleanup(struct vmw_fence_action *action) /** * vmw_fence_obj_add_action - Add an action to a fence object. * - * @fence - The fence object. - * @action - The action to add. + * @fence: The fence object. + * @action: The action to add. * * Note that the action callbacks may be executed before this function * returns. @@ -1001,6 +999,10 @@ static void vmw_fence_obj_add_action(struct vmw_fence_obj *fence, * @fence: The fence object on which to post the event. * @event: Event to be posted. This event should've been alloced * using k[mz]alloc, and should've been completely initialized. + * @tv_sec: If non-null, the variable pointed to will be assigned + * current time tv_sec val when the fence signals. + * @tv_usec: Must be set if @tv_sec is set, and the variable pointed to will + * be assigned the current time tv_usec val when the fence signals. * @interruptible: Interruptible waits if possible. * * As a side effect, the object pointed to by @event may have been