From patchwork Wed Mar 3 13:43:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 392106 Delivered-To: patch@linaro.org Received: by 2002:a02:290e:0:0:0:0:0 with SMTP id p14csp5133695jap; Wed, 3 Mar 2021 05:44:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJyEALsDJVaqc4eYBJTa6YKtpJJyQIv1BmZOgiWD+wdR5akHlduxxteNLi92J7zNc5xTFeaz X-Received: by 2002:a17:902:8c97:b029:e2:8c58:153f with SMTP id t23-20020a1709028c97b02900e28c58153fmr2822301plo.79.1614779098570; Wed, 03 Mar 2021 05:44:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614779098; cv=none; d=google.com; s=arc-20160816; b=AnVvvgbZSEJWddfEyeEC02D1bnVDcYZht/JpjOCWUT3tPPPPWWFJgjJBsKuBmkxm9X ehidNNOxKhSUWzIhAfuAS5gNB3W2fuofZF9shiJUqaBdPJ9NSr467xmeFjJ8Rl+xySqm girWMe05OtnpOzGSclFFsldNqNbCKxTmLVWtRVkx3kj9UnmFSBP64smphmNCwd0Xh7ic vq+R5ccKWrSxvfM828gqe0DsORZ7I/4uHmVWAAF56Z8ziqbBZTyOdY4TOSG8UrLJpSE+ lK0NnrMhI8orR6/Q6xW/n+acPp/sOy3qKH4n5S2UBMrzvF3btk59M8PNh2UPABeuO/PM ruXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=A9LY8qPnrncUfKghcot+iLCZgIAvGYPqWbZNhPYul2k=; b=MwYtvBfwCk3/GyciVbsXq55ghiXASdl04/pqoYInzQWYQbHCrneCCVgFP5o/012q0g zEnLyaILVTglRu6xtxrXrVLBU5b3bIIbAab5K9itMfIRjLk1Hmc/Qy2Q5/rncdhqhlUM uXvu9TOq1JPW8qVhDajJBuNHOdeur7rDruoOMfsJjeBtbEMUIXk+YQLQn9uS0YVppvPZ csQA1gReg5OOYlo5AbUIHNMnKRHjA5+NnplDSvaNm3vN30osc06Xz+jdEw9+rgUldVrB hBSBgoL1IIizW232+l/5rxU1Ye2N41DfhALEQh/WT2xn7D88Pk7+7rcdIogSrRsQGMQq Z3aw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=M3vfJNli; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id q18si23833355pgn.591.2021.03.03.05.44.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 05:44:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=M3vfJNli; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3EBBD6E97B; Wed, 3 Mar 2021 13:44:24 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 88AFD6E958 for ; Wed, 3 Mar 2021 13:44:20 +0000 (UTC) Received: by mail-wr1-x42e.google.com with SMTP id f12so19932910wrx.8 for ; Wed, 03 Mar 2021 05:44:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vEJvtnthzxGLrB5bQwa4uMR+8QlI7X4kpk4nucMTE3c=; b=M3vfJNlivn2MoPxBwPRWD4bTTqeqqG8QnJoarAygkTYue/NKMFOklFxuJPRD4hPDGR n29NRPFIHqLXys8C0/TLJRC1IiyQJiSwdI96kiLnquGwIc1Q2EprMXp2s/OmL5e1ppvE zt3wJKtimq5Fqv6t/Tppo9p5QJyfYLq6DSVM7GywQNabq/fXvDzTtJmFfY368k5dufGZ JWZDg/rqsmdWQz54JeK6Q1eXYSl4Y2lcjN1Oe2yyQGBpUPnTab4IVQiS4C1Ch38dR81N u40lqKp3osyQFcCWbZOWzvUjCbweeaFd+Em42nbsPDkaab76WQxvgAxyopt4BKk0dHnD cS7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vEJvtnthzxGLrB5bQwa4uMR+8QlI7X4kpk4nucMTE3c=; b=IiQiaOOf3djLZwGI6ATHn6KH8enjUB606mqxbx0J8wpp2ZVsB3lKZAuoikgb94KSAb SDBOvDC7Wa6a9MXsrNL9oIZ9p4QdwWXvsNDjaNbZ3wy3tLlzcm3GsmQoOYGoD9/NiqFv ROeQMZE7vs0hD4CXsrx81ILaAdKn+bYfW4yIb6sYLLQdZSt2EkBC5Wsfx2JNU26RpHQE /CeZM8x2Kx66TCwk410KekbG4PRV5NW2B0O58HlRXM0dyUfpMH0yo7LQFRwmn4C09MS8 Abfh0+V429uosss1wXXO2coihjv5rIz6SAu44BoPXZWgJQppYOYpUu3qc3eT/XP0Lgjk bJxQ== X-Gm-Message-State: AOAM531G+cEyY4rRl5q6cvVgPbIR0oVUM1S6jmgoD3dw9XsPk7FeBEdM EYOm7kQbuaz8ZRpmAbWd1VGXXQ== X-Received: by 2002:adf:f743:: with SMTP id z3mr26906208wrp.304.1614779059267; Wed, 03 Mar 2021 05:44:19 -0800 (PST) Received: from dell.default ([91.110.221.155]) by smtp.gmail.com with ESMTPSA id w18sm6109524wrr.7.2021.03.03.05.44.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 05:44:18 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 43/53] drm/vmwgfx/vmwgfx_stdu: Add some missing param/member descriptions Date: Wed, 3 Mar 2021 13:43:09 +0000 Message-Id: <20210303134319.3160762-44-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210303134319.3160762-1-lee.jones@linaro.org> References: <20210303134319.3160762-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Roland Scheidegger , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, VMware Graphics Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c:77: warning: Function parameter or member 'pitch' not described in 'vmw_stdu_dirty' drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c:125: warning: Function parameter or member 'content_fb_type' not described in 'vmw_screen_target_display_unit' drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c:125: warning: Function parameter or member 'display_width' not described in 'vmw_screen_target_display_unit' drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c:125: warning: Function parameter or member 'display_height' not described in 'vmw_screen_target_display_unit' drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c:125: warning: Function parameter or member 'cpp' not described in 'vmw_screen_target_display_unit' drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c:682: warning: Function parameter or member 'user_fence_rep' not described in 'vmw_kms_stdu_dma' Cc: VMware Graphics Cc: Roland Scheidegger Cc: Zack Rusin Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones Signed-off-by: Zack Rusin Link: https://patchwork.freedesktop.org/patch/msgid/20210115181313.3431493-41-lee.jones@linaro.org --- drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) -- 2.27.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c b/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c index fbe9778813648..01567534f4fae 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c @@ -61,6 +61,7 @@ enum stdu_content_type { * @bottom: Bottom side of bounding box. * @fb_left: Left side of the framebuffer/content bounding box * @fb_top: Top of the framebuffer/content bounding box + * @pitch: framebuffer pitch (stride) * @buf: buffer object when DMA-ing between buffer and screen targets. * @sid: Surface ID when copying between surface and screen targets. */ @@ -109,8 +110,11 @@ struct vmw_stdu_update_gb_image { * content_vfbs dimensions, then this is a pointer into the * corresponding field in content_vfbs. If not, then this * is a separate buffer to which content_vfbs will blit to. - * @content_type: content_fb type - * @defined: true if the current display unit has been initialized + * @content_fb_type: content_fb type + * @display_width: display width + * @display_height: display height + * @defined: true if the current display unit has been initialized + * @cpp: Bytes per pixel */ struct vmw_screen_target_display_unit { struct vmw_display_unit base; @@ -652,6 +656,7 @@ static void vmw_stdu_bo_cpu_commit(struct vmw_kms_dirty *dirty) * @file_priv: Pointer to a struct drm-file identifying the caller. May be * set to NULL, but then @user_fence_rep must also be set to NULL. * @vfb: Pointer to the buffer-object backed framebuffer. + * @user_fence_rep: User-space provided structure for fence information. * @clips: Array of clip rects. Either @clips or @vclips must be NULL. * @vclips: Alternate array of clip rects. Either @clips or @vclips must * be NULL.