From patchwork Sat May 8 03:48:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhen Lei X-Patchwork-Id: 432594 Delivered-To: patch@linaro.org Received: by 2002:a02:c901:0:0:0:0:0 with SMTP id t1csp904534jao; Fri, 7 May 2021 20:48:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLdJaZNv1+w7GnAYM6RJDfWQ9+kHTImEMrSCz/IC6RmvXCTgrl9n9O74rJ4hT5BxQNhF+H X-Received: by 2002:a63:e903:: with SMTP id i3mr13353382pgh.374.1620445709757; Fri, 07 May 2021 20:48:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620445709; cv=none; d=google.com; s=arc-20160816; b=ogSLLdr+2MuHa0jVcrblx6iZubAeJVVhSbxSTKhfxtN4O1nkhlwQeW/Tu+9Zm6GovP a3FLyf403kncMuiyP3JNM430nBMvUdy5ARgYp9RgMkNp82t3ZiZ5qr/4Hwf5lcXW79h9 vCXSA3zc3HkmNdVyM2cqgKQVxDFKC/fP5AwJ0S9CYg6XW1b3sAjYZoOGDSlk8kV6wKRY MPP5bCauOS1leUoNzICCFoCy7mtkQncrPWwVWhZNmfVfcJrLnXx3vVT1UuQ9ervu9UdF Tm7OewgyS/w5a0hTZ0Fd4OeRo+VkPmLB7I7BQRuKUrmG1qWfi9ZDpIDYMypSt76gAB1b L8IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:delivered-to; bh=i7FrhhpjXVNNhuY/nXXlBo5ww7K+Qtq1+YpI48/244w=; b=btcrUo5+5zugsq5dhvlSPXvtF7ezd+RxR7kxsR5LuCMvuqdItPVG8vTiRU8WTsN+AS skyMpdvChETPvuymAYcUbBZimfvpgqm/oJomXUahBiptzK7+DCpIJb4EDlfGs6Vr/73N fbjp/BKYtD0CzU08NbTdnQwVk+/bVVNVOj2eIkyfOiEoR53M89SxOEex2P7pvbh+ju/c zXfZXEPU+FPgAprY0zVJXfVcm63ZIGISuVMmJVzpv7bXg66Fgyil8C1cl08BlB9oAzzH aFjopb/6GkiBXSF5HnkStcwvIppw1ipOkoQYEoKiGU0XD9ZaxZCbTiQ1ICpTe2rWcgZ2 ywtQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id t129si9046267pfb.112.2021.05.07.20.48.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 May 2021 20:48:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 483D56E84A; Sat, 8 May 2021 03:48:26 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by gabe.freedesktop.org (Postfix) with ESMTPS id AFC886E84A; Sat, 8 May 2021 03:48:25 +0000 (UTC) Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FcYBL2G1JzkX91; Sat, 8 May 2021 11:45:46 +0800 (CST) Received: from thunder-town.china.huawei.com (10.174.177.72) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.498.0; Sat, 8 May 2021 11:48:15 +0800 From: Zhen Lei To: Ben Skeggs , David Airlie , "Daniel Vetter" , Pierre Moreau , dri-devel , nouveau , linux-kernel Subject: [PATCH 1/1] drm/nouveau: fix error return code in nouveau_backlight_init() Date: Sat, 8 May 2021 11:48:10 +0800 Message-ID: <20210508034810.2374-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.177.72] X-CFilter-Loop: Reflected X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhen Lei Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: db1a0ae21461 ("drm/nouveau/bl: Assign different names to interfaces") Reported-by: Hulk Robot Signed-off-by: Zhen Lei --- drivers/gpu/drm/nouveau/nouveau_backlight.c | 1 + 1 file changed, 1 insertion(+) -- 2.25.1 diff --git a/drivers/gpu/drm/nouveau/nouveau_backlight.c b/drivers/gpu/drm/nouveau/nouveau_backlight.c index 72f35a2babcb..097ca344a086 100644 --- a/drivers/gpu/drm/nouveau/nouveau_backlight.c +++ b/drivers/gpu/drm/nouveau/nouveau_backlight.c @@ -273,6 +273,7 @@ nouveau_backlight_init(struct drm_connector *connector) return -ENOMEM; if (!nouveau_get_backlight_name(backlight_name, bl)) { + ret = -ENOSPC; NV_ERROR(drm, "Failed to retrieve a unique name for the backlight interface\n"); goto fail_alloc; }