From patchwork Wed Jan 5 23:26:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 530178 Delivered-To: patch@linaro.org Received: by 2002:ad5:544f:0:0:0:0:0 with SMTP id a15csp708545imp; Wed, 5 Jan 2022 15:27:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJwQs4xUddQCUo8/CnnqG1CKiwKtieJNGO8eOWByEBG/QcNc0A+75tO/tHoDv3ZZkCIylmn0 X-Received: by 2002:a63:69c7:: with SMTP id e190mr50580792pgc.440.1641425228365; Wed, 05 Jan 2022 15:27:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1641425228; cv=none; d=google.com; s=arc-20160816; b=gwKbJiA1tIlgqUH/KWk3Q0YHuali+LfEzsfFXwbDoODPUKFrhRqSA8sFE1Inh9CzBE MSSUoCzftws3Lqsh64PYMQeuHVKsKIjHlGmBoQzAOAsUxkR+16Upz0Fs7d8OXf1A5laf q6rUeAgLfQzOaflpyhiGSLvEuc2tDIAVZ88Skqbj976/36VvHqDKBCU6o9DoPEudKybX WuI7b+ZY0ullm4ji4XHp/DBdIC0Yg0O+LF9RbI2o0dyIsXb5vnmcsT3MnHyE6wyij3vh itOtXg6/KDkd6/43FncZym1tMNWmCNfSL8y0D35c/UzMAnRqrkR89N9tT9Lj6vppWo5b /OpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:dkim-signature :delivered-to; bh=RQh0W27z9Rv8021nYV+r9aQSz9qOZHpHoOU5e94BJ0c=; b=XYRhl+qWBeSZ6m7XYYADPr6L1+9LywiROlun7VRYbwbsnuK6UAK+i1+kdV4FQjGRcB AiAIiMz1bI+Z3sYamZAW91pc6TZF/QMYTPUMUNp4sulR/eW3xmDG80hV6cG+lXoEd0M8 zatweMazce7g7JvtK4V6JtCbKyArxYMgWEkordvfuNaP/9jpiUujra7ctx1giWkzUW9D uPho55SIPmy6jbuFtX3d48LWES3rM32P8L8KKwTfS46qmCJNsxLJkKZ00QlIMVseFt+S MRVS7tc54JzSkalf/mGQNd0C0HqbNsoKaifWepEqKouDWM/r1SS2Q6QR4dBRei58lEc2 WKqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=WmXDkjdu; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id j2si414742pfc.230.2022.01.05.15.27.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jan 2022 15:27:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=WmXDkjdu; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7A6F810E430; Wed, 5 Jan 2022 23:27:04 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7038810E425 for ; Wed, 5 Jan 2022 23:27:03 +0000 (UTC) Received: by mail-lj1-x22a.google.com with SMTP id q8so1275413ljp.9 for ; Wed, 05 Jan 2022 15:27:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=RQh0W27z9Rv8021nYV+r9aQSz9qOZHpHoOU5e94BJ0c=; b=WmXDkjduVnMsUHg2LOv65HvhWzePdCIECoq3lazikJl7anZYZaokQ839BsCpFkGfvq 3y9hMxtHV/ytT1WK5xnTTY4V+gPY3mx02MxNLqpMneQbARuampSNif3rlS3ldokxsG1l VUwLH6bY5gMmfGetALw+MeqBjj1WEmZxb4lTr3aqk4Djru+VAWAiVs9l80VyUGcGu5UM pRV+R3Rop1CacCnsBq1s7+frZCkGRWep89Re3RDw7b0MI6ip3lZGTdYcIfOLa/etIZGO 0eLPg67lt2uX/2+yuNqfxCjkGrJ7mVK/xI9rfwq8yFwMh0q4KB+R0ab8EChvn3DONSou xnbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=RQh0W27z9Rv8021nYV+r9aQSz9qOZHpHoOU5e94BJ0c=; b=rowWT/Z0EC/csaG+WkzUJneaR0Bm86qdqhnGz7rGfYGAxUHU2lIzSuIpD0xUY6IV4B LeygCa7cpRpU2Z+RTXbQGpFSsmxtS0TGdApZVCpN4Vq1HXtwsVkFRtWCYBx0xSqqv10w XnA1lLVV3bQOtLgRUpvMT8+kmp4idv0XDgDVOGkSJ0omvIPmGA32D1gi53eWY9p5FbIs x9yG9GJ59sdNloq+octAU9/E0slWS3B/0L53DNOyXtsKvn1aKSh5/8Ot3lPCCaQo1JtO UDuBzoyJwy7tV4I2aKHSqPnhPPezjbjqi9r5V7qGd1X8HdnhsDHNgALoSqChl53QAgwZ 6uKw== X-Gm-Message-State: AOAM533Mg2MvySllKYLDFaUjkGQOzaPTtDClhNBBOp49zmD3+h+oshfR g1u97EvD7WwmdI1eoedFUJ2KHA== X-Received: by 2002:a2e:9788:: with SMTP id y8mr44792149lji.135.1641425221796; Wed, 05 Jan 2022 15:27:01 -0800 (PST) Received: from eriador.lan ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id b29sm28730lfv.187.2022.01.05.15.27.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jan 2022 15:27:01 -0800 (PST) From: Dmitry Baryshkov To: Bjorn Andersson , Rob Clark , Sean Paul , Abhinav Kumar Subject: [PATCH v2 1/3] drm/msm: drop register logging support Date: Thu, 6 Jan 2022 02:26:58 +0300 Message-Id: <20220105232700.444170-1-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, Stephen Boyd , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Register logging was used during early stages of msm driver development to compare upstream and downstream register traces. However the tool was never updated to work with mdp5 hardware. Later it was dropped completely when Rob imported freedreno tools into mesa. All this makes DRM_MSM_REGISTER_LOGGING irrelevant now, so it can be dropped. Signed-off-by: Dmitry Baryshkov Reviewed-by: Stephen Boyd --- drivers/gpu/drm/msm/Kconfig | 9 --------- drivers/gpu/drm/msm/msm_drv.c | 16 +--------------- 2 files changed, 1 insertion(+), 24 deletions(-) diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig index 1eae5a9645f4..9b019598e042 100644 --- a/drivers/gpu/drm/msm/Kconfig +++ b/drivers/gpu/drm/msm/Kconfig @@ -33,15 +33,6 @@ config DRM_MSM_GPU_STATE depends on DRM_MSM && (DEBUG_FS || DEV_COREDUMP) default y -config DRM_MSM_REGISTER_LOGGING - bool "MSM DRM register logging" - depends on DRM_MSM - default n - help - Compile in support for logging register reads/writes in a format - that can be parsed by envytools demsm tool. If enabled, register - logging can be switched on via msm.reglog=y module param. - config DRM_MSM_GPU_SUDO bool "Enable SUDO flag on submits" depends on DRM_MSM && EXPERT diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index ad35a5d94053..cfc9a0c9ec39 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -57,14 +57,6 @@ static const struct drm_mode_config_helper_funcs mode_config_helper_funcs = { .atomic_commit_tail = msm_atomic_commit_tail, }; -#ifdef CONFIG_DRM_MSM_REGISTER_LOGGING -static bool reglog; -MODULE_PARM_DESC(reglog, "Enable register read/write logging"); -module_param(reglog, bool, 0600); -#else -#define reglog 0 -#endif - #ifdef CONFIG_DRM_FBDEV_EMULATION static bool fbdev = true; MODULE_PARM_DESC(fbdev, "Enable fbdev compat layer"); @@ -150,9 +142,6 @@ static void __iomem *_msm_ioremap(struct platform_device *pdev, const char *name return ERR_PTR(-ENOMEM); } - if (reglog) - printk(KERN_DEBUG "IO:region %s %p %08lx\n", dbgname, ptr, size); - if (psize) *psize = size; @@ -179,16 +168,13 @@ void __iomem *msm_ioremap_size(struct platform_device *pdev, const char *name, void msm_writel(u32 data, void __iomem *addr) { - if (reglog) - printk(KERN_DEBUG "IO:W %p %08x\n", addr, data); writel(data, addr); } u32 msm_readl(const void __iomem *addr) { u32 val = readl(addr); - if (reglog) - pr_err("IO:R %p %08x\n", addr, val); + return val; }