From patchwork Thu Apr 26 08:07:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jyri Sarha X-Patchwork-Id: 134420 Delivered-To: patch@linaro.org Received: by 10.46.151.6 with SMTP id r6csp1933380lji; Thu, 26 Apr 2018 01:07:26 -0700 (PDT) X-Google-Smtp-Source: AIpwx49ojy+RccAJJPYdNq+7odFffqX+ICIE4y6WYbmbiAQmY52KNqBBmjvWbhB5QeInoMyyI/KP X-Received: by 10.99.106.4 with SMTP id f4mr25885581pgc.225.1524730046562; Thu, 26 Apr 2018 01:07:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524730046; cv=none; d=google.com; s=arc-20160816; b=gFE+jBGysKB3jz/X8eYOOLNqk7qgvSZ+NeFnIBRHqWLFGsLnCPG830qX+JFlkHCBf/ WLV9GXbBPFcK5enMYIG0ZJvEhavkj8CjTfmoQmQnK31x/9I6Vcu+tZJNNEDDH00mAOvM SBQDCJAiv+cisRntMokqB5NlM49w5wgOn9wdmhuZSKeA98Zsz/A0kymtzVqG+K61PgY1 Mze1K+rfgaaixedeyAtx1XvvsVQMVUrS3YR4ZjXwudw3XgiodJYGcUQDP8dcXS9ZdZVa g38G6Uy7q8LWq2ARoi2HWykMK4BSvnN13Q6YZvzwJBfwTAtzanjguFYLbndjdWHRFyKZ MVwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to :arc-authentication-results; bh=pcefYDSZXUnPZqUjk/gti8X0Bn2dYXc0ErUv/tmiGOQ=; b=TGdd2Yh9oHVkBesVABFkuI7WWPit81hhnB5hm3Bl5I2Bor5NIJhcvgQDwEslIXlhNA 5P0BRq++aH7t7emrE+U9fy/LSlycneSlLn24OKr1DjkyTKTVP8Ou40yl98KINOApHZO5 69LDwrFFCHIwb/yw62L7lCLxXEXuU30HDhFjgDDpbWDXKSklaygqjBPvWXUrZtSH7AUF X7TX8Er698wPyPossrkKyqoBccvqcekCev8jVNxuV8271Gn9aWdjKg0cQ8Bctcs7a8ta 9WqF9659jjLeDg9MORmx10AcfaURpfUT+F8bAkhoNbfUmzfdPa6ZxfYTb6Z6tPaTWiLO bjuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@ti.com header.s=ti-com-17Q1 header.b=xjN4j04g; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id x32-v6si18283425pld.435.2018.04.26.01.07.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 Apr 2018 01:07:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@ti.com header.s=ti-com-17Q1 header.b=xjN4j04g; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BD0FB6E65B; Thu, 26 Apr 2018 08:07:22 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from fllnx210.ext.ti.com (fllnx210.ext.ti.com [198.47.19.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id BADC26E648 for ; Thu, 26 Apr 2018 08:07:17 +0000 (UTC) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by fllnx210.ext.ti.com (8.15.1/8.15.1) with ESMTP id w3Q87ARd022543; Thu, 26 Apr 2018 03:07:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1524730030; bh=5SC0eea48ALAwBzM2jbe6zeWMpxIz/gZTvJi0BL4DX4=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=xjN4j04gp+En4afvyAGpK5TN/HO+fqM1Ri0aJZvkTt01bdSKseNf0P2jOA/0dWvJl +59Q6Jnm+Zn7RGNz3Ec+v1OW5AjvlFcjFJwOsveQ7Gmp0+o86APn75XCjTlyuqisPS MpC2aHcgWGNTVKAru0FtbX9aQo7TcIk5aOrC7jMw= Received: from DFLE112.ent.ti.com (dfle112.ent.ti.com [10.64.6.33]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id w3Q87Amx012759; Thu, 26 Apr 2018 03:07:10 -0500 Received: from DFLE102.ent.ti.com (10.64.6.23) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Thu, 26 Apr 2018 03:07:10 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Thu, 26 Apr 2018 03:07:10 -0500 Received: from jadmar.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id w3Q872lU014814; Thu, 26 Apr 2018 03:07:07 -0500 From: Jyri Sarha To: Subject: [PATCH v4 2/2] drm/panel: Add device_link from panel device to drm device Date: Thu, 26 Apr 2018 11:07:00 +0300 Message-ID: X-Mailer: git-send-email 2.7.4 In-Reply-To: References: MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, Jyri Sarha , tomi.valkeinen@ti.com, thierry.reding@gmail.com, laurent.pinchart@ideasonboard.com, peda@axentia.se Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Add device_link from panel device (supplier) to drm device (consumer) when drm_panel_attach() is called. This patch should protect the master drm driver if an attached panel driver unbinds while it is in use. The device_link should make sure the drm device is unbound before the panel driver becomes unavailable. The device_link is removed when drm_panel_detach() is called. The drm_panel_detach() should be called by the consumer DRM driver, not the panel driver, otherwise both drivers are racing to delete the same link. Signed-off-by: Jyri Sarha Reviewed-by: Eric Anholt --- drivers/gpu/drm/drm_panel.c | 10 ++++++++++ include/drm/drm_panel.h | 1 + 2 files changed, 11 insertions(+) diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c index 71e4075..965530a 100644 --- a/drivers/gpu/drm/drm_panel.c +++ b/drivers/gpu/drm/drm_panel.c @@ -24,6 +24,7 @@ #include #include +#include #include #include @@ -104,6 +105,13 @@ int drm_panel_attach(struct drm_panel *panel, struct drm_connector *connector) if (panel->connector) return -EBUSY; + panel->link = device_link_add(connector->dev->dev, panel->dev, 0); + if (!panel->link) { + dev_err(panel->dev, "failed to link panel to %s\n", + dev_name(connector->dev->dev)); + return -EINVAL; + } + panel->connector = connector; panel->drm = connector->dev; @@ -125,6 +133,8 @@ EXPORT_SYMBOL(drm_panel_attach); */ int drm_panel_detach(struct drm_panel *panel) { + device_link_del(panel->link); + panel->connector = NULL; panel->drm = NULL; diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h index 14ac240..26a1b5f 100644 --- a/include/drm/drm_panel.h +++ b/include/drm/drm_panel.h @@ -89,6 +89,7 @@ struct drm_panel { struct drm_device *drm; struct drm_connector *connector; struct device *dev; + struct device_link *link; const struct drm_panel_funcs *funcs;