From patchwork Wed Nov 15 02:00:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Machado X-Patchwork-Id: 118891 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp3751377qgn; Tue, 14 Nov 2017 18:01:33 -0800 (PST) X-Google-Smtp-Source: AGs4zMbxoLshKkCAuxNpLuBnedO4nAMXN+cf6oBS4SHB5ValGemQtHHtgTX6O5G53AzS9welwR7l X-Received: by 10.98.69.209 with SMTP id n78mr15719344pfi.28.1510711293347; Tue, 14 Nov 2017 18:01:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510711293; cv=none; d=google.com; s=arc-20160816; b=QpJM/IgJfJzkte6KR+5mHnuhLqXqUw2x9WDCruALXbD2oa9VWmrVeMi5oT1bxK16ZR Urjntawl/ExnK4S9bAVmum2RzAR6wRr1BErhHyMSml+LvSpIBB6GCwE4xV3CXH2cQziB y2Y+FY6NoMTVLDvAi86bH98DbeT7tvhpdjyRmGw4RAtgE6MelGAPR/JKsEahmAJmizEf 6L6g0pAk3c4MhE5bXj4kjsaXA/1z5OhnRBOCPTo4+5fxwMYoQe3ygz/hpkn/5xNMeTYJ KQqk+6ogWMMUGug0gIjLnfbmScU0Q78OcZIts5l0HOA1h+Cro/reVJib1cJ2PDLeRW8i 8uRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:to:from:delivered-to:sender:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :mailing-list:dkim-signature:domainkey-signature :arc-authentication-results; bh=4i02gFws81KemOJGk3m4DMm+oh55X4O+/teduKMyyM0=; b=cX7KIbxOZ7A3ckR2SmxA+vNT2s+Dh/0M4bcrLC+sC+MSzcpYDEExmd276mPquKMOJC j/VESLot8FwuovO77248Ldd5rIinyQYFgTnbLWpOMmSRKrr+3/Brd213bgTZlykEplvj arAcF0YkBCQ8fpkhgITqzHrhFyDnb78jXVwaXuC0gH93D+x4BIEBwEpI4zud0JvpGgxS 4Lcw5msnohCSSL73yndWesps8i7E78OCS03l3oMRX57xbb7FOuL/VvNVjXQU7B52LbKW DIRkgJmtn0FKtY4ZG/7NVV6SxaKx7lcCw+AFou/5Sz/sfs/wE7yfaq/3s9/9nEsFs+Vh 1qdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=MfFNnykg; spf=pass (google.com: domain of gcc-patches-return-466800-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-466800-patch=linaro.org@gcc.gnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id bd7si16450257plb.694.2017.11.14.18.01.33 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Nov 2017 18:01:33 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-return-466800-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=MfFNnykg; spf=pass (google.com: domain of gcc-patches-return-466800-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-466800-patch=linaro.org@gcc.gnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id; q=dns; s=default; b=hxnHTctP0pt2rve pquIubPEC7iRCwxnb569rqB4+0rKVyt39v9AQ/C2iOjJQqgTpA5Z/to/B7KtCj1e i047pxNMHVyR/mQHpgj+EYdN6V/ofdHCz4PaRqeef3VjUEwBvJFVq6JGBNMph572 ZPWxMFotXUV5d4ksGOD7RHaHlSrA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id; s=default; bh=4iGk56x/EWTZHJe91xJTm VzJiow=; b=MfFNnykgMz2kaa6bm476g92Pf2PAhn1uqpZ5jOGGS6Xq4juneGcqV nuN/DgJxvpvyKwguFjKxUJTT8pj8FrtTobqj51sMuT6dOMWreGzxkQjUfO8CgYuH qFA5dGrerwbhbrbS6CcS0iERUJ8aA8UO+SBVa8+8JVho1fJVJNrj04= Received: (qmail 48554 invoked by alias); 15 Nov 2017 02:01:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 48495 invoked by uid 89); 15 Nov 2017 02:01:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-27.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KB_WAM_FROM_NAME_SINGLEWORD, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy=freeze, love X-HELO: mail-qt0-f179.google.com Received: from mail-qt0-f179.google.com (HELO mail-qt0-f179.google.com) (209.85.216.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 15 Nov 2017 02:01:09 +0000 Received: by mail-qt0-f179.google.com with SMTP id v41so31027294qtv.12 for ; Tue, 14 Nov 2017 18:01:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=4i02gFws81KemOJGk3m4DMm+oh55X4O+/teduKMyyM0=; b=jIlHufBi5PO8e2NAts0hC0JxKUjNqsshX8juxKO2kNdCI+bfK9j/x3IHmRrbaf2Kw5 Zs/kQQIiaDwoLJCNyf/UoRunFbHsZ1e5vTZdE/T5pIP0GiCUTrEZINZnTXlILGxM8rgS pM0mA4Dfx5mVcjpymPYBsqfhuECkhM0iAH9owls1j7vrywbsmiH1EZQGTVp6CumwKEHY Q6vuCSxwXrldekkZb9hedfuTcc2mqeq5Rnp+Urd4CFUd+44p6NewMAgtBUrBMvbD+/Lk cd0PqTpvE3eIwqktRjdZiY1MDwT2ezVLShBcNpEjiwfL9rcAN8STeos3ZxhWKx9NcxRd ZFwA== X-Gm-Message-State: AJaThX4PXhOVvRDsgaqTSJkrx9+7eY51VZNUEmN1BvzpFn35O/p+1Lop milEM9W70S9SE3h1huo1Ijb3uo/Jqro= X-Received: by 10.55.114.66 with SMTP id n63mr23139807qkc.167.1510711267042; Tue, 14 Nov 2017 18:01:07 -0800 (PST) Received: from localhost.localdomain ([179.154.140.131]) by smtp.gmail.com with ESMTPSA id 13sm3577525qtv.67.2017.11.14.18.01.05 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 14 Nov 2017 18:01:06 -0800 (PST) From: Luis Machado To: gcc-patches@gcc.gnu.org Subject: [PATCH, AArch64] Adjust tuning parameters for Falkor Date: Wed, 15 Nov 2017 00:00:56 -0200 Message-Id: <1510711256-1931-1-git-send-email-luis.machado@linaro.org> X-IsSubscribed: yes Disabling software prefetching and switching the autoprefetcher to weak improves CPU2017 rate and speed benchmarks for both int and fp sets on Falkor. SPECrate 2017 fp is up 0.38% SPECspeed 2017 fp is up 0.54% SPECrate 2017 int is up 3.02% SPECspeed 2017 int is up 3.16% There are only a couple individual regressions. The biggest one being about 4% in parest. For SPEC2006, we've noticed the following: SPECint is up 0.91% SPECfp is stable In the case of SPEC2006 we noticed both a big regression in mcf (about 20%) and a big improvement for hmmer (about 40%). Since the overall result is positive, we would like to make these new tuning settings the default for Falkor. We may revisit the software prefetcher setting in the future, in case we can adjust it enough so it provides us a good balance between improvements and regressions (mcf). But for now it is best if it stays off. I understand the freeze is happening soon, so it would be great to have this in before then. OK? Thanks, Luis 2017-11-14 Luis Machado * config/aarch64/aarch64.c (qdf24xx_prefetch_tune): Remove. (qdf24xx_tunings): Replace qdf24xx_prefetch_tune with generic_prefetch_tune and tune_params::AUTOPREFETCHER_STRONG with tune_params::AUTOPREFETCHER_WEAK. --- gcc/ChangeLog | 7 +++++++ gcc/config/aarch64/aarch64.c | 13 ++----------- 2 files changed, 9 insertions(+), 11 deletions(-) -- 2.7.4 diff --git a/gcc/ChangeLog b/gcc/ChangeLog index b80a421..4dbfda0 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@ +2017-11-14 Luis Machado + + * config/aarch64/aarch64.c (qdf24xx_prefetch_tune): Remove. + (qdf24xx_tunings): Replace qdf24xx_prefetch_tune with + generic_prefetch_tune and tune_params::AUTOPREFETCHER_STRONG with + tune_params::AUTOPREFETCHER_WEAK. + 2017-11-14 Carl Love * config/rs6000/rs6000.c (swap_endian_selector_for_mode): Remove diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c index 0c67e2b..171a230 100644 --- a/gcc/config/aarch64/aarch64.c +++ b/gcc/config/aarch64/aarch64.c @@ -502,15 +502,6 @@ static const cpu_prefetch_tune exynosm1_prefetch_tune = -1 /* default_opt_level */ }; -static const cpu_prefetch_tune qdf24xx_prefetch_tune = -{ - 4, /* num_slots */ - 32, /* l1_cache_size */ - 64, /* l1_cache_line_size */ - 1024, /* l2_cache_size */ - 3 /* default_opt_level */ -}; - static const cpu_prefetch_tune thunderxt88_prefetch_tune = { 8, /* num_slots */ @@ -817,9 +808,9 @@ static const struct tune_params qdf24xx_tunings = 2, /* min_div_recip_mul_sf. */ 2, /* min_div_recip_mul_df. */ 0, /* max_case_values. */ - tune_params::AUTOPREFETCHER_STRONG, /* autoprefetcher_model. */ + tune_params::AUTOPREFETCHER_WEAK, /* autoprefetcher_model. */ (AARCH64_EXTRA_TUNE_NONE), /* tune_flags. */ - &qdf24xx_prefetch_tune + &generic_prefetch_tune }; /* Tuning structure for the Qualcomm Saphira core. Default to falkor values