From patchwork Tue Mar 1 17:33:08 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Collison X-Patchwork-Id: 63317 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp1957080lbc; Tue, 1 Mar 2016 09:33:31 -0800 (PST) X-Received: by 10.66.248.168 with SMTP id yn8mr31666375pac.24.1456853610981; Tue, 01 Mar 2016 09:33:30 -0800 (PST) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id e29si51664348pfb.131.2016.03.01.09.33.30 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Mar 2016 09:33:30 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-return-422487-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; spf=pass (google.com: domain of gcc-patches-return-422487-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-422487-patch=linaro.org@gcc.gnu.org; dkim=pass header.i=@gcc.gnu.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to:cc :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=m78zazZboZeV7LiLbVc33U1hnvn4gMOVXEE+jOidHzrhduWrwj yZ/t7qb6U+uEQX5FDx5d7PMSUSmCPx4xnXqUBm9DttvdLaqnDSRO/AC0oLbYTwDG veK/4UBbmdke1zxGmACs/yLq50J09ickahrMN1yXsSkU4NftBz9FqGkFk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to:cc :from:subject:message-id:date:mime-version:content-type; s= default; bh=+QJvj01RM/lh3o55uSp+boGDHjI=; b=vmqXubsY2Qf7FQuWQj0h xAB01/oUTEyBx1xuCu4+Y4Hu9shCyMVW50jqCjzWiPBhrRw6jERX9yrKR7zpNhti HaqrqEVRvK1trKkSDFH8XtN60KLST3HUSph5JWrOikJ7o+W1xRh3phDjth23ZqUB mKMZeIrrFTpaRAA7j3uJ5AQ= Received: (qmail 14504 invoked by alias); 1 Mar 2016 17:33:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 13940 invoked by uid 89); 1 Mar 2016 17:33:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1194 X-HELO: mail-pa0-f44.google.com Received: from mail-pa0-f44.google.com (HELO mail-pa0-f44.google.com) (209.85.220.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 01 Mar 2016 17:33:12 +0000 Received: by mail-pa0-f44.google.com with SMTP id yy13so115592870pab.3 for ; Tue, 01 Mar 2016 09:33:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:to:cc:from:organization:subject:message-id:date :user-agent:mime-version; bh=a7EG8GHJ/420pMgDObrqejx6Axmq09v5vv3bSQ1//y4=; b=KRiNRGc1kCndiRSVCQGtYgEXRaVc5xkS8NVH5905AmyVuaksO8MwSePPq6arZdGtZq m8pSeEdl3aESWSVu37Rcd8wW4GlAwAc82aDgaYK0MuKWZ1WShJe6T84IUfh1LuO2hV9E 8kuoVtsYZY/Rdmu+uuPTzueRB4GbUFuEDiVrBpSyWrKLRg5I1utQ0+IFCx4svPK9M8k4 ShOwN4Idu1m/VGvGsy94TM2mMK3KhPPJ+gOZSCcCmLQS48RiwGo8edOcOKkS51YTiyI8 L9ZLIdYLtJN4j/ozSKzYYPz0pRrGZKBwUIt/u15zc8XRcH60LJs2IcUfwj/Pd66qOnid V/EA== X-Gm-Message-State: AD7BkJLQyreZyQQGodMXC+5m7IRX73C99Qc0SNTpnRFk8LJQOgpPwPeRCab6gec1kYIZjfF4 X-Received: by 10.66.190.229 with SMTP id gt5mr31968828pac.118.1456853590957; Tue, 01 Mar 2016 09:33:10 -0800 (PST) Received: from [192.168.1.9] (ip70-176-202-128.ph.ph.cox.net. [70.176.202.128]) by smtp.googlemail.com with ESMTPSA id qh8sm47021190pac.40.2016.03.01.09.33.09 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 01 Mar 2016 09:33:10 -0800 (PST) To: GCC Patches Cc: Richard Earnshaw , kyrylo.tkachov@arm.com, Ramana Radhakrishnan From: Michael Collison Subject: [PATCH][ARM] PR target/70014 Message-ID: <56D5D254.4050308@linaro.org> Date: Tue, 1 Mar 2016 10:33:08 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 This patches addresses PR 70014, where the predicates and operand do not match and could cause problems with the register allocator. Tested successfully on arm-none-linux-gnueabi arm-none-linux-gnuabihf armeb-none-linux-gnuabihf arm-none-eabi Okay for trunk? 2016-03-01 Michael Collison PR target/70014 * config/arm/arm.md (*subsi3_carryin_const): Change predicate for operand 1 to s_register_operand. Change predicate for operand 2 to arm_not_immediate_operand. -- Michael Collison Linaro Toolchain Working Group michael.collison@linaro.org diff --git a/gcc/config/arm/arm.md b/gcc/config/arm/arm.md index e67239d..47171b9 100644 --- a/gcc/config/arm/arm.md +++ b/gcc/config/arm/arm.md @@ -883,8 +883,8 @@ (define_insn "*subsi3_carryin_const" [(set (match_operand:SI 0 "s_register_operand" "=r") - (minus:SI (plus:SI (match_operand:SI 1 "reg_or_int_operand" "r") - (match_operand:SI 2 "arm_not_operand" "K")) + (minus:SI (plus:SI (match_operand:SI 1 "s_register_operand" "r") + (match_operand:SI 2 "arm_not_immediate_operand" "K")) (ltu:SI (reg:CC_C CC_REGNUM) (const_int 0))))] "TARGET_32BIT" "sbc\\t%0, %1, #%B2" -- 1.9.1