From patchwork Wed Aug 23 10:47:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Sandiford X-Patchwork-Id: 110728 Delivered-To: patch@linaro.org Received: by 10.140.95.78 with SMTP id h72csp3936940qge; Wed, 23 Aug 2017 03:47:26 -0700 (PDT) X-Received: by 10.84.253.8 with SMTP id z8mr2612813pll.142.1503485246075; Wed, 23 Aug 2017 03:47:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1503485246; cv=none; d=google.com; s=arc-20160816; b=Oyrrs2vbqxZPQEIn1qb6d8joqq1wqBOaqagoHE4aT77+E7Md5wm3aYPls5hfZvEDqa x5K1WTmEpUREJ9YwBsC2Yqepnna8Vr2i9EuBcqu6ISfHyercSU2rcfFReGAEgDS/nPi4 FJUpVZsiE3NM013QzgguGmeIQ+IDfxKGIbyDPg+eCtg3GVcdX9r2Fav5UJN4zyPWk5f6 0ygBJckP7HLRhPRPwmBDRVnV44d7rK4QR9R9KnQqvte0f5YBO7y/npCbISvLHpdcCbjy hxpsmYOuivfFQOpk2arIOGz5c3kP9K7Lg3guEmCyrV4oSm+yrRGQoYOc0uCIqdLpm7LK 1UCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:message-id:date:subject:mail-followup-to:to :from:delivered-to:sender:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mailing-list:dkim-signature :domainkey-signature:arc-authentication-results; bh=X5My8Oua15GrjGkijxcU3Xtik/Ok1fUhLMlXPRt1rbk=; b=R6EhxvHALezYGIxz9wY7Jvdgkv0F6R8UCIlpRJNGU0yN41IBy6kE2o/1j7JVgqcl2G q1rB7eI7UPomPsPx9VIV5YjhOo0QyAjs2un8Hjydf85Ee9aCpZzM5Itlbiluo5hSeSME GB+JiwLkgvzipEWRnNdejzRy6W6MZxjxGYjaCl8mUcsPKCbcVc6cxWIQOdKOT0RB/bt8 uZ+ko4UvOQ5+1wcpf2VbF6Zj+9vnwuKHc+yIvOHzyQb3wzMbYxBps4Q4J59pomTLe5CU Yk8yVyHOTob0hmKBCTTHS3S0QAq9Gk2PLnkgNknzM6v56U0uGr9s3KSMT61nZmaxrF+l AeWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=wxp9cyJn; spf=pass (google.com: domain of gcc-patches-return-460780-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-460780-patch=linaro.org@gcc.gnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id 94si965078pla.477.2017.08.23.03.47.25 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Aug 2017 03:47:26 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-return-460780-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=wxp9cyJn; spf=pass (google.com: domain of gcc-patches-return-460780-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-460780-patch=linaro.org@gcc.gnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:mime-version:content-type; q=dns; s= default; b=pvrkOqn59q0F6qW9e4A964DhvbagWhPee4TtmKsms/7baKZ9ESFYp K0NI61We4OptT3iWAnZ6HmZY1Q35dniS4K5zpbdVdBFC4Va1j/V22JoK5JDyQdnN kM91qqZiIetftu0Uyncn8QfwEH67DC4vajdbfcTAaKJQnpg7wnFbBk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:mime-version:content-type; s= default; bh=UK4Xuv3LRAi1BWVh5Ue6SJfygBM=; b=wxp9cyJnoNtOS+tqdOtf a5rdtieqZy6Y9qM3pm5kXxe271wz9OZAQFhrsj29/00K05L80wcAaEZC4G8DGdq1 dyUlZMPh6mwbUZ0XF5+c71Jf4O3HPCgP3dFkFMAZ3NBw29N1GsmSsP9L6fysCK2h iE0jE3ATwjCW11xiFC9WYBE= Received: (qmail 57639 invoked by alias); 23 Aug 2017 10:47:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 57612 invoked by uid 89); 23 Aug 2017 10:47:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_2, GIT_PATCH_3, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wr0-f182.google.com Received: from mail-wr0-f182.google.com (HELO mail-wr0-f182.google.com) (209.85.128.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Aug 2017 10:47:07 +0000 Received: by mail-wr0-f182.google.com with SMTP id f8so4279609wrf.3 for ; Wed, 23 Aug 2017 03:47:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:mail-followup-to:subject:date:message-id :user-agent:mime-version; bh=X5My8Oua15GrjGkijxcU3Xtik/Ok1fUhLMlXPRt1rbk=; b=jDJ4j14SEqV2Y5ldPOdhM+s3zE6rVSYyt7sdbWaJO8wqg4mI39txW5wPhq+vIC31kd LhnjbBH9tvAiQ4wDnCTT4Q1Q8vUe4nZKzM7aCX3qmMU++Yn5ANZHh9jcB/SFWJF36e5y 3TT5+Yds7aBZQxGPU6AKbNOgpOend4sVuaPk4uUb5AFfTfS1hPGGISn5Bx+NwNUNrLNf 3GX9us6trz0iGC6ZDlaMOmkDrAJoo1OqIka8Klpv/j5e2V4f41YopZ71wyGW3N5df2wL Hqi76foInRsZrUfu3mAf2ydsGBcBkSethdCBEVDDmioGUciCrla9uAmppj6hSJuCy3D0 aKJA== X-Gm-Message-State: AHYfb5gXqSWXe87YdcsE87nnN2dIfF38okN5bjwFh7xL8eYvMuj35n6u vKLWOZWQ1PAtaKJa7Qdgiw== X-Received: by 10.223.152.19 with SMTP id v19mr1259606wrb.60.1503485224548; Wed, 23 Aug 2017 03:47:04 -0700 (PDT) Received: from localhost (92.40.249.210.threembb.co.uk. [92.40.249.210]) by smtp.gmail.com with ESMTPSA id h2sm898190wrf.18.2017.08.23.03.47.03 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Aug 2017 03:47:03 -0700 (PDT) From: Richard Sandiford To: gcc-patches@gcc.gnu.org Mail-Followup-To: gcc-patches@gcc.gnu.org, richard.sandiford@linaro.org Subject: Make more use of HWI_COMPUTABLE_MODE_P Date: Wed, 23 Aug 2017 11:47:01 +0100 Message-ID: <87efs2v9wa.fsf@linaro.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 This patch uses HWI_COMPUTABLE_MODE_P (X) instead of GET_MODE_PRECISION (X) <= HOST_BITS_PER_WIDE_INT in cases where X also needs to be a scalar integer. Tested on aarch64-linux-gnu and x86_64-linux-gnu, and by making sure that there were no differences in testsuite assembly output for one target per CPU. OK to install? Richard 2017-08-23 Richard Sandiford Alan Hayward David Sherwood gcc/ * combine.c (simplify_comparison): Use HWI_COMPUTABLE_MODE_P. (record_promoted_value): Likewise. * expr.c (expand_expr_real_2): Likewise. * ree.c (update_reg_equal_equiv_notes): Likewise. (combine_set_extension): Likewise. * rtlanal.c (low_bitmask_len): Likewise. * simplify-rtx.c (neg_const_int): Likewise. (simplify_binary_operation_1): Likewise. Index: gcc/combine.c =================================================================== --- gcc/combine.c 2017-08-22 17:14:30.333927457 +0100 +++ gcc/combine.c 2017-08-23 10:44:17.183477418 +0100 @@ -11821,10 +11821,9 @@ simplify_comparison (enum rtx_code code, if (paradoxical_subreg_p (inner_op0) && GET_CODE (inner_op1) == SUBREG + && HWI_COMPUTABLE_MODE_P (GET_MODE (SUBREG_REG (inner_op0))) && (GET_MODE (SUBREG_REG (inner_op0)) == GET_MODE (SUBREG_REG (inner_op1))) - && (GET_MODE_PRECISION (GET_MODE (SUBREG_REG (inner_op0))) - <= HOST_BITS_PER_WIDE_INT) && (0 == ((~c0) & nonzero_bits (SUBREG_REG (inner_op0), GET_MODE (SUBREG_REG (inner_op0))))) && (0 == ((~c1) & nonzero_bits (SUBREG_REG (inner_op1), @@ -13158,7 +13157,7 @@ record_promoted_value (rtx_insn *insn, r unsigned int regno = REGNO (SUBREG_REG (subreg)); machine_mode mode = GET_MODE (subreg); - if (GET_MODE_PRECISION (mode) > HOST_BITS_PER_WIDE_INT) + if (!HWI_COMPUTABLE_MODE_P (mode)) return; for (links = LOG_LINKS (insn); links;) Index: gcc/expr.c =================================================================== --- gcc/expr.c 2017-08-21 15:50:48.660709938 +0100 +++ gcc/expr.c 2017-08-23 10:44:17.184477384 +0100 @@ -8455,7 +8455,7 @@ #define REDUCE_BIT_FIELD(expr) (reduce_b if (modifier == EXPAND_STACK_PARM) target = 0; if (TREE_CODE (treeop0) == INTEGER_CST - && GET_MODE_PRECISION (mode) <= HOST_BITS_PER_WIDE_INT + && HWI_COMPUTABLE_MODE_P (mode) && TREE_CONSTANT (treeop1)) { rtx constant_part; @@ -8478,7 +8478,7 @@ #define REDUCE_BIT_FIELD(expr) (reduce_b } else if (TREE_CODE (treeop1) == INTEGER_CST - && GET_MODE_PRECISION (mode) <= HOST_BITS_PER_WIDE_INT + && HWI_COMPUTABLE_MODE_P (mode) && TREE_CONSTANT (treeop0)) { rtx constant_part; Index: gcc/ree.c =================================================================== --- gcc/ree.c 2017-08-22 17:14:30.338850894 +0100 +++ gcc/ree.c 2017-08-23 10:44:17.185477350 +0100 @@ -268,7 +268,7 @@ update_reg_equal_equiv_notes (rtx_insn * /* Update equivalency constants. Recall that RTL constants are sign-extended. */ if (GET_CODE (orig_src) == CONST_INT - && HOST_BITS_PER_WIDE_INT >= GET_MODE_BITSIZE (new_mode)) + && HWI_COMPUTABLE_MODE_P (new_mode)) { if (INTVAL (orig_src) >= 0 || code == SIGN_EXTEND) /* Nothing needed. */; @@ -336,7 +336,7 @@ combine_set_extension (ext_cand *cand, r /* Merge constants by directly moving the constant into the register under some conditions. Recall that RTL constants are sign-extended. */ if (GET_CODE (orig_src) == CONST_INT - && HOST_BITS_PER_WIDE_INT >= GET_MODE_BITSIZE (cand->mode)) + && HWI_COMPUTABLE_MODE_P (cand->mode)) { if (INTVAL (orig_src) >= 0 || cand->code == SIGN_EXTEND) new_set = gen_rtx_SET (new_reg, orig_src); Index: gcc/rtlanal.c =================================================================== --- gcc/rtlanal.c 2017-08-22 17:14:30.340820268 +0100 +++ gcc/rtlanal.c 2017-08-23 10:44:17.187477282 +0100 @@ -5782,7 +5782,7 @@ low_bitmask_len (machine_mode mode, unsi { if (mode != VOIDmode) { - if (GET_MODE_PRECISION (mode) > HOST_BITS_PER_WIDE_INT) + if (!HWI_COMPUTABLE_MODE_P (mode)) return -1; m &= GET_MODE_MASK (mode); } Index: gcc/simplify-rtx.c =================================================================== --- gcc/simplify-rtx.c 2017-08-22 17:14:30.340820268 +0100 +++ gcc/simplify-rtx.c 2017-08-23 10:44:17.187477282 +0100 @@ -62,7 +62,7 @@ neg_const_int (machine_mode mode, const_ { unsigned HOST_WIDE_INT val = -UINTVAL (i); - if (GET_MODE_PRECISION (mode) > HOST_BITS_PER_WIDE_INT + if (!HWI_COMPUTABLE_MODE_P (mode) && val == UINTVAL (i)) return simplify_const_unary_operation (NEG, mode, CONST_CAST_RTX (i), mode); @@ -3351,7 +3351,8 @@ simplify_binary_operation_1 (enum rtx_co if (trueop0 == CONST0_RTX (mode) && ! side_effects_p (op1)) return op0; /* Rotating ~0 always results in ~0. */ - if (CONST_INT_P (trueop0) && width <= HOST_BITS_PER_WIDE_INT + if (CONST_INT_P (trueop0) + && HWI_COMPUTABLE_MODE_P (mode) && UINTVAL (trueop0) == GET_MODE_MASK (mode) && ! side_effects_p (op1)) return op0; @@ -3433,7 +3434,7 @@ simplify_binary_operation_1 (enum rtx_co goto canonicalize_shift; case SMIN: - if (width <= HOST_BITS_PER_WIDE_INT + if (HWI_COMPUTABLE_MODE_P (mode) && mode_signbit_p (mode, trueop1) && ! side_effects_p (op0)) return op1; @@ -3445,7 +3446,7 @@ simplify_binary_operation_1 (enum rtx_co break; case SMAX: - if (width <= HOST_BITS_PER_WIDE_INT + if (HWI_COMPUTABLE_MODE_P (mode) && CONST_INT_P (trueop1) && (UINTVAL (trueop1) == GET_MODE_MASK (mode) >> 1) && ! side_effects_p (op0))