From patchwork Tue Oct 18 17:04:15 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernd Edlinger X-Patchwork-Id: 78108 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp984337qge; Tue, 18 Oct 2016 10:04:45 -0700 (PDT) X-Received: by 10.98.75.152 with SMTP id d24mr2354835pfj.97.1476810285689; Tue, 18 Oct 2016 10:04:45 -0700 (PDT) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id n17si33196378pgd.291.2016.10.18.10.04.45 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Oct 2016 10:04:45 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-return-438944-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org; spf=pass (google.com: domain of gcc-patches-return-438944-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-438944-patch=linaro.org@gcc.gnu.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:references:in-reply-to :content-type:mime-version; q=dns; s=default; b=MAhDHCTxtDrevvC5 WFo+JDzoUTVN4MzarRNf1cpmdX8ar9FkELmcsoyu9E0WZI/nVhS7j8UR+zKv/BoB uRoM16lTQQxGgvilg38yXWhw54Tx0wLZYgapUpqaqCV5WoryHAs+j+MglS7F4xk1 yN2P3c1MiVf6suEs6V/Fe8LTxiw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:references:in-reply-to :content-type:mime-version; s=default; bh=xclhhDlFWnBx3uftKRZxBH 6dlaA=; b=U2U3JENQbDA4bvzy0IMERC5MXbsLquLzNR316cAIraYemW0lH5kxW9 tYUopjg02agFVL41/PnKfY+iVSCwecDjJcOfIGR8EPvHDkNY0R5enmFaufhjKA8n xUsfWzMpD2aKVhNLLOGKVGy0eQ/XttqCZnW8rdKisfqyfmmEtbM60= Received: (qmail 41170 invoked by alias); 18 Oct 2016 17:04:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 41160 invoked by uid 89); 18 Oct 2016 17:04:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=H*c:HHH X-HELO: COL004-OMC1S6.hotmail.com Received: from col004-omc1s6.hotmail.com (HELO COL004-OMC1S6.hotmail.com) (65.55.34.16) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Oct 2016 17:04:20 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com ([65.55.34.7]) by COL004-OMC1S6.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.23008); Tue, 18 Oct 2016 10:04:18 -0700 Received: from AM5EUR02FT015.eop-EUR02.prod.protection.outlook.com (10.152.8.53) by AM5EUR02HT028.eop-EUR02.prod.protection.outlook.com (10.152.9.253) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.669.7; Tue, 18 Oct 2016 17:04:16 +0000 Received: from AM4PR0701MB2162.eurprd07.prod.outlook.com (10.152.8.55) by AM5EUR02FT015.mail.protection.outlook.com (10.152.8.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.669.7 via Frontend Transport; Tue, 18 Oct 2016 17:04:16 +0000 Received: from AM4PR0701MB2162.eurprd07.prod.outlook.com ([10.167.132.147]) by AM4PR0701MB2162.eurprd07.prod.outlook.com ([10.167.132.147]) with mapi id 15.01.0679.006; Tue, 18 Oct 2016 17:04:16 +0000 From: Bernd Edlinger To: Markus Trippelsdorf CC: Jason Merrill , Florian Weimer , "gcc-patches@gcc.gnu.org" , Jeff Law Subject: Re: [PATCH] Make -Wint-in-bool-context warn on suspicious shift ops Date: Tue, 18 Oct 2016 17:04:15 +0000 Message-ID: References: <87fuol77ri.fsf@mid.deneb.enyo.de> <20161017152304.GA303@x4> <20161017171124.GB303@x4> In-Reply-To: authentication-results: trippelsdorf.de; dkim=none (message not signed) header.d=none; trippelsdorf.de; dmarc=none action=none header.from=hotmail.de; x-ms-exchange-messagesentrepresentingtype: 1 x-eopattributedmessage: 0 x-microsoft-exchange-diagnostics: 1; AM5EUR02HT028; 6:lB9n2lVGm+OgsFdhNe5tpW4cq8vEazBvIoPbWRXB+3+Msg12tO2S7vLktbSp7PQPGN+drqMxksVb2cEuOTBvKjbLQ3gqXEHAc/6GkuATuIG1pAB6VZe9jEsl+v8AbykJHhR6XvJg01teJZ9jfyqJDNnzWRUVp/kw+SFJpO89vzu9WGTyrQpki+r8LgeeZCbzoHHLcYU6kvyMemcPTPdwJ6Zcn+mXN4rn+OEfekhtWe5b9ZANlKALZKYqheiLCyZYAFkKuZRGePb6ZiU1BRzfyXkdKKknY28JCbgk11FlUFgULR6mURnraKEAIFQ4m52C; 5:JCfdmqt7Uypfvwxl6ExweHw98AkOO/XHT0Iof+VyRo0kCfVzZbS24PjIrYlCDHQkcH5UN92gjJYwia8pz/8dF0i79mIbk5Qm7bg2ZQikMLIIFtRNBTHxSamTEwToawj/eB31yiRIrqpOmrgAWtoLQEqu2DtvgT+JnLGNqs/90x0=; 24:vHjMB4/ktvpwXO+Xvn5kFKTk0bkvn3rgKA7Ajs8V9a1CQCi27tuJGO3IAv3i3Mb52Yv1tciZyOffEkDWceHao5oiPpPZnsrYknybqJeTiqE=; 7:M2X8Or/UtTZ34E9OfutWpFOsfAhcO4CWkPQznZ+KHWUup/g+gAa+S5y/vuWHk/zmUf4FuaTr41C29+VyS0xW0NHaiLwRr6G6fbH5bvqtT5UEfnivuSSP7PJh2S7G4buFhOae8udRwjRVfrkr42yFOp3nhEAlzE34zxzCPP473xVy7mW74xiKUYA2gl8lRYghXnOT+ygZtK6gWy8Xu/RIJ98Rfy7C5USgV9RuTUpKrYsMrmkXP/pbIsUm9swsg1lhFncI7GgvRADe7VYnjZcd4GOXz85e6PzcpLAWhyqoRoVmbIaKuqXv0pL0c68pWJkcuBYBTgVncwbbhctLT7nLK4r92GI6FQJeGzauVYNub48= x-forefront-antispam-report: EFV:NLI; SFV:NSPM; SFS:(10019020)(98900003); DIR:OUT; SFP:1102; SCL:1; SRVR:AM5EUR02HT028; H:AM4PR0701MB2162.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; x-ms-office365-filtering-correlation-id: 93755931-0672-4b0e-ef79-08d3f778ca14 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(1601124038)(1603103081)(1601125047); SRVR:AM5EUR02HT028; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(432015012)(102415321)(82015046); SRVR:AM5EUR02HT028; BCL:0; PCL:0; RULEID:; SRVR:AM5EUR02HT028; x-forefront-prvs: 00997889E7 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2016 17:04:15.8496 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5EUR02HT028 Hi, this restricts the -Wint-in-bool-context warning to signed shifts, to reduce the number of false positives Markus reported yesterday. Bootstrap and reg-testing on x86_64-pc-linux-gnu was fine. Is it OK for trunk? Thanks Bernd. 2016-10-17 Bernd Edlinger * c-common.c (c_common_truthvalue_conversion): Warn only for signed integer shift ops in boolean context. Index: gcc/c-family/c-common.c =================================================================== --- gcc/c-family/c-common.c (revision 241270) +++ gcc/c-family/c-common.c (working copy) @@ -3328,8 +3328,10 @@ TREE_OPERAND (expr, 0)); case LSHIFT_EXPR: - warning_at (EXPR_LOCATION (expr), OPT_Wint_in_bool_context, - "<< in boolean context, did you mean '<' ?"); + if (TREE_CODE (TREE_TYPE (expr)) == INTEGER_TYPE + && !TYPE_UNSIGNED (TREE_TYPE (expr))) + warning_at (EXPR_LOCATION (expr), OPT_Wint_in_bool_context, + "<< in boolean context, did you mean '<' ?"); break; case COND_EXPR: