From patchwork Mon Jan 23 08:51:29 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ramana Radhakrishnan X-Patchwork-Id: 6342 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 13A2323E0C for ; Mon, 23 Jan 2012 08:51:34 +0000 (UTC) Received: from mail-bk0-f52.google.com (mail-bk0-f52.google.com [209.85.214.52]) by fiordland.canonical.com (Postfix) with ESMTP id 01632A1875D for ; Mon, 23 Jan 2012 08:51:33 +0000 (UTC) Received: by bkar19 with SMTP id r19so2478265bka.11 for ; Mon, 23 Jan 2012 00:51:33 -0800 (PST) Received: by 10.205.120.17 with SMTP id fw17mr2742160bkc.74.1327308693677; Mon, 23 Jan 2012 00:51:33 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.204.130.220 with SMTP id u28cs66486bks; Mon, 23 Jan 2012 00:51:32 -0800 (PST) Received: by 10.182.47.10 with SMTP id z10mr7138433obm.19.1327308690643; Mon, 23 Jan 2012 00:51:30 -0800 (PST) Received: from mail-tul01m020-f178.google.com (mail-tul01m020-f178.google.com [209.85.214.178]) by mx.google.com with ESMTPS id 7si2967384obv.146.2012.01.23.00.51.30 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 23 Jan 2012 00:51:30 -0800 (PST) Received-SPF: neutral (google.com: 209.85.214.178 is neither permitted nor denied by best guess record for domain of ramana.radhakrishnan@linaro.org) client-ip=209.85.214.178; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.214.178 is neither permitted nor denied by best guess record for domain of ramana.radhakrishnan@linaro.org) smtp.mail=ramana.radhakrishnan@linaro.org Received: by obbwc7 with SMTP id wc7so3792835obb.37 for ; Mon, 23 Jan 2012 00:51:30 -0800 (PST) MIME-Version: 1.0 Received: by 10.182.159.105 with SMTP id xb9mr1781462obb.63.1327308689940; Mon, 23 Jan 2012 00:51:29 -0800 (PST) Received: by 10.182.88.7 with HTTP; Mon, 23 Jan 2012 00:51:29 -0800 (PST) In-Reply-To: <201201221153.32801.ebotcazou@adacore.com> References: <201201211816.15317.ebotcazou@adacore.com> <201201221153.32801.ebotcazou@adacore.com> Date: Mon, 23 Jan 2012 08:51:29 +0000 Message-ID: Subject: Re: [RFC combine] PR48308 - Fix issue with missing(?) LOG_LINKS From: Ramana Radhakrishnan To: Eric Botcazou Cc: gcc-patches@gcc.gnu.org, Patch Tracking X-Gm-Message-State: ALoCoQlyRAgL2zIFcAH00Rp9wysma6xSUMqo3VY3wNAwmA6xfcM12+tm0WUamQnoup6tgx8Sf+00 On 22 January 2012 10:53, Eric Botcazou wrote: >> The un-combining thing around line 2800 is somewhat of a kludge and I >> wouldn't be surprised if there were other fallouts.  But your change is >> clearly correct and looks relatively safe, so OK for trunk and 4.6 branch >> after full testing. > > I overlooked something though: it might be possible for combine_instructions to > try to combine i2 again if the previous combination fails (if it succeeds, i1 > is deleted so this is OK) so the stall LOG_LINKS could be problematic.  That's > why LOG_LINKS (i2) needs to SUBST-ituted like the two lines just above Do you mean something like this instead ? I'm testing this - Ok if no regressions ? Ramana . > > -- > Eric Botcazou === modified file 'gcc/combine.c' --- gcc/combine.c 2012-01-11 22:59:12 +0000 +++ gcc/combine.c 2012-01-23 08:50:14 +0000 @@ -2865,6 +2865,7 @@ SUBST (PATTERN (i2), XVECEXP (PATTERN (i2), 0, 0)); SUBST (XEXP (SET_SRC (PATTERN (i2)), 0), SET_DEST (PATTERN (i1))); + SUBST (LOG_LINKS (i2), alloc_insn_link (i1, LOG_LINKS (i2))); } } #endif