From patchwork Wed Aug 27 11:10:25 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yvan Roux X-Patchwork-Id: 36082 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-yk0-f200.google.com (mail-yk0-f200.google.com [209.85.160.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 49A272054F for ; Wed, 27 Aug 2014 11:11:39 +0000 (UTC) Received: by mail-yk0-f200.google.com with SMTP id 9sf149230ykp.3 for ; Wed, 27 Aug 2014 04:11:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mailing-list:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:sender :delivered-to:mime-version:in-reply-to:references:date:message-id :subject:from:to:cc:x-original-sender :x-original-authentication-results:content-type; bh=79vKmvUvuisIm25jb5mMsnV2811aa1bQkriPAOBHEcc=; b=EIOcewBFkr4O+/b6aUsSqyOOVdkVT+outzt/rpX+NwuIwyIb4VUbl2tPlNqYr3BkUm STNyIL0m0f0nn+FpikIbqTuXL85vNwTOrCJJPIVFLq93u2++6Uusqo9pxcXCXTuHtaSs fiiVbyoJxA+Ko5fL0uza2Iw5y/MV7+fz2F9AYghnqf3laRn4eSR0mGmE6F4gc/Jat8l0 gZ8U1TVil+HQ/HNACNR+Bea/JVxUwIfu6qBTCvSuJq66+VZVAe+0G6/5VtdbVd+NwBFX zq21pIcQ0htw8e64DRd0TVdpA+9wSCMNyaSoB9MtH4YutwSKgoFCFflodjPvRDOQzZaF H5hg== X-Gm-Message-State: ALoCoQnUVBKApBCUfZLYuOUXC3nE8rKeDpKBOnfQTI9/lfSEf6vyujYLkb7kvojTPhVBBcszED9e X-Received: by 10.236.101.148 with SMTP id b20mr8670980yhg.46.1409137899107; Wed, 27 Aug 2014 04:11:39 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.42.87 with SMTP id b81ls80343qga.19.gmail; Wed, 27 Aug 2014 04:11:39 -0700 (PDT) X-Received: by 10.236.112.3 with SMTP id x3mr50691887yhg.17.1409137898981; Wed, 27 Aug 2014 04:11:38 -0700 (PDT) Received: from mail-yh0-x22f.google.com (mail-yh0-x22f.google.com [2607:f8b0:4002:c01::22f]) by mx.google.com with ESMTPS id w20si4872103yhn.89.2014.08.27.04.11.38 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 27 Aug 2014 04:11:38 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2607:f8b0:4002:c01::22f as permitted sender) client-ip=2607:f8b0:4002:c01::22f; Received: by mail-yh0-f47.google.com with SMTP id f10so44106yha.34 for ; Wed, 27 Aug 2014 04:11:38 -0700 (PDT) X-Received: by 10.221.49.133 with SMTP id va5mr615715vcb.37.1409137898840; Wed, 27 Aug 2014 04:11:38 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.45.67 with SMTP id uj3csp64221vcb; Wed, 27 Aug 2014 04:11:38 -0700 (PDT) X-Received: by 10.68.236.227 with SMTP id ux3mr21169580pbc.159.1409137897692; Wed, 27 Aug 2014 04:11:37 -0700 (PDT) Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id py3si8548526pbc.198.2014.08.27.04.11.37 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Aug 2014 04:11:37 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-return-376260-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Received: (qmail 12082 invoked by alias); 27 Aug 2014 11:10:33 -0000 Mailing-List: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 12048 invoked by uid 89); 27 Aug 2014 11:10:28 -0000 X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oa0-f54.google.com Received: from mail-oa0-f54.google.com (HELO mail-oa0-f54.google.com) (209.85.219.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 27 Aug 2014 11:10:27 +0000 Received: by mail-oa0-f54.google.com with SMTP id n16so29113oag.27 for ; Wed, 27 Aug 2014 04:10:25 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.182.103.165 with SMTP id fx5mr19341236obb.61.1409137825345; Wed, 27 Aug 2014 04:10:25 -0700 (PDT) Received: by 10.202.229.18 with HTTP; Wed, 27 Aug 2014 04:10:25 -0700 (PDT) In-Reply-To: References: <53FDA3EB.2060703@arm.com> Date: Wed, 27 Aug 2014 13:10:25 +0200 Message-ID: Subject: Re: [PATCH, ARM] PR62248 - Configure error with --with-fpu=fp-armv8 From: Yvan Roux To: Richard Earnshaw Cc: "gcc-patches@gcc.gnu.org" X-IsSubscribed: yes X-Original-Sender: yvan.roux@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2607:f8b0:4002:c01::22f as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=pass header.i=@gcc.gnu.org X-Google-Group-Id: 836684582541 Here is the patch that uses the arm-fpus.def list. Thanks Yvan 2014-08-27 Yvan Roux * config.gcc (arm*-*-*): Check --with-fpu against arm-fpus.def. On 27 August 2014 12:35, Yvan Roux wrote: > On 27 August 2014 11:24, Richard Earnshaw wrote: >> On 27/08/14 09:04, Yvan Roux wrote: >>> Hi, >>> >>> as reported in PR62248 there is a typo in gcc/config.gcc where >>> --with-fpu doesn't match -mfpu option for fp-armv8 value (fp-arm-v8 in >>> config.gcc). Here is the patch to fix it. >>> >>> Thanks, >>> Yvan >>> >>> 2014-08-27 Yvan Roux >>> >>> * config.gcc: Fix fp-armv8 option for arm*-*-* targets. >>> >>> >>> pr62248.diff >>> >>> >>> diff --git a/gcc/config.gcc b/gcc/config.gcc >>> index 6862c127..3f68e3e 100644 >>> --- a/gcc/config.gcc >>> +++ b/gcc/config.gcc >>> @@ -3528,7 +3528,7 @@ case "${target}" in >>> | vfp | vfp3 | vfpv3 \ >>> | vfpv3-fp16 | vfpv3-d16 | vfpv3-d16-fp16 | vfpv3xd \ >>> | vfpv3xd-fp16 | neon | neon-fp16 | vfpv4 | vfpv4-d16 \ >>> - | fpv4-sp-d16 | neon-vfpv4 | fp-arm-v8 | neon-fp-armv8 \ >>> + | fpv4-sp-d16 | neon-vfpv4 | fp-armv8 | neon-fp-armv8 \ >>> | crypto-neon-fp-armv8) >>> # OK >>> ;; >>> >> >> Ok; but better still would be to change this to use the official list in >> arm-fpus.def (like we do for CPU names). > > Yes indeed, I'll do it that way. diff --git a/gcc/config.gcc b/gcc/config.gcc index 6862c127..7434a08 100644 --- a/gcc/config.gcc +++ b/gcc/config.gcc @@ -3523,20 +3523,17 @@ case "${target}" in ;; esac - case "$with_fpu" in - "" \ - | vfp | vfp3 | vfpv3 \ - | vfpv3-fp16 | vfpv3-d16 | vfpv3-d16-fp16 | vfpv3xd \ - | vfpv3xd-fp16 | neon | neon-fp16 | vfpv4 | vfpv4-d16 \ - | fpv4-sp-d16 | neon-vfpv4 | fp-arm-v8 | neon-fp-armv8 \ - | crypto-neon-fp-armv8) - # OK - ;; - *) - echo "Unknown fpu used in --with-fpu=$with_fpu" 2>&1 - exit 1 - ;; - esac + # see if it matches any of the entries in arm-fpus.def + if [ x"$with_fpu" = x ] \ + || grep "^ARM_FPU(\"$with_fpu\"," \ + ${srcdir}/config/arm/arm-fpus.def \ + > /dev/null; then + # OK + true + else + echo "Unknown fpu used in --with-fpu=$with_fpu" 1>&2 + exit 1 + fi case "$with_abi" in "" \