From patchwork Mon Dec 5 18:33:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Lyon X-Patchwork-Id: 86613 Delivered-To: patch@linaro.org Received: by 10.140.20.101 with SMTP id 92csp1631809qgi; Mon, 5 Dec 2016 10:34:08 -0800 (PST) X-Received: by 10.84.138.3 with SMTP id 3mr8830331plo.108.1480962848359; Mon, 05 Dec 2016 10:34:08 -0800 (PST) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id j62si15520007pgc.184.2016.12.05.10.34.08 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Dec 2016 10:34:08 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-return-443515-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org; spf=pass (google.com: domain of gcc-patches-return-443515-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-443515-patch=linaro.org@gcc.gnu.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; q=dns; s=default; b=hy6Km0aMWMk3KXN JvZuHapBW5u5vMQoKth96p+D/nE7/hXcNmhn7o+NOZquTu8X2WXs4tCY2YGYhfuA qVcKtSWaANJuaoIlzE4xBGHTQmCtyzD1XgUVNgjI0b+FVx5GTFr/v/s2aJYm7bMS LIaXd5daFNrccFg2fa1C9sJf6GOI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; s=default; bh=1OMbMDtXLRM5ET96ZCTcV kDtAx8=; b=m0H+oz3Dn19vcGY5/zWVjePgQ2Y9kZNtWzqgSVWvlGhRnsfQTC9Ml NHYdJk2uRXzjn3eYla7p473fdmtP+nr9LMfCwsS3+Tzjy41pcAI6zAdSJf0XwYci lfDQ+ktxxgWZoEFiFwYDpDI8gXkov566Wx7WF3XCCTHDDNso4H+4fI= Received: (qmail 11408 invoked by alias); 5 Dec 2016 18:33:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 11393 invoked by uid 89); 5 Dec 2016 18:33:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=no version=3.3.2 spammy=sk:kyrylo, sk:MSGTW, VECT_TYPE, sk:beaf6ac X-HELO: mail-qt0-f177.google.com Received: from mail-qt0-f177.google.com (HELO mail-qt0-f177.google.com) (209.85.216.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 05 Dec 2016 18:33:46 +0000 Received: by mail-qt0-f177.google.com with SMTP id w33so322463759qtc.3 for ; Mon, 05 Dec 2016 10:33:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Fl/+DZX6qtzK/KtoQ9u0DFYJTLUCcC5z87rq6BxBtc8=; b=jEoedqhO7D5wWcAU4kw1uU11lmn5/nMSUOTkoTilDqUSGaNPmUYMGM5PEEZGC2pORB 5Xm934rIEUosNg84X17ZZx9/qxkSewnvRA8DXYBGxKxq9AU7lpuIQK9yERgx1gxgRNtu YG6W2m9v7zZBZUghWCA/08GUAfpQVgiJzfM5qr3zC+f4wb62ulpLztEnR6bwRThBGgJ0 UtWdowE0Q2fq8ZzqvEtqLL1vvsBHmTS37gGdtUqM1/bqwP2oi7F0WjvN/VwbXvgAjyIT 9Ohn6+/+LjtAEFyUptpTfs1soYLOFAhJK5ZSqFbnGHNZ8CsMXviEYS9uKeq7RedT9c1x Ffpw== X-Gm-Message-State: AKaTC02/+WGnBcX7AouvrZtcsw0p/jQmc/7SSln2I85grqQezRsgoRsbpPWoS9zaRxPT8hRbQJgW1pLFxYhG4W0W X-Received: by 10.200.51.87 with SMTP id u23mr50198083qta.139.1480962824308; Mon, 05 Dec 2016 10:33:44 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.101.144 with HTTP; Mon, 5 Dec 2016 10:33:43 -0800 (PST) In-Reply-To: <5845888A.7000007@foss.arm.com> References: <5845888A.7000007@foss.arm.com> From: Christophe Lyon Date: Mon, 5 Dec 2016 19:33:43 +0100 Message-ID: Subject: Re: [ARM][PATCH] Fix failing poly64 tests on ARM To: Kyrill Tkachov Cc: Tamar Christina , GCC Patches , "nickc@redhat.com" , Richard Earnshaw X-IsSubscribed: yes Hi Tamar, On 5 December 2016 at 16:32, Kyrill Tkachov wrote: > > On 05/12/16 10:39, Tamar Christina wrote: >> >> Hi All, >> >> This patch fixes test failures on arm-none-eabi. >> Poly64 was being used by files that were not supposed >> to be testing poly64 types. >> >> I have added a new MACRO that must be defined in addition >> to having CRYPTO available before use of Poly64 types are >> allowed in the header arm-neon-ref.h. >> >> Ok for trunk? >> >> gcc/testsuite/ >> 2016-12-01 Tamar Christina >> >> * gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h: Gate use >> of Poly64 on USE_CRYPTO_TYPES. >> * gcc.target/aarch64/advsimd-intrinsics/p64_p128.c: Define >> USE_CRYPTO_TYPES. >> * gcc.target/aarch64/advsimd-intrinsics/vreinterpret_p128.c: >> Likewise. >> * gcc.target/aarch64/advsimd-intrinsics/vreinterpret_p64.c: >> Likewise. > > > Ok, but please make sure the line length in the ChangeLog doesn't go over 80 > characters. > Kyrill Since 'expected_poly64x[12]' isn't used, there is no need to declare it, and the attached patch seems to work (tested only on arm-none-linux-gnueabihf --target-board=-mthumb/-march=armv8-a/-mfpu=crypto-neon-fp-armv8/-mfloat-abi=hard All the tests for poly64 use dedicated output buffers, at least for the moment. Does my patch break aarch64? Christophe diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h index beaf6ac..4728639 100644 --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h @@ -99,13 +99,6 @@ extern size_t strlen(const char *); fprintf(stderr, "CHECKED %s %s\n", STR(VECT_TYPE(T, W, N)), MSG); \ } -#if defined (__ARM_FEATURE_CRYPTO) -#define CHECK_CRYPTO(MSG,T,W,N,FMT,EXPECTED,COMMENT) \ - CHECK(MSG,T,W,N,FMT,EXPECTED,COMMENT) -#else -#define CHECK_CRYPTO(MSG,T,W,N,FMT,EXPECTED,COMMENT) -#endif - /* Floating-point variant. */ #define CHECK_FP(MSG,T,W,N,FMT,EXPECTED,COMMENT) \ { \ @@ -198,9 +191,6 @@ extern ARRAY(expected, uint, 32, 2); extern ARRAY(expected, uint, 64, 1); extern ARRAY(expected, poly, 8, 8); extern ARRAY(expected, poly, 16, 4); -#if defined (__ARM_FEATURE_CRYPTO) -extern ARRAY(expected, poly, 64, 1); -#endif extern ARRAY(expected, hfloat, 16, 4); extern ARRAY(expected, hfloat, 32, 2); extern ARRAY(expected, hfloat, 64, 1); @@ -214,9 +204,6 @@ extern ARRAY(expected, uint, 32, 4); extern ARRAY(expected, uint, 64, 2); extern ARRAY(expected, poly, 8, 16); extern ARRAY(expected, poly, 16, 8); -#if defined (__ARM_FEATURE_CRYPTO) -extern ARRAY(expected, poly, 64, 2); -#endif extern ARRAY(expected, hfloat, 16, 8); extern ARRAY(expected, hfloat, 32, 4); extern ARRAY(expected, hfloat, 64, 2); @@ -233,7 +220,6 @@ extern ARRAY(expected, hfloat, 64, 2); CHECK(test_name, uint, 64, 1, PRIx64, EXPECTED, comment); \ CHECK(test_name, poly, 8, 8, PRIx8, EXPECTED, comment); \ CHECK(test_name, poly, 16, 4, PRIx16, EXPECTED, comment); \ - CHECK_CRYPTO(test_name, poly, 64, 1, PRIx64, EXPECTED, comment); \ CHECK_FP(test_name, float, 32, 2, PRIx32, EXPECTED, comment); \ \ CHECK(test_name, int, 8, 16, PRIx8, EXPECTED, comment); \ @@ -246,7 +232,6 @@ extern ARRAY(expected, hfloat, 64, 2); CHECK(test_name, uint, 64, 2, PRIx64, EXPECTED, comment); \ CHECK(test_name, poly, 8, 16, PRIx8, EXPECTED, comment); \ CHECK(test_name, poly, 16, 8, PRIx16, EXPECTED, comment); \ - CHECK_CRYPTO(test_name, poly, 64, 2, PRIx64, EXPECTED, comment); \ CHECK_FP(test_name, float, 32, 4, PRIx32, EXPECTED, comment); \ } \