From patchwork Fri Jan 6 12:48:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 90159 Delivered-To: patch@linaro.org Received: by 10.140.20.101 with SMTP id 92csp9431852qgi; Fri, 6 Jan 2017 04:49:45 -0800 (PST) X-Received: by 10.84.192.131 with SMTP id c3mr169169090pld.149.1483706985640; Fri, 06 Jan 2017 04:49:45 -0800 (PST) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id m188si79402457pfc.211.2017.01.06.04.49.45 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Jan 2017 04:49:45 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-return-445536-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org; spf=pass (google.com: domain of gcc-patches-return-445536-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-445536-patch=linaro.org@gcc.gnu.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-type; q=dns; s=default; b=mddfIDuBno+I34/y vaABlhMDZ6LjfAYRsxajv9xGHqYUdtSnukM24k4C0vX8pGCb39uJb0ixeRY9Z+Id onTfxVU2KU2kCYlYXNFiYmLOYMwZjeVKxB4fE3JkJGWIeZJHkF/T+AdvqFjeVN1C v/O/4DF8uhInAB71BXUnoDn1/xU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-type; s=default; bh=Qp9VfmhIVszj/YS/pMnaNv C+Z8I=; b=ZIXX22V6dp8EBEc88+zqmTi4WPyc2hTcjHjpJ3zamxikFNjpMIX1wu Ylrf8u3QoLfGrroPY6NQbvL41f8vWNWigPatqxjimKxy1juWctyfzHjeRd1atvRU zv/TQPkfayB4u1IDFeps8K4MycS1ZYhNTHP+da80ShgVXpU5baY34= Received: (qmail 100360 invoked by alias); 6 Jan 2017 12:49:10 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 99918 invoked by uid 89); 6 Jan 2017 12:49:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL, BAYES_00, KAM_ASCII_DIVIDERS, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=H*i:sk:1483647, vol, H*f:sk:1483647 X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Jan 2017 12:48:56 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 4F9E834F; Fri, 6 Jan 2017 13:48:53 +0100 (CET) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id onFlIyiYDvDS; Fri, 6 Jan 2017 13:48:51 +0100 (CET) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 5668634E; Fri, 6 Jan 2017 13:48:51 +0100 (CET) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id v06CmoST014002; Fri, 6 Jan 2017 13:48:50 +0100 (MET) From: Rainer Orth To: David Malcolm Cc: Uros Bizjak , "gcc-patches\@gcc.gnu.org" , Jan Hubicka , Bernd Schmidt Subject: Re: [committed] Introduce RTL function reader References: <1483647626-35623-1-git-send-email-dmalcolm@redhat.com> Date: Fri, 06 Jan 2017 13:48:50 +0100 In-Reply-To: <1483647626-35623-1-git-send-email-dmalcolm@redhat.com> (David Malcolm's message of "Thu, 5 Jan 2017 15:20:26 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes Hi David, > The various parts of patch 8 appear to now have been approved, so > I've committed it (along with "Add ASSERT_RTX_PTR_EQ", which it > requires and is required by) to trunk as r244110, having rebased, > and bootstrapped & regrtested on x86_64-pc-linux-gnu, and tested > stage 1's selftests for aarch64-linux-gnu. this patch thoroughly broke bootstrap on every 32-bit target, it seems: In file included from /vol/gcc/src/hg/trunk/local/gcc/read-rtl.c:31:0: /vol/gcc/src/hg/trunk/local/gcc/read-rtl.c: In member function 'rtx_def* rtx_reader::read_rtx_code(const char*)': /vol/gcc/src/hg/trunk/local/gcc/read-rtl.c:1260:23: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] gcc_assert (idx < m_reuse_rtx_by_id.length ()); ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /vol/gcc/src/hg/trunk/local/gcc/system.h:731:14: note: in definition of macro 'gcc_assert' ((void)(!(EXPR) ? fancy_abort (__FILE__, __LINE__, __FUNCTION__), 0 : 0)) ^~~~ Seen on i386-pc-solaris2.*, sparc-sun-solaris2.*, and i686-pc-linux-gnu. The following fix works for me, at least an i686-pc-linux-gnu bootstrap is now into building target libraries. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University 2017-01-06 Rainer Orth * read-rtl.c (rtx_reader::read_rtx_code): Cast idx to unsigned. diff --git a/gcc/read-rtl.c b/gcc/read-rtl.c --- a/gcc/read-rtl.c +++ b/gcc/read-rtl.c @@ -1257,7 +1257,7 @@ rtx_reader::read_rtx_code (const char *c read_name (&name); long idx = atoi (name.string); /* Look it up by ID. */ - gcc_assert (idx < m_reuse_rtx_by_id.length ()); + gcc_assert ((unsigned) idx < m_reuse_rtx_by_id.length ()); return_rtx = m_reuse_rtx_by_id[idx]; return return_rtx; }