From patchwork Wed Feb 15 23:34:09 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael-Doyle Hudson X-Patchwork-Id: 6809 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 17AA923DC3 for ; Wed, 15 Feb 2012 23:34:14 +0000 (UTC) Received: from mail-iy0-f180.google.com (mail-iy0-f180.google.com [209.85.210.180]) by fiordland.canonical.com (Postfix) with ESMTP id C5365A18A4A for ; Wed, 15 Feb 2012 23:34:13 +0000 (UTC) Received: by iabz7 with SMTP id z7so2916307iab.11 for ; Wed, 15 Feb 2012 15:34:13 -0800 (PST) Received: by 10.50.188.234 with SMTP id gd10mr14890732igc.29.1329348853152; Wed, 15 Feb 2012 15:34:13 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.231.80.19 with SMTP id r19cs203ibk; Wed, 15 Feb 2012 15:34:12 -0800 (PST) Received: by 10.216.132.32 with SMTP id n32mr86698wei.12.1329348851226; Wed, 15 Feb 2012 15:34:11 -0800 (PST) Received: from indium.canonical.com (indium.canonical.com. [91.189.90.7]) by mx.google.com with ESMTPS id gg5si50879wib.41.2012.02.15.15.34.10 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 15 Feb 2012 15:34:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of bounces@canonical.com designates 91.189.90.7 as permitted sender) client-ip=91.189.90.7; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of bounces@canonical.com designates 91.189.90.7 as permitted sender) smtp.mail=bounces@canonical.com Received: from ackee.canonical.com ([91.189.89.26]) by indium.canonical.com with esmtp (Exim 4.71 #1 (Debian)) id 1RxoMT-0006S3-V5 for ; Wed, 15 Feb 2012 23:34:09 +0000 Received: from ackee.canonical.com (localhost [127.0.0.1]) by ackee.canonical.com (Postfix) with ESMTP id E00C3E0180 for ; Wed, 15 Feb 2012 23:34:09 +0000 (UTC) MIME-Version: 1.0 X-Launchpad-Project: lava-server X-Launchpad-Branch: ~linaro-validation/lava-server/trunk X-Launchpad-Message-Rationale: Subscriber X-Launchpad-Branch-Revision-Number: 347 X-Launchpad-Notification-Type: branch-revision To: Linaro Patch Tracker From: noreply@launchpad.net Subject: [Branch ~linaro-validation/lava-server/trunk] Rev 347: "if queryset:" triggers evaluation of the queryset, so do not do that... Message-Id: <20120215233409.21326.62720.launchpad@ackee.canonical.com> Date: Wed, 15 Feb 2012 23:34:09 -0000 Reply-To: noreply@launchpad.net Sender: bounces@canonical.com Errors-To: bounces@canonical.com Precedence: bulk X-Generated-By: Launchpad (canonical.com); Revision="14781"; Instance="launchpad-lazr.conf" X-Launchpad-Hash: d5ec175ef38da0147252c7712437c7414a1ef3c4 X-Gm-Message-State: ALoCoQmlulbqUzhBEWjXGyxXgcBIjTJ4NIqTx0t0zTKgErxPYN3/A+H2EQmxKryx32kwMgu8gzYZ ------------------------------------------------------------ revno: 347 committer: Michael Hudson-Doyle branch nick: trunk timestamp: Thu 2012-02-16 12:32:25 +1300 message: "if queryset:" triggers evaluation of the queryset, so do not do that... modified: lava/utils/data_tables/backends.py --- lp:lava-server https://code.launchpad.net/~linaro-validation/lava-server/trunk You are subscribed to branch lp:lava-server. To unsubscribe from this branch go to https://code.launchpad.net/~linaro-validation/lava-server/trunk/+edit-subscription === modified file 'lava/utils/data_tables/backends.py' --- lava/utils/data_tables/backends.py 2012-02-10 19:47:56 +0000 +++ lava/utils/data_tables/backends.py 2012-02-15 23:32:25 +0000 @@ -98,7 +98,7 @@ self.queryset_cb = queryset_cb self.columns = columns self.searching_columns = searching_columns - if not queryset and not queryset_cb: + if queryset is None and queryset_cb is None: raise ImproperlyConfigured( "QuerySetBackend requires either queryset or queryset_cb") if not columns: