From patchwork Mon Sep 19 19:59:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella X-Patchwork-Id: 607323 Delivered-To: patch@linaro.org Received: by 2002:ab3:1c02:0:b0:1e7:4ce8:c350 with SMTP id u2csp1666834lth; Mon, 19 Sep 2022 13:00:25 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6r6TrfqkKteZiA7qrHFJ0X/XU0jEPPvb1cYhYw4NxZHZzYWMWDYUmWUvRzC+mQo2Isti/V X-Received: by 2002:a17:906:fe46:b0:73d:939a:ec99 with SMTP id wz6-20020a170906fe4600b0073d939aec99mr14132813ejb.169.1663617625261; Mon, 19 Sep 2022 13:00:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663617625; cv=none; d=google.com; s=arc-20160816; b=s4J8i0SkfiDpiq/ukqO5gRe6tDTRxSVcKHeHRiTdfmc8sCUzom0hTNySWGsuERU7fv Svo3EsPJMY9YEONoOHugwyR2O2qzMzXsokd6XWUObu6aVtJvtORsmUIl0B0l31ZbdsgA J2Ox1z5c2WSCY4Qu3nffQpjwpiDrjkcsjvjoO7CsRYPv7QO/3X3QzxmnoXkh+j/3xTzb Yws7M4WAYqA2rO4Gy9l7Q7NPYh2/CUlvXy61QikvbpxN59AYxAGFu8RBhFh/kNeBSa3y TKkvKwprx3gtPCSw56L+JebQrx6sZrfhreAz2etkLsa0kh6WsWKz4tumqAGJYQyKxGuL n6yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:from:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=uyhyLz38LFlPYNj6QCjH8NWe1tXKsAkhUH/RV/4H9fs=; b=LCCdQeHPbZG5w7EfM2crUxnT5Ca229zCFMRgFqqw7SB4aBLZbPznnrLiEHIyjLZKb+ IGFQJ3QP4c+JDG45cIxcb97iUQ5lgkP3jDcHDdI7iOLMrEuF63gkR8o31lWCkZPXvrDJ lPi2yvFES9FnfDY5Kc3KJc4obeAy+/3/tF7usj7ar2akxBH3X7DD2PxzF/3WzeCHDQ9x ue3guvVx510MonwcIpf1WCkBjIy0n6N9tWzDl9cGiHk3IYSmURVLZ82vofKNVT6Kjs8+ GS+Qwm6vDTnuPXghfdKX+wDWmKlDwAySTd9/sRmysRpUns3WHu2a1KYBT30I/Tf/K+Ol UghA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=dh8uhXm4; spf=pass (google.com: domain of libc-alpha-bounces+patch=linaro.org@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="libc-alpha-bounces+patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Return-Path: Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id hg3-20020a1709072cc300b0077d589c4055si15877731ejc.735.2022.09.19.13.00.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 13:00:25 -0700 (PDT) Received-SPF: pass (google.com: domain of libc-alpha-bounces+patch=linaro.org@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=dh8uhXm4; spf=pass (google.com: domain of libc-alpha-bounces+patch=linaro.org@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="libc-alpha-bounces+patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3D936385B83C for ; Mon, 19 Sep 2022 20:00:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3D936385B83C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1663617624; bh=uyhyLz38LFlPYNj6QCjH8NWe1tXKsAkhUH/RV/4H9fs=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=dh8uhXm4V10ctnI33oIqVyaFE2XQGShaGkAUvfXeIbXNVbSfoOH+C+DBCxzWfvP2/ Cx1+BHf8SV8aMM3qBz1QQyLYQKrgFgwK3TBnIbhbmpA7nNFliW3czg8agMbtqi5TPO LtrxoJfSEaGr4HY8uW76YyaqHmbSHYkGH5WZlySU= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-oa1-x30.google.com (mail-oa1-x30.google.com [IPv6:2001:4860:4864:20::30]) by sourceware.org (Postfix) with ESMTPS id 983D33858D32 for ; Mon, 19 Sep 2022 19:59:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 983D33858D32 Received: by mail-oa1-x30.google.com with SMTP id 586e51a60fabf-1274ec87ad5so1092732fac.0 for ; Mon, 19 Sep 2022 12:59:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=uyhyLz38LFlPYNj6QCjH8NWe1tXKsAkhUH/RV/4H9fs=; b=M5nTOKeov0D4M6GBnfDajO8c9Hm41OWTrUqAmM00Q+EHWuqSAnA9Ogtlp29cGHtKZN SCSxBqz8GRGO0KjiNG4pcLJxMbJ2GuMiffB6JtbszdM8ZUhpF9zSZz+3GYd9+TNTspp4 MidQr0nhLAmfotAPrv6kAJ2G9FGiB7vNAXOesT3jUdA+Pbx3bb/ehnDKF+mDvdp0fCtr sZoaWR58PigiNPAYMH34RzxunMYndD6Vz6ADu8PEXWTQMh6ycjlv2mYo7mVowPRdSOAF 1nvzrqtFSJoqWHOHNWB3xU/HJr6xg/eqP7xmgCpcD+cIR//mcgpScYnjOxuEnXFmfGhI iDQw== X-Gm-Message-State: ACgBeo16cBGn24deONr7Wc2Pqu1AX+pQa8Hmt5+FGyAXiFNLfK0iGRmi jNcu4FXIJGhHjEKgp1a1NIin01qwUad3Gwa9 X-Received: by 2002:a05:6870:d625:b0:127:db0a:c4ac with SMTP id a37-20020a056870d62500b00127db0ac4acmr16288094oaq.75.1663617567780; Mon, 19 Sep 2022 12:59:27 -0700 (PDT) Received: from mandiga.. ([2804:1b3:a7c1:c266:b3ad:a56d:1ca:d6ea]) by smtp.gmail.com with ESMTPSA id l7-20020a4ab0c7000000b00475dc6c6f31sm4532291oon.45.2022.09.19.12.59.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 12:59:27 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH v5 01/17] Parameterize op_t from memcopy.h Date: Mon, 19 Sep 2022 16:59:04 -0300 Message-Id: <20220919195920.956393-2-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220919195920.956393-1-adhemerval.zanella@linaro.org> References: <20220919195920.956393-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Reply-To: Adhemerval Zanella Cc: Richard Henderson Errors-To: libc-alpha-bounces+patch=linaro.org@sourceware.org Sender: "Libc-alpha" From: Richard Henderson It moves the op_t definition out to an specific header, adds the attribute 'may-alias', and cleanup its duplicated definitions. Checked with a build and check with run-built-tests=no for all major Linux ABIs. Co-authored-by: Adhemerval Zanella --- string/memcmp.c | 1 - sysdeps/generic/memcopy.h | 6 ++---- sysdeps/generic/string-optype.h | 31 +++++++++++++++++++++++++++++++ 3 files changed, 33 insertions(+), 5 deletions(-) create mode 100644 sysdeps/generic/string-optype.h diff --git a/string/memcmp.c b/string/memcmp.c index 40029474e6..6a9ceb8ac3 100644 --- a/string/memcmp.c +++ b/string/memcmp.c @@ -46,7 +46,6 @@ /* Type to use for aligned memory operations. This should normally be the biggest type supported by a single load and store. Must be an unsigned type. */ -# define op_t unsigned long int # define OPSIZ (sizeof (op_t)) /* Threshold value for when to enter the unrolled loops. */ diff --git a/sysdeps/generic/memcopy.h b/sysdeps/generic/memcopy.h index 251632e8ae..efe5f2475d 100644 --- a/sysdeps/generic/memcopy.h +++ b/sysdeps/generic/memcopy.h @@ -55,10 +55,8 @@ [I fail to understand. I feel stupid. --roland] */ -/* Type to use for aligned memory operations. - This should normally be the biggest type supported by a single load - and store. */ -#define op_t unsigned long int +/* Type to use for aligned memory operations. */ +#include #define OPSIZ (sizeof (op_t)) /* Type to use for unaligned operations. */ diff --git a/sysdeps/generic/string-optype.h b/sysdeps/generic/string-optype.h new file mode 100644 index 0000000000..fb6d67a19e --- /dev/null +++ b/sysdeps/generic/string-optype.h @@ -0,0 +1,31 @@ +/* Define a type to use for word access. Generic version. + Copyright (C) 2022 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#ifndef _STRING_OPTYPE_H +#define _STRING_OPTYPE_H 1 + +/* Use the existing parameterization from gmp as a default. */ +#include + +#ifdef _LONG_LONG_LIMB +typedef unsigned long long int __attribute__ ((__may_alias__)) op_t; +#else +typedef unsigned long int __attribute__ ((__may_alias__)) op_t; +#endif + +#endif /* string-optype.h */