From patchwork Thu Apr 14 19:38:31 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 65844 Delivered-To: patch@linaro.org Received: by 10.140.93.198 with SMTP id d64csp788836qge; Thu, 14 Apr 2016 12:39:01 -0700 (PDT) X-Received: by 10.98.80.206 with SMTP id g75mr23684145pfj.127.1460662741301; Thu, 14 Apr 2016 12:39:01 -0700 (PDT) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id s20si8838605pfa.216.2016.04.14.12.39.01 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Apr 2016 12:39:01 -0700 (PDT) Received-SPF: pass (google.com: domain of libc-alpha-return-68877-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org; spf=pass (google.com: domain of libc-alpha-return-68877-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=libc-alpha-return-68877-patch=linaro.org@sourceware.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:cc:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=rzBaC89UZNacsUke X5c1bauemFuhxvWylAcq9MaC+gXdr5MHaMOBKF5L8bevRQEIK56fWWrBTlbKDNTU 7od/lpzP4ifwwYS0y3K1rCZMbplGQNMfO21t74qPMgPYw6ktj6eInPZMK0GzWFyo NO6r5+ke3cplKZ5QGdKjv93yfKo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:cc:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=bQmL/4bg8F5ssYmUm1f30M VV3E0=; b=uHOxNzdGA2oH0F2rZ5KSlUsu66CZSj5DyVaJP4Z9Kp3i4BOWxoYIK3 CFNrL9AJ0PWk6vcIszOMZJB0WMhyU+f4wRIAJ3YRMKjbVl3S4esgnoMTMSQELXBl uCnmdik5vneVYNPvbtGm0PHtXP/UhO8hmtdjRy3VfI4It2tgtCsJc= Received: (qmail 88333 invoked by alias); 14 Apr 2016 19:38:51 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 88321 invoked by uid 89); 14 Apr 2016 19:38:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-yw0-f177.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=Yh37Q1ioizORRIbxuCUx3uZN9uWrzgkSKUzgtw3O1E4=; b=muVlTUxW5RzBREHNepTqyknZUlWwdjP1HhbXj+Ws8uPE8z9URMDDjjuZUOfkKizLcB If4TyWzRBAaI37lAu7onKo7sv5hxxtqL3eG8aIlttsvaogaf7nfn2sJRR4TicMNYBUEt OGAbST7koF0nH8Tl2oh2dtT85H6M1jJdIDYQKDrZCJU7JHq6UuX9ZdxF4YNwypvbYhpf FDUGPpGR5aCllbJ+Ad81I09PMtqTcQ0YfMCOuwCrOo6Ap73s/VsjvLyXMiI5n2280TBq CQTy7hTTW7/71gGYZ2UjbA3b3fVMwrhwtDOzm70YrSX5Zr6R1aR4UmksDwr08NKL5nl3 7FuA== X-Gm-Message-State: AOPr4FVqdyUAWJy8h7c0OPrktv9XQxtwYInYm969LcRxkp1QYFArAg/M0m7U8N5r6H9+lMU5 X-Received: by 10.129.96.67 with SMTP id u64mr9349603ywb.231.1460662714992; Thu, 14 Apr 2016 12:38:34 -0700 (PDT) Subject: Re: [PATCH 3/4] Consolidate pread/pread64 implementations To: Florian Weimer References: <1456431555-14182-1-git-send-email-adhemerval.zanella@linaro.org> <1456431555-14182-4-git-send-email-adhemerval.zanella@linaro.org> <570FE76E.4010503@redhat.com> Cc: libc-alpha@sourceware.org, Adhemerval Zanella From: Adhemerval Zanella Message-ID: <570FF1B7.7060604@linaro.org> Date: Thu, 14 Apr 2016 16:38:31 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <570FE76E.4010503@redhat.com> On 14-04-2016 15:54, Florian Weimer wrote: > On 02/25/2016 09:19 PM, Adhemerval Zanella wrote: >> From: Adhemerval Zanella >> >> This patch consolidates all the pread/pread64 implementation for Linux >> in only one (sysdeps/unix/sysv/linux/pread.c). It also removes the >> syscall from the auto-generation using assembly macros. > > This may have broken pread and pread64 on 32-bit arm. I'm trying to get more details. > > FAIL: debug/tst-chk1 > FAIL: debug/tst-chk2 > FAIL: debug/tst-chk3 > FAIL: debug/tst-chk4 > FAIL: debug/tst-chk5 > FAIL: debug/tst-chk6 > FAIL: debug/tst-lfschk1 > FAIL: debug/tst-lfschk2 > FAIL: debug/tst-lfschk3 > FAIL: debug/tst-lfschk4 > FAIL: debug/tst-lfschk5 > FAIL: debug/tst-lfschk6 > FAIL: posix/tst-preadwrite > FAIL: posix/tst-preadwrite64 > > The debug/* failures have: > > Failure on line 1006 > Failure on line 1009 > Failure on line 1013 > Failure on line 1032 > Failure on line 1035 > Failure on line 1039 > > Also corresponding to pread, pread64. > > Florian It is because sysdeps/unix/sysv/linux/sysdep.h now requires if __ASSUME_ALIGNED_REGISTER_PAIRS is defined or not to correctly set __ALIGNMENT_ARG and __ALIGNMENT_COUNT. Previously arm pread64 set a 0 after the count argument, which is not set by __ALIGNMENT_ARG. The following patch fixes it: --- --- This was an overlook from my part: the __ALIGNMENT_{ARG,COUNT} definition was moved from another header to this one in a patch iteration and I did not care to actually remake the tests on arm to check if everthing was ok. I will push it soon. diff --git a/sysdeps/unix/sysv/linux/sysdep.h b/sysdeps/unix/sysv/linux/sysdep.h index 4ac4c00..f2d7e05 100644 --- a/sysdeps/unix/sysv/linux/sysdep.h +++ b/sysdeps/unix/sysv/linux/sysdep.h @@ -16,6 +16,7 @@ . */ #include +#include /* Set error number and return -1. A target may choose to return the internal function, __syscall_error, which sets errno and returns -1.