From patchwork Tue May 23 12:49:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 684912 Delivered-To: patch@linaro.org Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp1698003wrt; Tue, 23 May 2023 05:51:04 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5XIHTaQBA7qma+oF5L1JxiofoscxWSbsmXbUzG0C0VQxRS1sUAaAB4TNf3sjmzTnXAXp1w X-Received: by 2002:ac8:5890:0:b0:3f6:a210:1fec with SMTP id t16-20020ac85890000000b003f6a2101fecmr14856061qta.29.1684846264612; Tue, 23 May 2023 05:51:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684846264; cv=none; d=google.com; s=arc-20160816; b=YoWew1GJ7LZXZhnUxEIrXgU/S06KqRuM6ACp4iYpqtpriWovA0pZuCNzgPMcE8vcta MZKQD8dsphhXY+YYQGTt2YtC5WdUoe/oovMkDbgUUumbaKf96VgIWr2h/4tNn3x0aIkJ GTv8UiRg6jYWbwSJQGqlx8dfA3qXHt/sGjYTgwiBuFiHUXoifdKvGBfE3yBAKzWN5ZpD 6XFtT5kFxEER/fDjVJicB/AeY3I+KgEIUFUapm/koDqh0Vc/6eW0xsKJ5NjaHUX1QX8A nab5yGq9Il06mxKdZTCOIHpBWq4iHEnofPnayP/V83UVXsMhO1UWVn2Q/a7zwQTvEnfU VTCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:sender:errors-to:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:message-id:date:subject:to:from :delivered-to:delivered-to:dkim-signature; bh=bo4wEssufY7OMcqJPelA5xe5fr2l354WhOFpd2OibS0=; b=CtLVRzK0y7o4udeJZkkOZO+BS5aejfR3jyFCsGguk+Mg50C08Z6eujo3cvJiPpDT0n Fwdy1DVy+a7D8EoumNE79ySRL+ZybPizJ2fiA79G8gzK9j3rgdO85ZiOCWF/3U/jSM6N pWZ+totlr1KwmxhEf7mdyD0Mj1gDui3E8cPAb4Swo6Rf9OxBzSWFPXSPku33LneYqohs QF2KTMAX0CnRSp3KTRnUyl29UAUpOL9qeA/vgpg+wCimf5DsQYojM4EZn7tRKAY99kWw 7pptZGhREaSXRZaEaHFjwinRFoKSf/sCUZSNGe4IU8uugbIc331rlxPhTpmzt9JeZWf2 EsNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="gwJ/CPqr"; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com. [170.10.133.124]) by mx.google.com with ESMTPS id o17-20020a05622a139100b003eb2a2ffee7si5221454qtk.380.2023.05.23.05.51.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 05:51:04 -0700 (PDT) Received-SPF: pass (google.com: domain of libvir-list-bounces@redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="gwJ/CPqr"; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684846264; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=bo4wEssufY7OMcqJPelA5xe5fr2l354WhOFpd2OibS0=; b=gwJ/CPqrmIYJR6h9rGPUXs3WZ8FO33m3u7iO7hGn9vr9Th+y/NFeKPqTUQ7e1cYbyAeFbX ixuYx9Xn2BneQuvLw/lqI/2p4KYIm2T3jhzdtStoHjOa4+Hg4y22UeG136aS/Mz7fSv+ki 5AkEQLbS/6ZCKEgJDsnIdIMFaNnhugA= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-198-cRxCZd8hPQCwAkRtljL2wg-1; Tue, 23 May 2023 08:50:10 -0400 X-MC-Unique: cRxCZd8hPQCwAkRtljL2wg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B51A8280AA29; Tue, 23 May 2023 12:50:06 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1A96840C6CCF; Tue, 23 May 2023 12:50:06 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id C7A4D19465B1; Tue, 23 May 2023 12:50:05 +0000 (UTC) X-Original-To: libvir-list@listman.corp.redhat.com Delivered-To: libvir-list@listman.corp.redhat.com Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 0105A19465A0 for ; Tue, 23 May 2023 12:50:04 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id DEF4940CFD48; Tue, 23 May 2023 12:50:04 +0000 (UTC) Delivered-To: libvir-list@redhat.com Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D72ED40CFD45 for ; Tue, 23 May 2023 12:50:04 +0000 (UTC) Received: from us-smtp-inbound-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BCBC285A5BB for ; Tue, 23 May 2023 12:50:04 +0000 (UTC) Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-434-0hDPHsqpM9uchP29qF-rQA-1; Tue, 23 May 2023 08:50:02 -0400 X-MC-Unique: 0hDPHsqpM9uchP29qF-rQA-1 Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-306dbad5182so4872968f8f.1 for ; Tue, 23 May 2023 05:50:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684846201; x=1687438201; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bo4wEssufY7OMcqJPelA5xe5fr2l354WhOFpd2OibS0=; b=E993Y8LMeXpMKDsASiNRebvtyJJcM0TTIT0ZchxcdGIeYZs+sHLl3/SbZPwNJcgfSl T2LbkNKh5Ya2PIYsp+3nfRq0fkQvIUok1qN8/TCXwQvXEPg1I9NOiwffUNlmkWdvw3Nf 3XoMtPVzI3ESBcKBfSRYd4CrLwG0H1vUqVEU9qHlqSih8/8KxXOJEFuXBRqy5KtV8LZ4 uez07cG/63bxNxlInlY0wBJoTE0eApMnAvdFpCgzDhk9Ro302bLaQjmcvg69UY17FDif nlIMyueb+SuDuKyKYrQySonCnMHZEbuLYQlixiVpSH5Z3jxqXVWtMpEEoJyBEYitfObI B2Vw== X-Gm-Message-State: AC+VfDxaaHx20kZ8jacviQeKqw4m7lLQ8effJTlK8wbykeELIGYe9j/6 DQLALJCnceOwtxolh5ke4JgcpA== X-Received: by 2002:a5d:4e8c:0:b0:306:37ec:656c with SMTP id e12-20020a5d4e8c000000b0030637ec656cmr10499935wru.66.1684846201635; Tue, 23 May 2023 05:50:01 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id i14-20020adffdce000000b003095bd71159sm11193034wrs.7.2023.05.23.05.50.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 05:50:01 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id E1D5F1FFBB; Tue, 23 May 2023 13:50:00 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org, Stefan Hajnoczi Subject: [PATCH v4 00/10] tracing: remove dynamic vcpu state Date: Tue, 23 May 2023 13:49:50 +0100 Message-Id: <20230523125000.3674739-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , =?utf-8?q?Alex_Benn=C3=A9e?= , libvir-list@redhat.com, Michael Roth , Riku Voipio , Christian Schoenebeck , Markus Armbruster , Greg Kurz , Yanan Wang , Marcel Apfelbaum , Kyle Evans , Paolo Bonzini , Richard Henderson , Eric Blake , Warner Losh Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: linaro.org Hi Stefan, The references dynamic vcpu tracing support was removed when the original TCG trace points where removed. However there was still a legacy of dynamic trace state to track this in cpu.h and extra hash variables to track TBs. While the removed vcpu tracepoints are not in generated code (or helpers) they still bring in a bunch of machinery to manage the state so I've pulled them out. We keep and rename one (cpu_reset) to a static trace points which dump vcpu->index as it is useful to f4bug. v4 addressed Markus's comments on QAPI bits and other fixes during re-base. Please queue into your tree. Alex Bennée (10): *-user: remove the guest_user_syscall tracepoints trace-events: remove the remaining vcpu trace events trace: remove vcpu_id from the TraceEvent structure scripts/qapi: document the tool that generated the file qapi: make the vcpu parameters deprecated for 8.1 trace: remove code that depends on setting vcpu trace: remove control-vcpu.h tcg: remove the final vestiges of dstate hw/9pfs: use qemu_xxhash4 accel/tcg: include cs_base in our hash calculations docs/about/deprecated.rst | 9 +++ qapi/trace.json | 38 ++++++------ accel/tcg/tb-hash.h | 6 +- include/exec/exec-all.h | 3 - include/hw/core/cpu.h | 5 -- include/qemu/xxhash.h | 23 +++++-- include/user/syscall-trace.h | 4 -- trace/control-internal.h | 10 ---- trace/control-vcpu.h | 63 -------------------- trace/control.h | 48 --------------- trace/event-internal.h | 2 - accel/tcg/cpu-exec.c | 7 +-- accel/tcg/tb-maint.c | 5 +- accel/tcg/translate-all.c | 6 -- bsd-user/freebsd/os-syscall.c | 2 - hw/9pfs/9p.c | 5 +- hw/core/cpu-common.c | 6 +- stubs/trace-control.c | 13 ---- trace/control-target.c | 109 +++------------------------------- trace/control.c | 28 --------- trace/qmp.c | 76 +++--------------------- trace/trace-hmp-cmds.c | 17 +----- util/qsp.c | 2 +- hw/core/trace-events | 3 + scripts/qapi/gen.py | 8 ++- scripts/tracetool/format/c.py | 6 -- scripts/tracetool/format/h.py | 16 +---- trace-events | 50 ---------------- 28 files changed, 86 insertions(+), 484 deletions(-) delete mode 100644 trace/control-vcpu.h