From patchwork Wed May 21 11:10:02 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 30525 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pa0-f69.google.com (mail-pa0-f69.google.com [209.85.220.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 4031120671 for ; Wed, 21 May 2014 11:11:04 +0000 (UTC) Received: by mail-pa0-f69.google.com with SMTP id ey11sf5532778pad.8 for ; Wed, 21 May 2014 04:11:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:in-reply-to:references :sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=EMbeAyXJkD+jm4H34uMevGzXA3BxVq0Mdz55ai3rBaA=; b=U2XAoVDgoXCaFBunQLDtQvn57gcBpSU0SmPf1YIQQ6Gz4RN7g+PEOHb2KjO8Ei448b POPQqI0Nh+9RUndMmfX4Q1qhfbHQPKx8gbwzJuetNlkcWdCTdjHNcayd2juC9sK9dORb MkXg5aa93/QLzFKm0Vt5hQCX4wrgU08m6j1GxSxMSLH5BQ9996WXSIjH5K930yzdN0Uo GgiwsvSGNiaKZyscceTyTNSKv4hvTKqvvVhzlYdAloyWw3fMkB3NEkOdkglALrtPJKjz gBK1J18lt51vuUHRS5OCjSnkWIEsLOJeAoxjsVD3vfSuemsfpj0ypD7lG91R7VB0UniL NR3A== X-Gm-Message-State: ALoCoQmpoTRlMjOoZWNlDi+9zUE+YlxQdb3etQ7zphSo3/p7lsvCUDUvadqxIZ8vMzZQEvPQW/wo X-Received: by 10.66.66.109 with SMTP id e13mr21741438pat.1.1400670663199; Wed, 21 May 2014 04:11:03 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.43.35 with SMTP id d32ls712952qga.87.gmail; Wed, 21 May 2014 04:11:03 -0700 (PDT) X-Received: by 10.52.11.230 with SMTP id t6mr7740133vdb.27.1400670663073; Wed, 21 May 2014 04:11:03 -0700 (PDT) Received: from mail-ve0-f182.google.com (mail-ve0-f182.google.com [209.85.128.182]) by mx.google.com with ESMTPS id gm7si390711vec.4.2014.05.21.04.11.03 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 21 May 2014 04:11:03 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.182 as permitted sender) client-ip=209.85.128.182; Received: by mail-ve0-f182.google.com with SMTP id sa20so2310090veb.27 for ; Wed, 21 May 2014 04:11:03 -0700 (PDT) X-Received: by 10.52.110.195 with SMTP id ic3mr33297vdb.53.1400670662982; Wed, 21 May 2014 04:11:02 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp103813vcb; Wed, 21 May 2014 04:11:02 -0700 (PDT) X-Received: by 10.68.220.137 with SMTP id pw9mr58159993pbc.24.1400670661457; Wed, 21 May 2014 04:11:01 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id uv11si28693483pab.15.2014.05.21.04.11.00; Wed, 21 May 2014 04:11:00 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752372AbaEULKy (ORCPT + 27 others); Wed, 21 May 2014 07:10:54 -0400 Received: from mail-qg0-f52.google.com ([209.85.192.52]:48894 "EHLO mail-qg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752343AbaEULKv (ORCPT ); Wed, 21 May 2014 07:10:51 -0400 Received: by mail-qg0-f52.google.com with SMTP id a108so2921530qge.11 for ; Wed, 21 May 2014 04:10:50 -0700 (PDT) X-Received: by 10.224.79.143 with SMTP id p15mr66755563qak.57.1400670650266; Wed, 21 May 2014 04:10:50 -0700 (PDT) Received: from localhost (ec2-23-23-178-99.compute-1.amazonaws.com. [23.23.178.99]) by mx.google.com with ESMTPSA id s60sm534980qga.30.2014.05.21.04.10.45 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 21 May 2014 04:10:49 -0700 (PDT) From: Viresh Kumar To: rjw@rjwysocki.net Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, arvind.chauhan@arm.com, inderpal.s@samsung.com, nm@ti.com, chander.kashyap@linaro.org, pavel@ucw.cz, len.brown@intel.com, sudeep.holla@arm.com, Viresh Kumar Subject: [PATCH V2 4/7] cpufreq: arm_big_little: don't initialize opp table Date: Wed, 21 May 2014 16:40:02 +0530 Message-Id: <2c310ea534ac3cc181937bc8adf87c4695d6eb70.1400670427.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.0.0.rc2 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.182 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , OPP tables are already initialized for all CPUs by cpufreq core and so we don't need to reinitialize them from arm_big_little_dt driver. Also, as the arm_big_little_dt driver doesn't have a .init_opp_table() callback anymore, make it optional in arm_big_little driver. Cc: Sudeep Holla Signed-off-by: Viresh Kumar --- drivers/cpufreq/arm_big_little.c | 12 +++++++----- drivers/cpufreq/arm_big_little_dt.c | 18 ------------------ 2 files changed, 7 insertions(+), 23 deletions(-) diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c index 1f4d4e3..561261e 100644 --- a/drivers/cpufreq/arm_big_little.c +++ b/drivers/cpufreq/arm_big_little.c @@ -325,11 +325,13 @@ static int _get_cluster_clk_and_freq_table(struct device *cpu_dev) if (freq_table[cluster]) return 0; - ret = arm_bL_ops->init_opp_table(cpu_dev); - if (ret) { - dev_err(cpu_dev, "%s: init_opp_table failed, cpu: %d, err: %d\n", + if (arm_bL_ops->init_opp_table) { + ret = arm_bL_ops->init_opp_table(cpu_dev); + if (ret) { + dev_err(cpu_dev, "%s: init_opp_table failed, cpu: %d, err: %d\n", __func__, cpu_dev->id, ret); - goto out; + goto out; + } } ret = dev_pm_opp_init_cpufreq_table(cpu_dev, &freq_table[cluster]); @@ -542,7 +544,7 @@ int bL_cpufreq_register(struct cpufreq_arm_bL_ops *ops) return -EBUSY; } - if (!ops || !strlen(ops->name) || !ops->init_opp_table) { + if (!ops || !strlen(ops->name)) { pr_err("%s: Invalid arm_bL_ops, exiting\n", __func__); return -ENODEV; } diff --git a/drivers/cpufreq/arm_big_little_dt.c b/drivers/cpufreq/arm_big_little_dt.c index 8d9d591..502182d 100644 --- a/drivers/cpufreq/arm_big_little_dt.c +++ b/drivers/cpufreq/arm_big_little_dt.c @@ -43,23 +43,6 @@ static struct device_node *get_cpu_node_with_valid_op(int cpu) return np; } -static int dt_init_opp_table(struct device *cpu_dev) -{ - struct device_node *np; - int ret; - - np = of_node_get(cpu_dev->of_node); - if (!np) { - pr_err("failed to find cpu%d node\n", cpu_dev->id); - return -ENOENT; - } - - ret = of_init_opp_table(cpu_dev); - of_node_put(np); - - return ret; -} - static int dt_get_transition_latency(struct device *cpu_dev) { struct device_node *np; @@ -81,7 +64,6 @@ static int dt_get_transition_latency(struct device *cpu_dev) static struct cpufreq_arm_bL_ops dt_bL_ops = { .name = "dt-bl", .get_transition_latency = dt_get_transition_latency, - .init_opp_table = dt_init_opp_table, }; static int generic_bL_probe(struct platform_device *pdev)