From patchwork Wed Nov 26 05:52:56 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 41520 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f71.google.com (mail-la0-f71.google.com [209.85.215.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 1D64225E72 for ; Wed, 26 Nov 2014 05:53:28 +0000 (UTC) Received: by mail-la0-f71.google.com with SMTP id s18sf1324798lam.6 for ; Tue, 25 Nov 2014 21:53:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:in-reply-to:references :sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=FQx5QmB9W4jqjt1GDaJJUXq+d2tWt0POqgKKsBPi65I=; b=j3yFE8jphpHWKc/BeGhtPYNRDy/nDQ8eGi5r1qgLp9hwnBuo4rzXlGX3ddQESTyDta ekcLOg0r22MRg2IXRp+OvKaXxJE4I2IVEjqrWCMYSfAb6JQ0rSilUbxVb9ggMl0bGn0j vEQhWTiP0bXdArmzqhg1/SK4zgp+HXayyxwXXRxTfO/XvjmF8ei948lU0XIYTN7sZMde vloabcMRC8BNrQH/M7CplXbOysFYErZhb8QEeU4mNAVSgueQ51RiLHYsE+am+JHDQJ1C X8aYMsgtRdKDYQe9Pl+x366YmZMoR/1+EUeuwhtLRG9jX0/dObVsVYN6kkCy7PaKCZ0C 5g2w== X-Gm-Message-State: ALoCoQlz+KFng8mfvPPvrVLC99OFVaMU9+cAUinaEOKEDMjgsapu7N10WDzXhSYidr27oNIoNRGx X-Received: by 10.152.6.4 with SMTP id w4mr28739law.7.1416981207012; Tue, 25 Nov 2014 21:53:27 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.4.132 with SMTP id k4ls672581lak.12.gmail; Tue, 25 Nov 2014 21:53:26 -0800 (PST) X-Received: by 10.152.198.235 with SMTP id jf11mr32250873lac.72.1416981206674; Tue, 25 Nov 2014 21:53:26 -0800 (PST) Received: from mail-la0-f47.google.com (mail-la0-f47.google.com. [209.85.215.47]) by mx.google.com with ESMTPS id ir2si3260558lac.127.2014.11.25.21.53.26 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 25 Nov 2014 21:53:26 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.47 as permitted sender) client-ip=209.85.215.47; Received: by mail-la0-f47.google.com with SMTP id hz20so1834944lab.6 for ; Tue, 25 Nov 2014 21:53:26 -0800 (PST) X-Received: by 10.112.189.10 with SMTP id ge10mr31659714lbc.23.1416981206549; Tue, 25 Nov 2014 21:53:26 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.184.201 with SMTP id ew9csp572419lbc; Tue, 25 Nov 2014 21:53:25 -0800 (PST) X-Received: by 10.66.186.101 with SMTP id fj5mr49536330pac.145.1416981204773; Tue, 25 Nov 2014 21:53:24 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id fl2si5023000pad.233.2014.11.25.21.53.23 for ; Tue, 25 Nov 2014 21:53:24 -0800 (PST) Received-SPF: none (google.com: linux-pm-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752206AbaKZFxW (ORCPT + 12 others); Wed, 26 Nov 2014 00:53:22 -0500 Received: from mail-pa0-f48.google.com ([209.85.220.48]:36686 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751091AbaKZFxV (ORCPT ); Wed, 26 Nov 2014 00:53:21 -0500 Received: by mail-pa0-f48.google.com with SMTP id rd3so2161450pab.21 for ; Tue, 25 Nov 2014 21:53:21 -0800 (PST) X-Received: by 10.69.18.225 with SMTP id gp1mr49305894pbd.144.1416981201457; Tue, 25 Nov 2014 21:53:21 -0800 (PST) Received: from localhost ([122.167.111.40]) by mx.google.com with ESMTPSA id x10sm3148234pdr.11.2014.11.25.21.53.20 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 25 Nov 2014 21:53:20 -0800 (PST) From: Viresh Kumar To: Rafael Wysocki , edubezval@gmail.com Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, l.majewski@samsung.com, Viresh Kumar Subject: [PATCH 1/7] cpufreq: Fix formatting issues in 'struct cpufreq_driver' Date: Wed, 26 Nov 2014 11:22:56 +0530 Message-Id: <3d727922615731d6e839f1ce5cb977bd3fc6ed24.1416980447.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.0.3.693.g996b0fd In-Reply-To: References: In-Reply-To: References: Sender: linux-pm-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.47 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Adding any new callback to 'struct cpufreq_driver' gives following checkpatch warning: WARNING: Unnecessary space before function pointer arguments + void (*usable) (struct cpufreq_policy *policy); This is because we have been using a tab spacing between function pointer name and its arguments and the new one tried to follow that. Though we normally don't try to fix every checkpatch warning, specially around formatting issues as that creates unnecessary noise over lists. But I thought we better fix this so that new additions don't generate these warnings plus it looks far better/symmetric now. So, remove these tab spacing issues in 'struct cpufreq_driver' only + fix alignment of all members. Signed-off-by: Viresh Kumar --- include/linux/cpufreq.h | 50 ++++++++++++++++++++++++------------------------- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index 503b085..db3c130 100644 --- a/include/linux/cpufreq.h +++ b/include/linux/cpufreq.h @@ -217,26 +217,26 @@ __ATTR(_name, 0644, show_##_name, store_##_name) struct cpufreq_driver { - char name[CPUFREQ_NAME_LEN]; - u8 flags; - void *driver_data; + char name[CPUFREQ_NAME_LEN]; + u8 flags; + void *driver_data; /* needed by all drivers */ - int (*init) (struct cpufreq_policy *policy); - int (*verify) (struct cpufreq_policy *policy); + int (*init)(struct cpufreq_policy *policy); + int (*verify)(struct cpufreq_policy *policy); /* define one out of two */ - int (*setpolicy) (struct cpufreq_policy *policy); + int (*setpolicy)(struct cpufreq_policy *policy); /* * On failure, should always restore frequency to policy->restore_freq * (i.e. old freq). */ - int (*target) (struct cpufreq_policy *policy, /* Deprecated */ - unsigned int target_freq, - unsigned int relation); - int (*target_index) (struct cpufreq_policy *policy, - unsigned int index); + int (*target)(struct cpufreq_policy *policy, + unsigned int target_freq, + unsigned int relation); /* Deprecated */ + int (*target_index)(struct cpufreq_policy *policy, + unsigned int index); /* * Only for drivers with target_index() and CPUFREQ_ASYNC_NOTIFICATION * unset. @@ -252,27 +252,27 @@ struct cpufreq_driver { * wish to switch to intermediate frequency for some target frequency. * In that case core will directly call ->target_index(). */ - unsigned int (*get_intermediate)(struct cpufreq_policy *policy, - unsigned int index); - int (*target_intermediate)(struct cpufreq_policy *policy, - unsigned int index); + unsigned int (*get_intermediate)(struct cpufreq_policy *policy, + unsigned int index); + int (*target_intermediate)(struct cpufreq_policy *policy, + unsigned int index); /* should be defined, if possible */ - unsigned int (*get) (unsigned int cpu); + unsigned int (*get)(unsigned int cpu); /* optional */ - int (*bios_limit) (int cpu, unsigned int *limit); + int (*bios_limit)(int cpu, unsigned int *limit); - int (*exit) (struct cpufreq_policy *policy); - void (*stop_cpu) (struct cpufreq_policy *policy); - int (*suspend) (struct cpufreq_policy *policy); - int (*resume) (struct cpufreq_policy *policy); - struct freq_attr **attr; + int (*exit)(struct cpufreq_policy *policy); + void (*stop_cpu)(struct cpufreq_policy *policy); + int (*suspend)(struct cpufreq_policy *policy); + int (*resume)(struct cpufreq_policy *policy); + struct freq_attr **attr; /* platform specific boost support code */ - bool boost_supported; - bool boost_enabled; - int (*set_boost) (int state); + bool boost_supported; + bool boost_enabled; + int (*set_boost)(int state); }; /* flags */