From patchwork Tue May 5 11:43:33 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 48024 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f198.google.com (mail-wi0-f198.google.com [209.85.212.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id F2D9220553 for ; Tue, 5 May 2015 11:43:40 +0000 (UTC) Received: by wiun10 with SMTP id n10sf41776693wiu.1 for ; Tue, 05 May 2015 04:43:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mime-version:in-reply-to:references :date:message-id:subject:from:to:cc:content-type:sender:precedence :list-id:x-original-sender:x-original-authentication-results :mailing-list:list-post:list-help:list-archive:list-unsubscribe; bh=ogbHvbCRRyNLCZ7gCU13cKCYRcaEi20KbZ5X+qrumQQ=; b=LyQeAjAZgHGOCwEataADNObD04e8SfDMcIj/nbRG8O5XegEE+qGuHftio+iLP9oPnQ h8MZcwn0m6EVuUetiJ3K6rhhlTSD8SXp7Ce624He95H5I1JZpG2w59/Vsbm9WYkLaq6p 6p3eiquCYCjT3ZqPPW65wCMlKl0Ldrcokc5TEWKCV6shcT60kZYFN8q1IppdmAy09f+C rYpOBPpKIKvzxWFd7OgamaXRIeGvP0WJL+nvc2O8pPHi9YvSUFZuOY4mzHiEunpM6pEL t/xros2Q/oqNd5OSvRbZCAJ4jZJvlMit89ji3Pefv39FB65pwV6+2rM4/8zMZ3uWyBG0 zV/g== X-Gm-Message-State: ALoCoQmfF4gRAhQKcLYPUUyIgS35q2zfj+KHzIYzDZingpBYGzupBOJ4gHZ407mKUSwqUPXXoJLZ X-Received: by 10.112.46.172 with SMTP id w12mr22035131lbm.18.1430826220221; Tue, 05 May 2015 04:43:40 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.206.98 with SMTP id ln2ls896014lac.61.gmail; Tue, 05 May 2015 04:43:39 -0700 (PDT) X-Received: by 10.152.44.225 with SMTP id h1mr23434832lam.5.1430826219950; Tue, 05 May 2015 04:43:39 -0700 (PDT) Received: from mail-la0-f54.google.com (mail-la0-f54.google.com. [209.85.215.54]) by mx.google.com with ESMTPS id p10si12263282laa.17.2015.05.05.04.43.39 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 May 2015 04:43:39 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.54 as permitted sender) client-ip=209.85.215.54; Received: by lagv1 with SMTP id v1so125031319lag.3 for ; Tue, 05 May 2015 04:43:39 -0700 (PDT) X-Received: by 10.112.219.70 with SMTP id pm6mr23161486lbc.41.1430826219778; Tue, 05 May 2015 04:43:39 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.67.65 with SMTP id l1csp2191533lbt; Tue, 5 May 2015 04:43:38 -0700 (PDT) X-Received: by 10.66.66.135 with SMTP id f7mr30344769pat.22.1430826217718; Tue, 05 May 2015 04:43:37 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gj10si23412279pbd.199.2015.05.05.04.43.36; Tue, 05 May 2015 04:43:37 -0700 (PDT) Received-SPF: none (google.com: devicetree-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758455AbbEELnf (ORCPT + 6 others); Tue, 5 May 2015 07:43:35 -0400 Received: from mail-ob0-f178.google.com ([209.85.214.178]:36621 "EHLO mail-ob0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758271AbbEELne (ORCPT ); Tue, 5 May 2015 07:43:34 -0400 Received: by obbkp3 with SMTP id kp3so79946698obb.3 for ; Tue, 05 May 2015 04:43:34 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.60.63.244 with SMTP id j20mr22339998oes.12.1430826213906; Tue, 05 May 2015 04:43:33 -0700 (PDT) Received: by 10.182.185.18 with HTTP; Tue, 5 May 2015 04:43:33 -0700 (PDT) In-Reply-To: <20150505105714.GA22845@sirena.org.uk> References: <20150504121209.GM15510@sirena.org.uk> <20150505105714.GA22845@sirena.org.uk> Date: Tue, 5 May 2015 17:13:33 +0530 Message-ID: Subject: Re: [PATCH V4 1/3] OPP: Redefine bindings to overcome shortcomings From: Viresh Kumar To: Mark Brown Cc: Rafael Wysocki , Rob Herring , Arnd Bergmann , Nishanth Menon , Mike Turquette , Stephen Boyd , Linaro Kernel Mailman List , "linux-pm@vger.kernel.org" , Grant Likely , "olof@lixom.net" , Sudeep Holla , "devicetree@vger.kernel.org" , Viswanath Puttagunta , Lucas Stach , Thomas Petazzoni , "linux-arm-kernel@lists.infradead.org" , Thomas Abraham , Abhilash Kesavan , Kevin Hilman , santosh shilimkar Sender: devicetree-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: devicetree@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.54 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On 5 May 2015 at 16:27, Mark Brown wrote: > No, it doesn't - you're not answering the question about what this is > for. I don't know how this information will be used finally. Probably the platform driver will do the configuration based on the volt-cur pair. > To know if this makes sense I need to know what you beleive "setting the > current" does. If you literally mean setting the current it makes no > sense at all. If you mean something else that something else should > probably be written into the binding. Yeah, that was a wrong statement. We can't configure current separately. Does this diff make it any better ? nanoseconds) for switching to this OPP from any other OPP. (Restoring my laptop after a corrupted disk, and so sending it from gmail, might be a bit corrupted).. --- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/Documentation/devicetree/bindings/power/opp.txt b/Documentation/devicetree/bindings/power/opp.txt index c96dc77121b7..a57e88ab4554 100644 --- a/Documentation/devicetree/bindings/power/opp.txt +++ b/Documentation/devicetree/bindings/power/opp.txt @@ -59,16 +59,18 @@ properties. regulators are specified in device's DT node. - opp-microamp: current in micro Amperes. It can contain entries for multiple - regulators. + regulators. This can be referenced (along with voltage and freqency) while + programming the regulator. A single regulator's current is specified with an array of size one or three. Single entry is for target current and three entries are for currents. Entries for multiple regulators must be present in the same order as - regulators are specified in device's DT node. If few regulators don't provide - capability to configure current, then values for then should be marked as - zero. + regulators are specified in device's DT node. If current value for few + regulators isn't required to be passed, then values for such regulators should + be marked as zero. If it isn't required for any regulator, then this property + need not be present. - clock-latency-ns: Specifies the maximum possible transition latency (in