From patchwork Thu Dec 18 12:00:27 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 42438 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ee0-f72.google.com (mail-ee0-f72.google.com [74.125.83.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id D4F4B26C8B for ; Thu, 18 Dec 2014 12:01:46 +0000 (UTC) Received: by mail-ee0-f72.google.com with SMTP id e53sf769183eek.3 for ; Thu, 18 Dec 2014 04:01:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:in-reply-to:references :sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=czgU41lgG0N+Tpq/uG2qno9WkscenLyaaMBD6CR5400=; b=HxIIloxfW0lP4ggmwceZGLck1ZMg500Em1qe3vyXgIb5bMJT9YEMzN3B2KuQmDXL0v 9XnKrp2lBUeCBoBtUJJzy7q7kzJqF1uX3dEYUVmS+5q9J6CemltsyxX7RhPaidAUqbX2 MBbntkQYUA/4Zfn6C0my/4dtBzHxDIzGHg6vh0IeV/Q9H97lwNxIvZqWybfZHmMEb0d4 ysz9TG10m/DCB7jmKSM2uBTEUzrBjJx1qphDSZ0ey+gZm1A4AeOG7jozMTG3rEcyvIZ1 hV2V264VPhl/IH5VyiwJd7GJJqYpqps+IZucrVk2vYnyxETCG1A3mlQAS89n3LyYdYND ix+g== X-Gm-Message-State: ALoCoQlKwdTdv7PHTKYIRmP0sBmhr6HTYUa9Lmkv+uAah15LliUKrWY2EKAgqHKtlhpiz0juEyCK X-Received: by 10.180.81.39 with SMTP id w7mr2082977wix.1.1418904106076; Thu, 18 Dec 2014 04:01:46 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.4.169 with SMTP id l9ls1262484lal.101.gmail; Thu, 18 Dec 2014 04:01:45 -0800 (PST) X-Received: by 10.152.7.206 with SMTP id l14mr1859550laa.1.1418904105692; Thu, 18 Dec 2014 04:01:45 -0800 (PST) Received: from mail-la0-f44.google.com (mail-la0-f44.google.com. [209.85.215.44]) by mx.google.com with ESMTPS id gn10si6620876lbc.102.2014.12.18.04.01.45 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 18 Dec 2014 04:01:45 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.44 as permitted sender) client-ip=209.85.215.44; Received: by mail-la0-f44.google.com with SMTP id gd6so878067lab.3 for ; Thu, 18 Dec 2014 04:01:45 -0800 (PST) X-Received: by 10.152.25.129 with SMTP id c1mr1882895lag.9.1418904105603; Thu, 18 Dec 2014 04:01:45 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.142.69 with SMTP id ru5csp1680564lbb; Thu, 18 Dec 2014 04:01:44 -0800 (PST) X-Received: by 10.68.221.106 with SMTP id qd10mr2804649pbc.98.1418904103489; Thu, 18 Dec 2014 04:01:43 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ov3si9608661pbc.228.2014.12.18.04.01.42; Thu, 18 Dec 2014 04:01:43 -0800 (PST) Received-SPF: none (google.com: linux-pm-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752471AbaLRMBm (ORCPT + 12 others); Thu, 18 Dec 2014 07:01:42 -0500 Received: from mail-pd0-f169.google.com ([209.85.192.169]:50168 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752450AbaLRMBl (ORCPT ); Thu, 18 Dec 2014 07:01:41 -0500 Received: by mail-pd0-f169.google.com with SMTP id z10so1318454pdj.0 for ; Thu, 18 Dec 2014 04:01:41 -0800 (PST) X-Received: by 10.68.131.39 with SMTP id oj7mr2585466pbb.145.1418904100725; Thu, 18 Dec 2014 04:01:40 -0800 (PST) Received: from localhost ([122.166.148.73]) by mx.google.com with ESMTPSA id vy1sm6698978pac.20.2014.12.18.04.01.39 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 18 Dec 2014 04:01:40 -0800 (PST) From: Viresh Kumar To: Rafael Wysocki Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, Viresh Kumar Subject: [PATCH 10/13] cpufreq: stats: don't update stats from show_trans_table() Date: Thu, 18 Dec 2014 17:30:27 +0530 Message-Id: X-Mailer: git-send-email 2.2.0 In-Reply-To: References: In-Reply-To: References: Sender: linux-pm-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.44 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , cpufreq_stats_update() updates time_in_state and nothing else. It should ideally be updated only in two cases: - User requested for the current value of time_in_state. - We have switched states and so need to update time for the last state. Currently, we are also doing this while user asks for the transition table of frequencies. It wouldn't do any harm, but no good as well. Its useless here. Remove it. Signed-off-by: Viresh Kumar --- drivers/cpufreq/cpufreq_stats.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/cpufreq/cpufreq_stats.c b/drivers/cpufreq/cpufreq_stats.c index dd55d57655ce..c0c2ddece8fe 100644 --- a/drivers/cpufreq/cpufreq_stats.c +++ b/drivers/cpufreq/cpufreq_stats.c @@ -77,7 +77,6 @@ static ssize_t show_trans_table(struct cpufreq_policy *policy, char *buf) ssize_t len = 0; int i, j; - cpufreq_stats_update(stat); len += snprintf(buf + len, PAGE_SIZE - len, " From : To\n"); len += snprintf(buf + len, PAGE_SIZE - len, " : "); for (i = 0; i < stat->state_num; i++) {