From patchwork Wed May 21 11:10:03 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 30526 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pa0-f71.google.com (mail-pa0-f71.google.com [209.85.220.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id CD29F20671 for ; Wed, 21 May 2014 11:11:08 +0000 (UTC) Received: by mail-pa0-f71.google.com with SMTP id kq14sf5542599pab.6 for ; Wed, 21 May 2014 04:11:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:in-reply-to:references :sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=ieCOfbCLABtBx3j3MpaJmx3TuJznNkLOoz7RUop6N/A=; b=fvVgGZtaGz3gyApHgYmFH8mSTUHgvSAn8vTTU6K2BVoE6cy2aBodTtr2fKRX9Qazc9 rYx6mo5oze5zxirM4T1rqiW6oaNGGvPMB2eZljU2CBxNijuHnnwuNmUKTEV1A0tj0SzR /XOyDBv2LuChs1D12O4VCXkVQBO8kk2izcAD3PB0/D2J8+xtxM14MUFmLGj83GVMp/xp S2Ewy7sjX1H5bb4lcx3ziFiSajihwaW8jBJfPSDZnqUOAfea21wRQ0CCO80eaEYbWq/4 V3UYo7wpgouB1IPUG5jhVzILOGyNH98SQbYGY5l0/NMx29zLMsr66/4SDAsHEkChsOLx 7Uww== X-Gm-Message-State: ALoCoQk63YHls0w1H+5Mm2/4Tp+dLbi2e+iv7zBn8YxC/RY3o2t+Yd/nm/MrCFF97vXJWaTcMf/3 X-Received: by 10.66.162.38 with SMTP id xx6mr8717694pab.46.1400670668066; Wed, 21 May 2014 04:11:08 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.36.14 with SMTP id o14ls650496qgo.63.gmail; Wed, 21 May 2014 04:11:07 -0700 (PDT) X-Received: by 10.58.30.1 with SMTP id o1mr7148028veh.37.1400670667841; Wed, 21 May 2014 04:11:07 -0700 (PDT) Received: from mail-ve0-f180.google.com (mail-ve0-f180.google.com [209.85.128.180]) by mx.google.com with ESMTPS id fd12si390753vec.17.2014.05.21.04.11.07 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 21 May 2014 04:11:07 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.180 as permitted sender) client-ip=209.85.128.180; Received: by mail-ve0-f180.google.com with SMTP id db12so2225490veb.25 for ; Wed, 21 May 2014 04:11:07 -0700 (PDT) X-Received: by 10.58.135.136 with SMTP id ps8mr15582257veb.18.1400670667773; Wed, 21 May 2014 04:11:07 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp103820vcb; Wed, 21 May 2014 04:11:07 -0700 (PDT) X-Received: by 10.66.192.225 with SMTP id hj1mr57916932pac.142.1400670666997; Wed, 21 May 2014 04:11:06 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id pm3si5781194pbb.64.2014.05.21.04.11.06; Wed, 21 May 2014 04:11:06 -0700 (PDT) Received-SPF: none (google.com: linux-pm-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752400AbaEULLA (ORCPT + 12 others); Wed, 21 May 2014 07:11:00 -0400 Received: from mail-qc0-f178.google.com ([209.85.216.178]:41225 "EHLO mail-qc0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752382AbaEULK7 (ORCPT ); Wed, 21 May 2014 07:10:59 -0400 Received: by mail-qc0-f178.google.com with SMTP id l6so2863268qcy.37 for ; Wed, 21 May 2014 04:10:59 -0700 (PDT) X-Received: by 10.224.166.9 with SMTP id k9mr67491752qay.25.1400670659164; Wed, 21 May 2014 04:10:59 -0700 (PDT) Received: from localhost (ec2-23-23-178-99.compute-1.amazonaws.com. [23.23.178.99]) by mx.google.com with ESMTPSA id j97sm533010qgd.37.2014.05.21.04.10.53 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 21 May 2014 04:10:58 -0700 (PDT) From: Viresh Kumar To: rjw@rjwysocki.net Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, arvind.chauhan@arm.com, inderpal.s@samsung.com, nm@ti.com, chander.kashyap@linaro.org, pavel@ucw.cz, len.brown@intel.com, sudeep.holla@arm.com, Viresh Kumar Subject: [PATCH V2 5/7] cpufreq: imx6q: don't initialize opp table Date: Wed, 21 May 2014 16:40:03 +0530 Message-Id: X-Mailer: git-send-email 2.0.0.rc2 In-Reply-To: References: In-Reply-To: References: Sender: linux-pm-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.180 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , OPP tables are already initialized for CPU0 by cpufreq core and so we don't need to reinitialize them from imx6q specific code. Acked-by: Shawn Guo Signed-off-by: Viresh Kumar --- arch/arm/mach-imx/mach-imx6q.c | 36 ++++++++---------------------------- drivers/cpufreq/imx6q-cpufreq.c | 20 +------------------- 2 files changed, 9 insertions(+), 47 deletions(-) diff --git a/arch/arm/mach-imx/mach-imx6q.c b/arch/arm/mach-imx/mach-imx6q.c index e60456d..03819e7 100644 --- a/arch/arm/mach-imx/mach-imx6q.c +++ b/arch/arm/mach-imx/mach-imx6q.c @@ -290,12 +290,18 @@ static void __init imx6q_init_machine(void) #define OCOTP_CFG3_SPEED_996MHZ 0x2 #define OCOTP_CFG3_SPEED_852MHZ 0x1 -static void __init imx6q_opp_check_speed_grading(struct device *cpu_dev) +static void __init imx6q_opp_check_speed_grading(void) { + struct device *cpu_dev = get_cpu_device(0); struct device_node *np; void __iomem *base; u32 val; + if (!cpu_dev) { + pr_warn("failed to get cpu0 device\n"); + return; + } + np = of_find_compatible_node(NULL, NULL, "fsl,imx6q-ocotp"); if (!np) { pr_warn("failed to find ocotp node\n"); @@ -336,32 +342,6 @@ put_node: of_node_put(np); } -static void __init imx6q_opp_init(void) -{ - struct device_node *np; - struct device *cpu_dev = get_cpu_device(0); - - if (!cpu_dev) { - pr_warn("failed to get cpu0 device\n"); - return; - } - np = of_node_get(cpu_dev->of_node); - if (!np) { - pr_warn("failed to find cpu0 node\n"); - return; - } - - if (of_init_opp_table(cpu_dev)) { - pr_warn("failed to init OPP table\n"); - goto put_node; - } - - imx6q_opp_check_speed_grading(cpu_dev); - -put_node: - of_node_put(np); -} - static struct platform_device imx6q_cpufreq_pdev = { .name = "imx6q-cpufreq", }; @@ -376,7 +356,7 @@ static void __init imx6q_init_late(void) imx6q_cpuidle_init(); if (IS_ENABLED(CONFIG_ARM_IMX6Q_CPUFREQ)) { - imx6q_opp_init(); + imx6q_opp_check_speed_grading(); platform_device_register(&imx6q_cpufreq_pdev); } } diff --git a/drivers/cpufreq/imx6q-cpufreq.c b/drivers/cpufreq/imx6q-cpufreq.c index af366c2..b72e94f 100644 --- a/drivers/cpufreq/imx6q-cpufreq.c +++ b/drivers/cpufreq/imx6q-cpufreq.c @@ -190,26 +190,8 @@ static int imx6q_cpufreq_probe(struct platform_device *pdev) goto put_reg; } - /* - * We expect an OPP table supplied by platform. - * Just, incase the platform did not supply the OPP - * table, it will try to get it. - */ num = dev_pm_opp_get_opp_count(cpu_dev); - if (num < 0) { - ret = of_init_opp_table(cpu_dev); - if (ret < 0) { - dev_err(cpu_dev, "failed to init OPP table: %d\n", ret); - goto put_reg; - } - - num = dev_pm_opp_get_opp_count(cpu_dev); - if (num < 0) { - ret = num; - dev_err(cpu_dev, "no OPP table is found: %d\n", ret); - goto put_reg; - } - } + WARN_ON(num < 0); ret = dev_pm_opp_init_cpufreq_table(cpu_dev, &freq_table); if (ret) {