From patchwork Mon Nov 12 08:29:49 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 12807 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 395C523DE1 for ; Mon, 12 Nov 2012 08:30:24 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id BD7C1A19878 for ; Mon, 12 Nov 2012 08:30:23 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id e10so8259188iej.11 for ; Mon, 12 Nov 2012 00:30:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:x-auditid :from:to:date:message-id:x-mailer:x-brightmail-tracker:cc:subject :x-beenthere:x-mailman-version:precedence:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:mime-version :content-type:content-transfer-encoding:sender:errors-to :x-gm-message-state; bh=k1wlEx2Hu+XXzgtIYWdf/ETkvERE5L+j+UZOXTI/Gns=; b=llrw32exSsMM9x/+QT8h9boBfnj9zCeQrndftTCWDVHSg+K5gTdCG4rzsR6PSbkLY7 bokz1uHQfsny/c+hEJVIIMaRbY9pvJtQQnFaXb4zfK9UX66x08+av7ePnsJOvtj6Nr0N MFw3WllwF98GwxIaBSIRQTy3q5K1XZ1cY8/xT/uBVUlQMrZoaUO+BnRHRdVKG36GYgPF pdzvB3BB0cxhCBwf5INN3w2OoYePSBcPJKQ9+IFwmuZBVM1XM3QFGLzTn7egjrg812zV Xo9j8r8BJ+aMxSLmBFXmHY89s8CqMGjSX7k8Qh1qR0ztZWgJkwtlcf7f+Q9w+bEGivei uZNg== Received: by 10.50.187.197 with SMTP id fu5mr6630410igc.70.1352709023227; Mon, 12 Nov 2012 00:30:23 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.67.148 with SMTP id n20csp328346igt; Mon, 12 Nov 2012 00:30:22 -0800 (PST) Received: by 10.204.148.89 with SMTP id o25mr6745140bkv.11.1352709021566; Mon, 12 Nov 2012 00:30:21 -0800 (PST) Received: from mombin.canonical.com (mombin.canonical.com. [91.189.95.16]) by mx.google.com with ESMTP id gc19si10646856bkc.108.2012.11.12.00.30.19; Mon, 12 Nov 2012 00:30:21 -0800 (PST) Received-SPF: neutral (google.com: 91.189.95.16 is neither permitted nor denied by best guess record for domain of linaro-mm-sig-bounces@lists.linaro.org) client-ip=91.189.95.16; Authentication-Results: mx.google.com; spf=neutral (google.com: 91.189.95.16 is neither permitted nor denied by best guess record for domain of linaro-mm-sig-bounces@lists.linaro.org) smtp.mail=linaro-mm-sig-bounces@lists.linaro.org Received: from localhost ([127.0.0.1] helo=mombin.canonical.com) by mombin.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1TXpPN-00075G-1L; Mon, 12 Nov 2012 08:30:17 +0000 Received: from mailout3.samsung.com ([203.254.224.33]) by mombin.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1TXpPL-000753-60 for linaro-mm-sig@lists.linaro.org; Mon, 12 Nov 2012 08:30:15 +0000 Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MDD008QZ8Y19BS0@mailout3.samsung.com> for linaro-mm-sig@lists.linaro.org; Mon, 12 Nov 2012 17:30:11 +0900 (KST) X-AuditID: cbfee61a-b7fa66d0000004cf-40-50a0b393cc43 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 46.7B.01231.393B0A05; Mon, 12 Nov 2012 17:30:11 +0900 (KST) Received: from localhost.localdomain ([106.116.147.30]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MDD00LHE8Y0C190@mmp2.samsung.com> for linaro-mm-sig@lists.linaro.org; Mon, 12 Nov 2012 17:30:11 +0900 (KST) From: Marek Szyprowski To: linux-mm@kvack.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org Date: Mon, 12 Nov 2012 09:29:49 +0100 Message-id: <1352708989-25359-1-git-send-email-m.szyprowski@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrFJMWRmVeSWpSXmKPExsVy+t9jQd3JmxcEGFxbpG3x5cpDJgdGj9v/ HjMHMEZx2aSk5mSWpRbp2yVwZWz41M1U0M9RsfrsfrYGxgdsXYycHBICJhJnP79khLDFJC7c Ww8U5+IQEpjOKPF3bgcrSEJIYBWTxORXMSA2m4ChRNfbLrBmEYEwiT+N21hBGpgFrjJJXLn5 kBkkISzgLtF2tIsFxGYRUJX4tKkPbAOvgIfE4xd3gJo5gLYpSMyZZDOBkXsBI8MqRtHUguSC 4qT0XEO94sTc4tK8dL3k/NxNjGAfPpPawbiyweIQowAHoxIPr2TgggAh1sSy4srcQ4wSHMxK IrzTRIBCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeZs9UgKEBNITS1KzU1MLUotgskwcnFINjMnP ezr7/FvXTlrfwR1lJebOfvJLzMVHdqLPFiyQf//aUeuNVfCKrTdWd07NNJdMWMZ8j69DL27t 60q7BQsr5VYHszB/bo3xnehUz7rhoLHzvidSnwT2bmNWF5wns/RkrlPFjkRRvvXSYlvcdZK3 f1XbWhb/f18ST8e8Uufnl99/v6Gi/rhrqhJLcUaioRZzUXEiAMoLZQTdAQAA Cc: SeongHwan Yoon , Bartlomiej Zolnierkiewicz , Mel Gorman , Michal Nazarewicz , Minchan Kim , Kyungmin Park , Andrew Morton Subject: [Linaro-mm-sig] [PATCH] mm: use migrate_prep() instead of migrate_prep_local() X-BeenThere: linaro-mm-sig@lists.linaro.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Unified memory management interest group." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linaro-mm-sig-bounces@lists.linaro.org Errors-To: linaro-mm-sig-bounces@lists.linaro.org X-Gm-Message-State: ALoCoQloRWBKx3+WcaNytbpKDUl4fEcdg70Cd2LoIKnL8uRY/nokxn62Xo0YeZlmCSR530bV/lXp __alloc_contig_migrate_range() should use all possible ways to get all the pages migrated from the given memory range, so pruning per-cpu lru lists for all CPUs is required, regadless the cost of such operation. Otherwise some pages which got stuck at per-cpu lru list might get missed by migration procedure causing the contiguous allocation to fail. Reported-by: SeongHwan Yoon Signed-off-by: Marek Szyprowski Signed-off-by: Kyungmin Park --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 1bfe2b0..fcb9719 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -5677,7 +5677,7 @@ static int __alloc_contig_migrate_range(struct compact_control *cc, unsigned int tries = 0; int ret = 0; - migrate_prep_local(); + migrate_prep(); while (pfn < end || !list_empty(&cc->migratepages)) { if (fatal_signal_pending(current)) {