From patchwork Fri Mar 31 09:26:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 668848 Delivered-To: patches@linaro.org Received: by 2002:a5d:4d08:0:0:0:0:0 with SMTP id z8csp382338wrt; Fri, 31 Mar 2023 02:28:19 -0700 (PDT) X-Google-Smtp-Source: AK7set8u5PmJXUL+oSZbcnuO8lpggQctHa84AQluNcpp0lFaFvOgE6xrTVleXi3S9584cZYWv1lm X-Received: by 2002:a05:622a:19a6:b0:3d6:43fc:2a52 with SMTP id u38-20020a05622a19a600b003d643fc2a52mr44828277qtc.42.1680254899713; Fri, 31 Mar 2023 02:28:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680254899; cv=none; d=google.com; s=arc-20160816; b=w4yJXG+DmvS/1vRPaGEsmGrJiHyxP2z+GSeRO8Oe7gyS7t4w2aQQfFRDj50fCVMs0s negloA/9kYXp2qSOWMFKWEbv9hfnGy+ja9DLnE3beP0zMjv4ZnUp4OjiuHbeXjY6A5Fz IusTs6lLZZvODVq3ZDZHnynHT5XLIOro8et8kEv0Hss+4sQhs4E0oZRBQ9773xBlMp2/ ohgPy4TKUctmG5oKywSPkNOZpjwue8HBsLQl6Camc12v12jdMWLpfS8CsBdwyq13IaIh 6sVYLh0rj6+zzGg4GH1+RL39i5DSN7xax9FMS3hfSYCqBGr3B18MLV28YevEJ1Cn7vWc NBrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:list-unsubscribe:list-subscribe:list-post :list-owner:list-help:list-archive:archived-at:list-id:subject :precedence:cc:message-id-hash:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=+QZ8e3YbwL0OTRjQMclqGuf15AhcDneDsLlI5KXcvH8=; b=yDcjDOTVDyB6ItTJ2Kp3SclTpdxfl4whhTn1jlksek6W4ph+MIrcnu4eAAUl4CaMAM wIgmQa573FQSJlPOi82vsx1M/V3Wasc+g87oAefXgtItQtx2i+pZM18HJJ+IYOspehbA caiNDNLrODJPsKWNpI0ej1x2zZikjIp2X2ByrMiRla1YlhO5mQhV0YwhudT70LKsnUOm V29uyxXJl5aYFR7TDPX99ZmRo2H4Vwh/w4konce+3E4kvc/1pM4MKbwPd8CfoYgFGLbS 3G9nTScHwpA2WnOZaN7D3o8oPADDS38F6MDn1eq/vPd5wV5zCbXWs8s4UgM7hl7/uFZ3 ddow== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=GXZqS0n3; spf=pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) smtp.mailfrom="linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lists.linaro.org (lists.linaro.org. [3.208.193.21]) by mx.google.com with ESMTPS id r11-20020ac85c8b000000b003e4e6681278si1247764qta.18.2023.03.31.02.28.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Mar 2023 02:28:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) client-ip=3.208.193.21; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=GXZqS0n3; spf=pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) smtp.mailfrom="linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from lists.linaro.org (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 5929C3F581 for ; Fri, 31 Mar 2023 09:28:19 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lists.linaro.org (Postfix) with ESMTPS id 33B7D3F598 for ; Fri, 31 Mar 2023 09:27:03 +0000 (UTC) Authentication-Results: lists.linaro.org; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GXZqS0n3; spf=pass (lists.linaro.org: domain of lee@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=lee@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5C6A5B82DAE; Fri, 31 Mar 2023 09:27:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49991C433D2; Fri, 31 Mar 2023 09:26:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680254821; bh=jDg9+LbHBtf4EjDGettNNrjuuWGpis85RdG5aiSWD5I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GXZqS0n3DzEGbnhm/VuFgz81qhHhbB8LYxa+QNGAK8aCAKZfMDsCONopQkz8C59WJ g+wiN/k7a9am8lJiu10gLlcLLq0pkMCDKLjQUF9kQV0/UzS6ZgKXtvMjql8GREQSDj JLo/9iiWbrsgQvqctkGbq4tBXdPctKCLSWoKS7w3/uO3PUHxqYSQvycxPNZIa4dQhe ETiYPunbpUdXC1m0XmEaMVB4f1zGu8ws65dTCpINbY9ntnfw+Kmw5iIWHAZGE0U+Rh /HgCOd+PyR8UBGJPb2K5PUtZV95W4tDsGUbWREGq14UCvHYGepF2JwZpMrlSLkVwu6 P1tN1uJeoFwmA== From: Lee Jones To: lee@kernel.org Date: Fri, 31 Mar 2023 10:26:04 +0100 Message-Id: <20230331092607.700644-17-lee@kernel.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230331092607.700644-1-lee@kernel.org> References: <20230331092607.700644-1-lee@kernel.org> MIME-Version: 1.0 X-Rspamd-Action: no action X-Rspamd-Server: lists.linaro.org X-Rspamd-Queue-Id: 33B7D3F598 X-Spamd-Bar: ----- X-Spamd-Result: default: False [-5.00 / 15.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; RCVD_DKIM_ARC_DNSWL_HI(-1.00)[]; RCVD_IN_DNSWL_HI(-1.00)[52.25.139.140:received,145.40.68.75:from]; DMARC_POLICY_ALLOW(-0.50)[kernel.org,none]; R_SPF_ALLOW(-0.20)[+a:ams.source.kernel.org:c]; R_DKIM_ALLOW(-0.20)[kernel.org:s=k20201202]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM(-0.00)[-1.000]; ASN(0.00)[asn:54825, ipnet:145.40.68.0/24, country:US]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_CC(0.00)[vger.kernel.org,linux.intel.com,intel.com,gmail.com,ffwll.ch,linaro.org,amd.com,lists.freedesktop.org,lists.linaro.org]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[kernel.org:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWELVE(0.00)[14]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Message-ID-Hash: AI5KFHJGUNIZOV3CLK2GOPVBBIPZ23E2 X-Message-ID-Hash: AI5KFHJGUNIZOV3CLK2GOPVBBIPZ23E2 X-MailFrom: lee@kernel.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Daniel Vetter , Sumit Semwal , =?utf-8?q?Christian_K=C3=B6nig?= , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org X-Mailman-Version: 3.3.5 Precedence: list Subject: [Linaro-mm-sig] [PATCH 16/19] drm/i915/i915_vma: Provide one missing param and demote another non-kerneldoc header List-Id: "Unified memory management interest group." Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/i915_vma.c:756: warning: Function parameter or member 'ww' not described in 'i915_vma_insert' drivers/gpu/drm/i915/i915_vma.c:1744: warning: Function parameter or member 'vma' not described in 'i915_vma_destroy_locked' Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/i915/i915_vma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c index f51fd9fd4c89c..20a44788999e5 100644 --- a/drivers/gpu/drm/i915/i915_vma.c +++ b/drivers/gpu/drm/i915/i915_vma.c @@ -739,6 +739,7 @@ bool i915_gem_valid_gtt_space(struct i915_vma *vma, unsigned long color) /** * i915_vma_insert - finds a slot for the vma in its address space * @vma: the vma + * @ww: An optional struct i915_gem_ww_ctx * @size: requested size in bytes (can be larger than the VMA) * @alignment: required alignment * @flags: mask of PIN_* flags to use @@ -1714,7 +1715,7 @@ static void release_references(struct i915_vma *vma, struct intel_gt *gt, i915_vma_free(vma); } -/** +/* * i915_vma_destroy_locked - Remove all weak reference to the vma and put * the initial reference. *