From patchwork Fri Jun 9 08:17:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 690893 Delivered-To: patches@linaro.org Received: by 2002:a5d:4d8a:0:0:0:0:0 with SMTP id b10csp692272wru; Fri, 9 Jun 2023 01:18:28 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ68BIz8NmMYRgzWwsAe/A0Gsp6loptiolnTWqvd6u0PzpPc+zb1LWiqm2YBlrbKBwsvSyTQ X-Received: by 2002:ac8:57c4:0:b0:3f3:9395:671 with SMTP id w4-20020ac857c4000000b003f393950671mr5401829qta.0.1686298708063; Fri, 09 Jun 2023 01:18:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686298708; cv=none; d=google.com; s=arc-20160816; b=tBoOYPvAhf8O+0p666G2ingCgSoPdhJMJbOP66fe64zkpwwKwxu5Yvasl5fzBAJOzC MlesoLIXyHENdcR2BiWGctDVi7DfhFiB0tSMMizmrXn46rQnuHOZ+xULDDKgYFxymHty +eFUgPm0d2Pft3p9rmReTIbQnuw0jPoufEo0G3v8IJmCe4ckX88GyfpMSz2/GZeolowp 0RDxmTXDZNAOGZ9WJDWCLJlBgp4b/FCfke575jBqASE+syHKIkR0gJkl8hJLcGL77vcu Tv2Yr/c4Qo3aEuT4uXWEAsPxTAcONH/puDPNhWB6ooi6xfQQGZ/K3KtyhDKuVYtlYDYQ dKiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:list-unsubscribe:list-subscribe:list-post :list-owner:list-help:list-archive:archived-at:list-id:subject :precedence:cc:message-id-hash:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=CrcHqL88wyyO33gPp56FH6PQOxL+mYiH/9bvg4p8EnM=; b=Aj38Q6Wy6neOqBJgfMax7402G7SMc4ZuO8feXBzbrh9P6P6fGRhZc7cKX4WcVKuHbk anUQPnAAi9HAewn8GfmxeguEOH+uezI0EwM4IqVRf00IKQpXIaX7xcedJRgWyLEQRl8+ f3noO3TwUK4j6NBZzI0SylksjCbyExrn3qVjVM4sL2iGHbEtO3t/heUzIAl4R0wCSILK Of+/S8WN/ITERzKlV+2NN9DGr1wAIPuJqej641GDhgJrLwCreYjdUvZn4frUNrqYWXvA Ogjkej9FMMqFi0r8SmXExqxqlMVTRjbYRKNaN2dtC70MtDijnqTQ4OOK8WmAnTbRTDoe +LOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=cVmvOWAK; spf=pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) smtp.mailfrom="linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lists.linaro.org (lists.linaro.org. [3.208.193.21]) by mx.google.com with ESMTPS id o16-20020a05622a009000b003e4e85115casi1770398qtw.679.2023.06.09.01.18.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jun 2023 01:18:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) client-ip=3.208.193.21; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=cVmvOWAK; spf=pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) smtp.mailfrom="linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from lists.linaro.org (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id B1388413CE for ; Fri, 9 Jun 2023 08:18:27 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lists.linaro.org (Postfix) with ESMTPS id 451A83EF3A for ; Fri, 9 Jun 2023 08:18:23 +0000 (UTC) Authentication-Results: lists.linaro.org; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cVmvOWAK; spf=pass (lists.linaro.org: domain of lee@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=lee@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E68C9654B0; Fri, 9 Jun 2023 08:18:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C945C433D2; Fri, 9 Jun 2023 08:18:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686298702; bh=bV0AjXaMBOwcPgHZlva/QwT1Ny6xhO6iUTwyI835e2A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cVmvOWAKHoSKy8W4/gtTWa2vmeBm71dB7jn1ZBGFZkt9iV5nxTuJ1hFNnfsYsiS/g oD9ijSARaf23ncovhmQiYacLkhDfx/veUHaqtLYH0J705hOluSpXHCySiObjtwS5eX 9bMgQlCjF2E3Ejj6z8N/TtXoZ94MAJxZjXdBkMDjkXJSWTaJfX0k4JlXsDymLUn996 foYeDcypwz1yMgB3H0zt/Ku0Avq17EhTia6d/IMzByP+GP1JCe5xE9uumkIMkHpWUm yTOT6xnI6YKKtz0H8QEan94neI4B736hA/SE97cMpEDLXyUSzChc9X4qPLE1AYj/ly 1rGC7mqgyIB9g== From: Lee Jones To: lee@kernel.org Date: Fri, 9 Jun 2023 09:17:18 +0100 Message-ID: <20230609081732.3842341-16-lee@kernel.org> X-Mailer: git-send-email 2.41.0.162.gfafddb0af9-goog In-Reply-To: <20230609081732.3842341-1-lee@kernel.org> References: <20230609081732.3842341-1-lee@kernel.org> MIME-Version: 1.0 X-Spamd-Result: default: False [-7.00 / 15.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; DMARC_POLICY_ALLOW(-0.50)[kernel.org,none]; R_SPF_ALLOW(-0.20)[+a:dfw.source.kernel.org:c]; R_DKIM_ALLOW(-0.20)[kernel.org:s=k20201202]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM(-0.00)[-1.000]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_CC(0.00)[vger.kernel.org,amd.com,gmail.com,ffwll.ch,linaro.org,lists.freedesktop.org,lists.linaro.org]; ASN(0.00)[asn:54825, ipnet:139.178.80.0/21, country:US]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[kernel.org:+]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWELVE(0.00)[13]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Action: no action X-Rspamd-Server: lists.linaro.org X-Rspamd-Queue-Id: 451A83EF3A X-Spamd-Bar: ------- Message-ID-Hash: LNWSPHN65WRRDZPMOBGDXBU7DWTWDS5B X-Message-ID-Hash: LNWSPHN65WRRDZPMOBGDXBU7DWTWDS5B X-MailFrom: lee@kernel.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: linux-kernel@vger.kernel.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , Daniel Vetter , Sumit Semwal , Stanley Yang , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org X-Mailman-Version: 3.3.5 Precedence: list Subject: [Linaro-mm-sig] [RESEND 15/15] drm/amd/amdgpu/sdma_v6_0: Demote a bunch of half-completed function headers List-Id: "Unified memory management interest group." Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:248: warning: Function parameter or member 'job' not described in 'sdma_v6_0_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:248: warning: Function parameter or member 'flags' not described in 'sdma_v6_0_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:945: warning: Function parameter or member 'timeout' not described in 'sdma_v6_0_ring_test_ib' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1124: warning: Function parameter or member 'ring' not described in 'sdma_v6_0_ring_pad_ib' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1175: warning: Function parameter or member 'vmid' not described in 'sdma_v6_0_ring_emit_vm_flush' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1175: warning: Function parameter or member 'pd_addr' not described in 'sdma_v6_0_ring_emit_vm_flush' Cc: Alex Deucher Cc: "Christian König" Cc: "Pan, Xinhui" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: Stanley Yang Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c index 3b03dda854fdc..8cd7abe74e6c4 100644 --- a/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c @@ -233,7 +233,7 @@ static void sdma_v6_0_ring_insert_nop(struct amdgpu_ring *ring, uint32_t count) amdgpu_ring_write(ring, ring->funcs->nop); } -/** +/* * sdma_v6_0_ring_emit_ib - Schedule an IB on the DMA engine * * @ring: amdgpu ring pointer @@ -936,7 +936,7 @@ static int sdma_v6_0_ring_test_ring(struct amdgpu_ring *ring) return r; } -/** +/* * sdma_v6_0_ring_test_ib - test an IB on the DMA engine * * @ring: amdgpu_ring structure holding ring information @@ -1118,7 +1118,7 @@ static void sdma_v6_0_vm_set_pte_pde(struct amdgpu_ib *ib, ib->ptr[ib->length_dw++] = count - 1; /* number of entries */ } -/** +/* * sdma_v6_0_ring_pad_ib - pad the IB * @ib: indirect buffer to fill with padding * @ring: amdgpu ring pointer @@ -1167,7 +1167,7 @@ static void sdma_v6_0_ring_emit_pipeline_sync(struct amdgpu_ring *ring) SDMA_PKT_POLL_REGMEM_DW5_INTERVAL(4)); /* retry count, poll interval */ } -/** +/* * sdma_v6_0_ring_emit_vm_flush - vm flush using sDMA * * @ring: amdgpu_ring pointer