mbox series

[v4,0/3] ACPI: PMIC: a small refactoring

Message ID 20240606205712.3187675-1-andriy.shevchenko@linux.intel.com
Headers show
Series ACPI: PMIC: a small refactoring | expand

Message

Andy Shevchenko June 6, 2024, 8:54 p.m. UTC 
Use sizeof(), dev_err()/dev_warn(), and regmap bulk read
where it makes sense.

In v4:
- dropped controversial changes (Hans)

Andy Shevchenko (3):
  ACPI: PMIC: Use sizeof() instead of hard coded value
  ACPI: PMIC: Convert pr_*() to dev_*() printing macros
  ACPI: PMIC: Replace open coded be16_to_cpu()

 drivers/acpi/pmic/intel_pmic_chtdc_ti.c | 13 ++++++++-----
 drivers/acpi/pmic/intel_pmic_chtwc.c    |  5 +++--
 drivers/acpi/pmic/intel_pmic_xpower.c   |  7 ++++---
 3 files changed, 15 insertions(+), 10 deletions(-)

Comments

Hans de Goede June 7, 2024, 9:05 a.m. UTC | #1 
Hi,

On 6/6/24 10:54 PM, Andy Shevchenko wrote:
> Use sizeof(), dev_err()/dev_warn(), and regmap bulk read
> where it makes sense.
> 
> In v4:
> - dropped controversial changes (Hans)

Thanks, the whole series looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

for the series.

Regards,

Hans




> 
> Andy Shevchenko (3):
>   ACPI: PMIC: Use sizeof() instead of hard coded value
>   ACPI: PMIC: Convert pr_*() to dev_*() printing macros
>   ACPI: PMIC: Replace open coded be16_to_cpu()
> 
>  drivers/acpi/pmic/intel_pmic_chtdc_ti.c | 13 ++++++++-----
>  drivers/acpi/pmic/intel_pmic_chtwc.c    |  5 +++--
>  drivers/acpi/pmic/intel_pmic_xpower.c   |  7 ++++---
>  3 files changed, 15 insertions(+), 10 deletions(-)
>
Rafael J. Wysocki June 13, 2024, 7:21 p.m. UTC | #2 
On Fri, Jun 7, 2024 at 11:05 AM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 6/6/24 10:54 PM, Andy Shevchenko wrote:
> > Use sizeof(), dev_err()/dev_warn(), and regmap bulk read
> > where it makes sense.
> >
> > In v4:
> > - dropped controversial changes (Hans)
>
> Thanks, the whole series looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
> for the series.

All of the patches in the series applied as 6.11 material, thanks!