From patchwork Thu Sep 2 02:55:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saravana Kannan X-Patchwork-Id: 506608 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AAD9C432BE for ; Thu, 2 Sep 2021 02:55:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 13521603E9 for ; Thu, 2 Sep 2021 02:55:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243534AbhIBC4m (ORCPT ); Wed, 1 Sep 2021 22:56:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243377AbhIBC4f (ORCPT ); Wed, 1 Sep 2021 22:56:35 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9263C061764 for ; Wed, 1 Sep 2021 19:55:37 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id u1-20020a25ab01000000b0059949024617so692091ybi.17 for ; Wed, 01 Sep 2021 19:55:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=tjSyGojTOT8uYCifLvLdr4amA8l8CDhQi4qAmFSjHg8=; b=NUaF4WJ6oZa5lpk/IiiIJ0R3QbFs2N3ApjmoemgvLZkF2vVGNK1ttkWqATbJVTg2R3 1dR7jf0TtWVEkcENrRJqt2NFC3IYu4Uufevgq2aM1OzOtkhKjbpj62a59O19dplK+5NL r8tQw626ubHYPXeRUJafN9ubJQYNkXglCC/UgrWI/SE8fzmhwKoLS5o6AZQ4JUv6cjX8 Ax4/og6p55XQKqEb2zj76gPWC/xfNSvaXugCuG4CtquiuhC2axyCuVlAlwElb3bJRqBd ciqf8Li7nDtv+42zKvi40yvQ6W3Ar2obFSY4LUhptC/stQU1TfsLAGg2FtBrUgFFX0QN HWcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=tjSyGojTOT8uYCifLvLdr4amA8l8CDhQi4qAmFSjHg8=; b=E6+k8XkINmrh8adL2VrjYrJoxcgS6hjHPUIQI3k7k6fKmqzu4o8r9eXoE9GGtYoe3Q FtQU4XdraUoqt+EKepoboXkLnrJNFxVu2z1ZAqd3R2j+6yre2ZinYtRaE48shu3z0FvH 8lWZyOSNuX6elwlle8HBam4jLZR9NRXjyZSK+1/U0LkbbGrrM6ez8NzuROMRJooBumxK b9siE5iEuJX7EKL+eRmXkPzcsYOyQYMbnzAsyVWs9V801ne892RFGbj5IPLr6/ygKETY SHe6ftwGe+SWMvP+L31jIm3pqgteM/7YdbDQpmJCFA35AJYvAIvonF3qFcXyfz9ZVbEE 2YlA== X-Gm-Message-State: AOAM5327//gFhq1+3jmpL1sUzC5cFYqEUsF2p/j59X6Un1LayHmTABoh X4rgy2+XM0zAbc59bE99+3kHcxLeOAGCUdw= X-Google-Smtp-Source: ABdhPJyc1/FZExAbR1nIydLj5ad1RBb0+ykfyYU2JXEXQOtJcQqi7SJtFMPOeSkQkh9TiI23NXiJ6yeOth8BWIk= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:17e:f0b7:5862:e47d]) (user=saravanak job=sendgmr) by 2002:a25:2142:: with SMTP id h63mr1586569ybh.70.1630551336984; Wed, 01 Sep 2021 19:55:36 -0700 (PDT) Date: Wed, 1 Sep 2021 19:55:27 -0700 In-Reply-To: <20210902025528.1017391-1-saravanak@google.com> Message-Id: <20210902025528.1017391-3-saravanak@google.com> Mime-Version: 1.0 References: <20210902025528.1017391-1-saravanak@google.com> X-Mailer: git-send-email 2.33.0.259.gc128427fd7-goog Subject: [PATCH v1 2/2] of: platform: Mark bus devices nodes with FWNODE_FLAG_NEVER_PROBES From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Rob Herring , Frank Rowand , Len Brown Cc: Saravana Kannan , Ulf Hansson , kernel-team@android.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-acpi@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org We don't want fw_devlink creating device links for bus devices as they'll never probe. So mark those device node with this flag. Signed-off-by: Saravana Kannan --- drivers/of/platform.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/of/platform.c b/drivers/of/platform.c index 74afbb7a4f5e..42b3936d204a 100644 --- a/drivers/of/platform.c +++ b/drivers/of/platform.c @@ -392,6 +392,22 @@ static int of_platform_bus_create(struct device_node *bus, if (!dev || !of_match_node(matches, bus)) return 0; + /* + * If the bus node has only one compatible string value and it has + * matched as a bus node, it's never going to get probed by a device + * driver. So flag it as such so that fw_devlink knows not to create + * device links with this device. + * + * This doesn't catch all devices that'll never probe, but this is good + * enough for now. + * + * This doesn't really work for PPC because of how it uses + * of_platform_bus_probe() to add normal devices. So ignore PPC cases. + */ + if (!IS_ENABLED(CONFIG_PPC) && + of_property_count_strings(bus, "compatible") == 1) + bus->fwnode.flags |= FWNODE_FLAG_NOT_DEVICE; + for_each_child_of_node(bus, child) { pr_debug(" create child: %pOF\n", child); rc = of_platform_bus_create(child, matches, lookup, &dev->dev, strict);