| Message ID | 20230130182225.2471414-23-sunilvl@ventanamicro.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add basic ACPI support for RISC-V | expand |
Hey Sunil, Two quick comments while I think of them.. On Mon, Jan 30, 2023 at 11:52:23PM +0530, Sunil V L wrote: > RISC-V: ACPI: Enable ACPI in defconfig btw, about half of this series redundantly puts "ACPI:" or "RISC-V: ACPI:" into $subject. None of commits that mention ACPI after the last : should mention ACPI in the prefix IMO, it's just noise. For example, this one should be something like: RISC-V: enable ACPI in defconfig > Add support to build ACPI subsystem in defconfig. > > Signed-off-by: Sunil V L <sunilvl@ventanamicro.com> > --- > arch/riscv/configs/defconfig | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig > index 128dcf4c0814..8ce06fb0dde8 100644 > --- a/arch/riscv/configs/defconfig > +++ b/arch/riscv/configs/defconfig > @@ -218,3 +218,7 @@ CONFIG_RCU_EQS_DEBUG=y > # CONFIG_FTRACE is not set > # CONFIG_RUNTIME_TESTING_MENU is not set > CONFIG_MEMTEST=y > +CONFIG_ARCH_SUPPORTS_ACPI=y This needs to go into the arch Kconfig file, where it will be selected. Check what arm64 does if you are not sure what I mean. Hopefully I'll get a chance to look at the rest of this this week sometime, Conor.
Hi Conor, On Mon, Jan 30, 2023 at 11:47:35PM +0000, Conor Dooley wrote: > Hey Sunil, > > Two quick comments while I think of them.. > Sure. Thank you! > On Mon, Jan 30, 2023 at 11:52:23PM +0530, Sunil V L wrote: > > RISC-V: ACPI: Enable ACPI in defconfig > > btw, about half of this series redundantly puts "ACPI:" or "RISC-V: > ACPI:" into $subject. None of commits that mention ACPI after the last : > should mention ACPI in the prefix IMO, it's just noise. > > For example, this one should be something like: > RISC-V: enable ACPI in defconfig > I agree. Will update in the next version. I added ACPI in begining so that I could quickly identify them along with other patches in my branch. > > Add support to build ACPI subsystem in defconfig. > > > > Signed-off-by: Sunil V L <sunilvl@ventanamicro.com> > > --- > > arch/riscv/configs/defconfig | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig > > index 128dcf4c0814..8ce06fb0dde8 100644 > > --- a/arch/riscv/configs/defconfig > > +++ b/arch/riscv/configs/defconfig > > @@ -218,3 +218,7 @@ CONFIG_RCU_EQS_DEBUG=y > > # CONFIG_FTRACE is not set > > # CONFIG_RUNTIME_TESTING_MENU is not set > > CONFIG_MEMTEST=y > > +CONFIG_ARCH_SUPPORTS_ACPI=y > > This needs to go into the arch Kconfig file, where it will be selected. > Check what arm64 does if you are not sure what I mean. > Yes, I have added in "[PATCH 07/24] RISC-V: ACPI: Enable ACPI build infrastructure". But forgot to remove here. Thanks!. Will update it when I send next revision. > Hopefully I'll get a chance to look at the rest of this this week > sometime, > Conor. > Thanks! Sunil
diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig index 128dcf4c0814..8ce06fb0dde8 100644 --- a/arch/riscv/configs/defconfig +++ b/arch/riscv/configs/defconfig @@ -218,3 +218,7 @@ CONFIG_RCU_EQS_DEBUG=y # CONFIG_FTRACE is not set # CONFIG_RUNTIME_TESTING_MENU is not set CONFIG_MEMTEST=y +CONFIG_ARCH_SUPPORTS_ACPI=y +CONFIG_ACPI=y +CONFIG_ACPI_MCFG=y +# CONFIG_PCI_QUIRKS is not set
Add support to build ACPI subsystem in defconfig. Signed-off-by: Sunil V L <sunilvl@ventanamicro.com> --- arch/riscv/configs/defconfig | 4 ++++ 1 file changed, 4 insertions(+)