From patchwork Mon Nov 4 08:04:56 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 21321 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oa0-f71.google.com (mail-oa0-f71.google.com [209.85.219.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 5556825B39 for ; Mon, 4 Nov 2013 08:05:11 +0000 (UTC) Received: by mail-oa0-f71.google.com with SMTP id j6sf22122790oag.2 for ; Mon, 04 Nov 2013 00:05:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=dL8k6dICorJiC4OIz35bm7tOQAeO1d9LuSN0yzGtFEg=; b=hhprtbhL9sw44z5bQp+FRBpJGSlX9ot6F3xYIXSJfHDMsXJ12BQFS+W8e2+/HpO1k3 7BleUaHydeBavPF7TWJzcaPyMVl9jDMXCgpCn4Ct2h9QatYemmzCzNcoflG5bV0+lvvN PCts1rcount7ChRVmavcd//CJsEqitaDL1VTnfCanWjCkdMGMuxPmyEZhRp/hA1AYAq1 ATCEgeks6d1Ut47wl3mlSDKHdkS8hZDAGPpmqZmf1ekjdpp4zp6eyhxBaFZh3GGR6oVH 0PZLCne24MWhDrL2HwzhLSob6h/tW0LLti+mebMDNGcmu/Kd6n3G3f6uSEaFoULP0Kku 7slg== X-Gm-Message-State: ALoCoQn/sETg27TUMHoYvRqEfM5ZSjMSYTKKJIxlmcx1baF6U7kMGefdLVfhrCspURoKzSUtpRh+ X-Received: by 10.43.44.6 with SMTP id ue6mr4721951icb.11.1383552310407; Mon, 04 Nov 2013 00:05:10 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.132.9 with SMTP id oq9ls1783542qeb.38.gmail; Mon, 04 Nov 2013 00:05:10 -0800 (PST) X-Received: by 10.220.144.18 with SMTP id x18mr10571471vcu.15.1383552310281; Mon, 04 Nov 2013 00:05:10 -0800 (PST) Received: from mail-vc0-f174.google.com (mail-vc0-f174.google.com [209.85.220.174]) by mx.google.com with ESMTPS id h7si3535336vee.33.2013.11.04.00.05.10 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 04 Nov 2013 00:05:10 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.174 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.174; Received: by mail-vc0-f174.google.com with SMTP id ld13so4425232vcb.33 for ; Mon, 04 Nov 2013 00:05:10 -0800 (PST) X-Received: by 10.220.164.202 with SMTP id f10mr765125vcy.25.1383552310188; Mon, 04 Nov 2013 00:05:10 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp115955vcz; Mon, 4 Nov 2013 00:05:09 -0800 (PST) X-Received: by 10.194.63.228 with SMTP id j4mr3963476wjs.34.1383552309377; Mon, 04 Nov 2013 00:05:09 -0800 (PST) Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by mx.google.com with ESMTPS id w8si173668wib.85.2013.11.04.00.05.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 04 Nov 2013 00:05:09 -0800 (PST) Received-SPF: neutral (google.com: 74.125.82.43 is neither permitted nor denied by best guess record for domain of linus.walleij@linaro.org) client-ip=74.125.82.43; Received: by mail-wg0-f43.google.com with SMTP id b13so1690817wgh.34 for ; Mon, 04 Nov 2013 00:05:08 -0800 (PST) X-Received: by 10.180.93.166 with SMTP id cv6mr11114415wib.37.1383552308814; Mon, 04 Nov 2013 00:05:08 -0800 (PST) Received: from localhost.localdomain ([85.235.11.236]) by mx.google.com with ESMTPSA id q3sm1382679wib.5.2013.11.04.00.05.07 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Nov 2013 00:05:07 -0800 (PST) From: Linus Walleij To: arm@kernel.org Cc: linux-arm-kernel@lists.infradead.org, Linus Walleij Subject: [PATCH] ARM: footbridge: fix build warning Date: Mon, 4 Nov 2013 09:04:56 +0100 Message-Id: <1383552296-16275-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 1.8.3.1 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: linus.walleij@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.174 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The raw spinlock in the netwinder GPIO implementation was using non-raw accessors, fix this warning from the autobuilder: arch/arm/mach-footbridge/netwinder-hw.c:695:2: warning: passing argument 1 of 'spinlock_check' from incompatible pointer type [enabled by default] arch/arm/mach-footbridge/netwinder-hw.c:702:2: warning: passing argument 1 of 'spin_unlock_irqrestore' from incompatible pointer type [enabled by default] arch/arm/mach-footbridge/netwinder-hw.c:712:2: warning: passing argument 1 of 'spinlock_check' from incompatible pointer type [enabled by default] arch/arm/mach-footbridge/netwinder-hw.c:714:2: warning: passing argument 1 of 'spin_unlock_irqrestore' from incompatible pointer type [enabled by default] Signed-off-by: Linus Walleij --- ARM SoC folks: please apply this directly to fixes. --- arch/arm/mach-footbridge/netwinder-hw.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-footbridge/netwinder-hw.c b/arch/arm/mach-footbridge/netwinder-hw.c index 1fd2cf097e30..eb1fa5c84723 100644 --- a/arch/arm/mach-footbridge/netwinder-hw.c +++ b/arch/arm/mach-footbridge/netwinder-hw.c @@ -692,14 +692,14 @@ static void netwinder_led_set(struct led_classdev *cdev, unsigned long flags; u32 reg; - spin_lock_irqsave(&nw_gpio_lock, flags); + raw_spin_lock_irqsave(&nw_gpio_lock, flags); reg = nw_gpio_read(); if (b != LED_OFF) reg &= ~led->mask; else reg |= led->mask; nw_gpio_modify_op(led->mask, reg); - spin_unlock_irqrestore(&nw_gpio_lock, flags); + raw_spin_unlock_irqrestore(&nw_gpio_lock, flags); } static enum led_brightness netwinder_led_get(struct led_classdev *cdev) @@ -709,9 +709,9 @@ static enum led_brightness netwinder_led_get(struct led_classdev *cdev) unsigned long flags; u32 reg; - spin_lock_irqsave(&nw_gpio_lock, flags); + raw_spin_lock_irqsave(&nw_gpio_lock, flags); reg = nw_gpio_read(); - spin_unlock_irqrestore(&nw_gpio_lock, flags); + raw_spin_unlock_irqrestore(&nw_gpio_lock, flags); return (reg & led->mask) ? LED_OFF : LED_FULL; }