From patchwork Tue Jan 7 18:27:25 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 22921 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ig0-f198.google.com (mail-ig0-f198.google.com [209.85.213.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 3C4B1216D9 for ; Tue, 7 Jan 2014 18:27:38 +0000 (UTC) Received: by mail-ig0-f198.google.com with SMTP id ut6sf4223987igb.1 for ; Tue, 07 Jan 2014 10:27:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe:content-type:content-transfer-encoding; bh=8Gy7rwPrrmkfUb8PYbeLz8e7vAyKGnyZCxENQP8WtVk=; b=KjlReY/TwqG2kJg1/vHFMFS8/9Tqc8IAEKDLS5OgEAI002dahmRYWiHoAyRBlpYE49 dZzHGdvv7A7iHAuG7Z4dZ37mk3QlIyqJa09VWLSjpHKIyLuVoONIB3AlL8ErmQABxE9U eoonOXTu+wuJ5/evinytIon5owiVk/oP9hFfXStCdmB01QHmiSCbP2DGWdA6Dclmf/b7 wZPmOrWbneQ1CbYQSMWoi4SEV9k6QXbJrfOJY3D5f92wi2BAwzcP87PbHDcH0OqcA42G 6QKyVJDbwVqKC3nbGCXgwsEDIMB0207RGrZ1nlPbiv2ITDUFO19FOQ1o+Ni1tNYFZ3SC R2UQ== X-Gm-Message-State: ALoCoQnSGQh7JZF6gPrFRAUuwIBPuZxFfa30rZIdNHR4NhE8QRdYEG2L1XG2NFGjBm9KxzRZJT3E X-Received: by 10.50.112.10 with SMTP id im10mr6842955igb.1.1389119257519; Tue, 07 Jan 2014 10:27:37 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.38.36 with SMTP id d4ls240247qek.7.gmail; Tue, 07 Jan 2014 10:27:37 -0800 (PST) X-Received: by 10.58.255.233 with SMTP id at9mr12414124ved.20.1389119257398; Tue, 07 Jan 2014 10:27:37 -0800 (PST) Received: from mail-ve0-f170.google.com (mail-ve0-f170.google.com [209.85.128.170]) by mx.google.com with ESMTPS id xb5si426923vdc.107.2014.01.07.10.27.37 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 07 Jan 2014 10:27:37 -0800 (PST) Received-SPF: neutral (google.com: 209.85.128.170 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.170; Received: by mail-ve0-f170.google.com with SMTP id oy12so431478veb.29 for ; Tue, 07 Jan 2014 10:27:37 -0800 (PST) X-Received: by 10.58.146.5 with SMTP id sy5mr4482878veb.43.1389119257229; Tue, 07 Jan 2014 10:27:37 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.59.13.131 with SMTP id ey3csp176586ved; Tue, 7 Jan 2014 10:27:36 -0800 (PST) X-Received: by 10.194.219.232 with SMTP id pr8mr17899856wjc.6.1389119256294; Tue, 07 Jan 2014 10:27:36 -0800 (PST) Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by mx.google.com with ESMTPS id je1si1413755wic.5.2014.01.07.10.27.35 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 07 Jan 2014 10:27:36 -0800 (PST) Received-SPF: neutral (google.com: 74.125.82.43 is neither permitted nor denied by best guess record for domain of linus.walleij@linaro.org) client-ip=74.125.82.43; Received: by mail-wg0-f43.google.com with SMTP id k14so505238wgh.22 for ; Tue, 07 Jan 2014 10:27:35 -0800 (PST) X-Received: by 10.195.13.234 with SMTP id fb10mr9210295wjd.50.1389119255847; Tue, 07 Jan 2014 10:27:35 -0800 (PST) Received: from localhost.localdomain ([85.235.11.236]) by mx.google.com with ESMTPSA id po3sm46086711wjc.3.2014.01.07.10.27.33 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Jan 2014 10:27:34 -0800 (PST) From: Linus Walleij To: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Kukjin Kim , Ben Dooks Cc: Linus Walleij , Heiko Stuebner , Tomasz Figa , Sylwester Nawrocki Subject: [PATCH] ARM: s3c24xx: fix build error Date: Tue, 7 Jan 2014 19:27:25 +0100 Message-Id: <1389119245-2167-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: linus.walleij@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.170 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , When enabling device tree on the S3C an additional build bug appears in the Osiris DVS board file: CC arch/arm/mach-s3c24xx/mach-osiris-dvs.o archh/arm/mach-s3c24xx/mach-osiris-dvs.c: In function ‘osiris_dvs_notify’: arch/arm/mach-s3c24xx/mach-osiris-dvs.c:77:4: error: implicit declaration of function ‘S3C2410_GPB’ [-Werror=implicit-function-declaration] gpio_set_value(OSIRIS_GPIO_DVS, 1); ^ Fix this by explicitly including Reported-by: Arnd Bergmann Cc: Kukjin Kim Cc: Heiko Stuebner Cc: Tomasz Figa Cc: Sylwester Nawrocki Cc: Ben Dooks Cc: linux-samsung-soc@vger.kernel.org Signed-off-by: Linus Walleij --- I have tentatively applied this to the GPIO tree so I don't cause build regressions, ACKs are still appreciated from the S3C maintainers. --- arch/arm/mach-s3c24xx/mach-osiris-dvs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-s3c24xx/mach-osiris-dvs.c b/arch/arm/mach-s3c24xx/mach-osiris-dvs.c index 45e74363aaa9..5b8af46c0d6b 100644 --- a/arch/arm/mach-s3c24xx/mach-osiris-dvs.c +++ b/arch/arm/mach-s3c24xx/mach-osiris-dvs.c @@ -16,6 +16,7 @@ #include #include #include +#include #include