From patchwork Wed Sep 24 03:44:44 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Behan Webster X-Patchwork-Id: 37777 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f70.google.com (mail-wg0-f70.google.com [74.125.82.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id B75E020792 for ; Wed, 24 Sep 2014 03:45:00 +0000 (UTC) Received: by mail-wg0-f70.google.com with SMTP id a1sf3126738wgh.5 for ; Tue, 23 Sep 2014 20:44:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=7396VLG99bA7rkpzXn/cKYgSOVLD76CVxAeD8d/+8C8=; b=bnnaEzNDwR+pnoPQISpHQTn4mN1uXgrs5ZP8PZQ+mTJrjEESL6E4YkMbyuXoiD98U3 IQ0PP5HGIVmeWrhiWIJsASV2hDH5zFRDuC6mZ4p8RKTXPL+26/6SpzKzqh6TApeZAxF/ etN9F0wUXVWoFkmz1BBeZNr8MNC0zska9yzXEY71q9tKx0W0tL2mEcqzyL3aZ6UcKKzE ajBa18F8c/lg/ovmtMDgQtGzYpj1Sfd5JHEnDHnpuOneaMOQxdmZUvl9yorQZj3dQKJT bSJ64b1bv+ReRhSGRr1bZDbXpfjionI2Li5QGD2srtC7Pd1nY94IVIcYwJw3wf1grtqP VUxA== X-Gm-Message-State: ALoCoQlm+AwTzdpUypyNWpP022ZCsDIKlJ26DU9WD26BpFjb8cF90NB3vaZRvgBSa5YdIqA/lwSg X-Received: by 10.180.24.72 with SMTP id s8mr1345693wif.1.1411530299833; Tue, 23 Sep 2014 20:44:59 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.21.136 with SMTP id v8ls113108lae.12.gmail; Tue, 23 Sep 2014 20:44:59 -0700 (PDT) X-Received: by 10.152.197.35 with SMTP id ir3mr3653634lac.82.1411530299589; Tue, 23 Sep 2014 20:44:59 -0700 (PDT) Received: from mail-la0-x22c.google.com (mail-la0-x22c.google.com [2a00:1450:4010:c03::22c]) by mx.google.com with ESMTPS id m2si21056830lbp.105.2014.09.23.20.44.59 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 23 Sep 2014 20:44:59 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c03::22c as permitted sender) client-ip=2a00:1450:4010:c03::22c; Received: by mail-la0-f44.google.com with SMTP id q1so9872271lam.17 for ; Tue, 23 Sep 2014 20:44:59 -0700 (PDT) X-Received: by 10.152.42.136 with SMTP id o8mr3417474lal.71.1411530299326; Tue, 23 Sep 2014 20:44:59 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.130.169 with SMTP id of9csp519906lbb; Tue, 23 Sep 2014 20:44:58 -0700 (PDT) X-Received: by 10.67.14.165 with SMTP id fh5mr5561544pad.2.1411530297786; Tue, 23 Sep 2014 20:44:57 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id yo4si24050204pab.117.2014.09.23.20.44.56 for ; Tue, 23 Sep 2014 20:44:57 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755155AbaIXDoz (ORCPT + 27 others); Tue, 23 Sep 2014 23:44:55 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:40135 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751537AbaIXDox (ORCPT ); Tue, 23 Sep 2014 23:44:53 -0400 Received: by mail-pa0-f52.google.com with SMTP id hz1so7736570pad.25 for ; Tue, 23 Sep 2014 20:44:53 -0700 (PDT) X-Received: by 10.68.65.48 with SMTP id u16mr4081927pbs.150.1411530293320; Tue, 23 Sep 2014 20:44:53 -0700 (PDT) Received: from galdor.websterwood.com (S0106dc9fdb80cffd.gv.shawcable.net. [96.50.97.138]) by mx.google.com with ESMTPSA id fm15sm13386972pdb.58.2014.09.23.20.44.50 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 23 Sep 2014 20:44:51 -0700 (PDT) From: Behan Webster To: linux@arm.linux.org.uk, linux@prisktech.co.nz Cc: behanw@converseincode.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] arm, vt8500, LLVMLlinux: Use mcr instead of mcr% for mach-vt8500 Date: Tue, 23 Sep 2014 20:44:44 -0700 Message-Id: <1411530284-28807-1-git-send-email-behanw@converseincode.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Original-Sender: behanw@converseincode.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c03::22c as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=neutral (body hash did not verify) header.i=@ Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The ASM below does not compile with clang and is not the way that the mcr command is used in other parts of the kernel. arch/arm/mach-vt8500/vt8500.c:72:11: error: invalid % escape in inline assembly string asm("mcr%? p15, 0, %0, c7, c0, 4" : : "r" (0)); ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. There are other forms that are supported on different ARM instruction sets but generally the kernel just uses mcr as it is supported in all ARM instruction sets. Signed-off-by: Behan Webster Reviewed-by: Mark Charlebois Acked-by: Will Deacon Acked-by: Arnd Bergmann --- arch/arm/mach-vt8500/vt8500.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-vt8500/vt8500.c b/arch/arm/mach-vt8500/vt8500.c index 2da7be3..3bc0dc9 100644 --- a/arch/arm/mach-vt8500/vt8500.c +++ b/arch/arm/mach-vt8500/vt8500.c @@ -69,7 +69,7 @@ static void vt8500_power_off(void) { local_irq_disable(); writew(5, pmc_base + VT8500_HCR_REG); - asm("mcr%? p15, 0, %0, c7, c0, 4" : : "r" (0)); + asm("mcr p15, 0, %0, c7, c0, 4" : : "r" (0)); } static void __init vt8500_init(void)