From patchwork Tue Dec 9 11:26:07 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoffer Dall X-Patchwork-Id: 42045 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f72.google.com (mail-wg0-f72.google.com [74.125.82.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id EA68A244AC for ; Tue, 9 Dec 2014 11:43:10 +0000 (UTC) Received: by mail-wg0-f72.google.com with SMTP id y19sf313760wgg.11 for ; Tue, 09 Dec 2014 03:43:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:subject:date:message-id :in-reply-to:references:cc:precedence:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:mime-version :content-type:content-transfer-encoding:sender:errors-to :x-original-sender:x-original-authentication-results:mailing-list; bh=3tR7osWPMirymHXpdEWC2UIHsNJw/hGJYvw6yZ0YC94=; b=g7EPbQzcx4B3aKlNmpDznKtJCMA9Qx2JwygkccfaaQamKu/RrFfcbZS0ebNJFbdFy5 vSyuMrTMkJgkp7SfTKfBIqkyh2gLwXwxeSbp10qsnJwoqzPa62qMMCROhShXa0YN2f3N e14g19xiHItp02waRWlSUXd8ma8McN948mtaPBbik94peIYPbSFXrgTvpyOlWSAv4jJs W3WcK1fceqIiOvMOhBZeVlNB+NJC+n0iddWk+iWcSFgLqpUwTkE/x9uJDFYb8AlRsNwC YHXWP7pHysLlsAUAmwLoyO1Hwhqi2RMNt1kc1cENgKiGzrB0jAla5MtgPhua9WT/uwpV l2OA== X-Gm-Message-State: ALoCoQmrqHQ7PsthwoPVcDHHbSoVSTtQBKqmPBFe1OHoAK1U1iDxSDxHyi1w3x5BP264DEcmqLaX X-Received: by 10.112.155.198 with SMTP id vy6mr2902631lbb.7.1418125390120; Tue, 09 Dec 2014 03:43:10 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.153.6.34 with SMTP id cr2ls29683lad.30.gmail; Tue, 09 Dec 2014 03:43:10 -0800 (PST) X-Received: by 10.152.37.100 with SMTP id x4mr21438819laj.22.1418125389982; Tue, 09 Dec 2014 03:43:09 -0800 (PST) Received: from mail-la0-f48.google.com (mail-la0-f48.google.com. [209.85.215.48]) by mx.google.com with ESMTPS id bc1si1045952lbc.80.2014.12.09.03.43.09 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 09 Dec 2014 03:43:09 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.48 as permitted sender) client-ip=209.85.215.48; Received: by mail-la0-f48.google.com with SMTP id gf13so338213lab.35 for ; Tue, 09 Dec 2014 03:43:09 -0800 (PST) X-Received: by 10.153.7.170 with SMTP id dd10mr21137312lad.44.1418125389862; Tue, 09 Dec 2014 03:43:09 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.184.201 with SMTP id ew9csp739680lbc; Tue, 9 Dec 2014 03:43:09 -0800 (PST) X-Received: by 10.70.88.139 with SMTP id bg11mr29849306pdb.167.1418125388056; Tue, 09 Dec 2014 03:43:08 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id rx10si1495463pab.77.2014.12.09.03.43.07 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Dec 2014 03:43:08 -0800 (PST) Received-SPF: none (google.com: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org does not designate permitted sender hosts) client-ip=2001:1868:205::9; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XyJ6J-0006Cx-06; Tue, 09 Dec 2014 11:37:07 +0000 Received: from merlin.infradead.org ([2001:4978:20e::2]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XyIvT-00056W-JD for linux-arm-kernel@bombadil.infradead.org; Tue, 09 Dec 2014 11:25:55 +0000 Received: from mail-la0-f42.google.com ([209.85.215.42]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XyIvS-0003xw-6X for linux-arm-kernel@lists.infradead.org; Tue, 09 Dec 2014 11:25:54 +0000 Received: by mail-la0-f42.google.com with SMTP id gd6so331312lab.1 for ; Tue, 09 Dec 2014 03:25:32 -0800 (PST) X-Received: by 10.153.5.33 with SMTP id cj1mr21807488lad.65.1418124332246; Tue, 09 Dec 2014 03:25:32 -0800 (PST) Received: from localhost.localdomain (188-178-240-98-static.dk.customer.tdc.net. [188.178.240.98]) by mx.google.com with ESMTPSA id w3sm279709law.36.2014.12.09.03.25.30 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 09 Dec 2014 03:25:31 -0800 (PST) From: Christoffer Dall To: Paolo Bonzini , kvm@vger.kernel.org Subject: [GIT PULL 8/9] arm/arm64: vgic: Remove unreachable irq_clear_pending Date: Tue, 9 Dec 2014 12:26:07 +0100 Message-Id: <1418124368-28418-9-git-send-email-christoffer.dall@linaro.org> X-Mailer: git-send-email 2.1.2.330.g565301e.dirty In-Reply-To: <1418124368-28418-1-git-send-email-christoffer.dall@linaro.org> References: <1418124368-28418-1-git-send-email-christoffer.dall@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20141209_062554_390033_CB1CEBF9 X-CRM114-Status: GOOD ( 10.92 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.4.0 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.215.42 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.215.42 listed in wl.mailspike.net] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders Cc: Marc Zyngier , Christoffer Dall , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: christoffer.dall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.48 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 When 'injecting' an edge-triggered interrupt with a falling edge we shouldn't clear the pending state on the distributor. In fact, we don't, because the check in vgic_validate_injection would prevent us from ever reaching this bit of code. Remove the unreachable snippet. Signed-off-by: Christoffer Dall Signed-off-by: Marc Zyngier --- virt/kvm/arm/vgic.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c index 5acf2c9..631a472 100644 --- a/virt/kvm/arm/vgic.c +++ b/virt/kvm/arm/vgic.c @@ -1643,8 +1643,6 @@ static bool vgic_update_irq_pending(struct kvm *kvm, int cpuid, vgic_dist_irq_clear_level(vcpu, irq_num); if (!vgic_dist_irq_soft_pend(vcpu, irq_num)) vgic_dist_irq_clear_pending(vcpu, irq_num); - } else { - vgic_dist_irq_clear_pending(vcpu, irq_num); } ret = false;