From patchwork Tue Jan 13 12:28:53 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 42992 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f69.google.com (mail-wg0-f69.google.com [74.125.82.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 4CA2226CFB for ; Tue, 13 Jan 2015 12:31:15 +0000 (UTC) Received: by mail-wg0-f69.google.com with SMTP id x12sf1531916wgg.0 for ; Tue, 13 Jan 2015 04:31:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:subject:date:message-id:cc :precedence:list-id:list-unsubscribe:list-archive:list-post :list-help:list-subscribe:mime-version:content-type :content-transfer-encoding:sender:errors-to:x-original-sender :x-original-authentication-results:mailing-list; bh=UQnKeLES+h1SA8t9GhY+0MR0ZRkQcnI5wheb7ZPD05A=; b=P4nb6NaMDl/ccF4gWmZH7HfxaVPiYYPE9knZ6hMfYQWDRVFfFpF+AQ06O91UPnlC2R S+pZf5qoeIdjAgiUKmErbLwzNUXr/Yz4MFoz71YRRlO5sktXWvbK3hgi5uugkhhp2sJI dpEy803HOXY5aUuvTm9rD83aaRkhlQpDZZjc67ilslhsgcclOkCUxK5v3b+bn4rAiLNb NKmFqCjNOHPTAHOLod+BqPY76wC/QiVtRTNPrp/DjRDX2MM5zp2KjhszFqooAfpsJcRS /QrlGKEHAaFgml7Q2MugMu3jYz2p/3GdTiFTkYi13XU8tlJFDjhLRG2faQGaOIjpBu6M Bsdw== X-Gm-Message-State: ALoCoQns/Oaw8QpC/i8UKOs9Lio0EsX7Dz1eKqM6/urE1lwXSUYy0PvswDs9LtI4SB4sIwALcSr1 X-Received: by 10.152.170.201 with SMTP id ao9mr288156lac.5.1421152274568; Tue, 13 Jan 2015 04:31:14 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.6.229 with SMTP id e5ls611121laa.105.gmail; Tue, 13 Jan 2015 04:31:14 -0800 (PST) X-Received: by 10.153.6.6 with SMTP id cq6mr42189973lad.23.1421152274419; Tue, 13 Jan 2015 04:31:14 -0800 (PST) Received: from mail-lb0-f177.google.com (mail-lb0-f177.google.com. [209.85.217.177]) by mx.google.com with ESMTPS id jb3si23616374lbc.79.2015.01.13.04.31.14 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 13 Jan 2015 04:31:14 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.177 as permitted sender) client-ip=209.85.217.177; Received: by mail-lb0-f177.google.com with SMTP id b6so2260960lbj.8 for ; Tue, 13 Jan 2015 04:31:14 -0800 (PST) X-Received: by 10.152.45.4 with SMTP id i4mr42255248lam.74.1421152274304; Tue, 13 Jan 2015 04:31:14 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.9.200 with SMTP id c8csp1367421lbb; Tue, 13 Jan 2015 04:31:13 -0800 (PST) X-Received: by 10.66.65.165 with SMTP id y5mr50903784pas.146.1421152272374; Tue, 13 Jan 2015 04:31:12 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id ib10si26886190pbc.96.2015.01.13.04.31.11 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Jan 2015 04:31:12 -0800 (PST) Received-SPF: none (google.com: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org does not designate permitted sender hosts) client-ip=2001:1868:205::9; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YB0bA-0005zT-U0; Tue, 13 Jan 2015 12:29:28 +0000 Received: from mail-wi0-f171.google.com ([209.85.212.171]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YB0b4-0005qC-CH for linux-arm-kernel@lists.infradead.org; Tue, 13 Jan 2015 12:29:23 +0000 Received: by mail-wi0-f171.google.com with SMTP id bs8so20885376wib.4 for ; Tue, 13 Jan 2015 04:29:00 -0800 (PST) X-Received: by 10.194.87.100 with SMTP id w4mr69948301wjz.65.1421152140231; Tue, 13 Jan 2015 04:29:00 -0800 (PST) Received: from ards-macbook-pro.local ([197.130.61.210]) by mx.google.com with ESMTPSA id h13sm14130965wiw.4.2015.01.13.04.28.57 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 13 Jan 2015 04:28:59 -0800 (PST) From: Ard Biesheuvel To: matt.fleming@intel.com, msalter@redhat.com, linux-efi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, leif.lindholm@linaro.org, roy.franz@linaro.org Subject: [PATCH] efi: rtc-efi: mark UIE as unsupported Date: Tue, 13 Jan 2015 12:28:53 +0000 Message-Id: <1421152133-28506-1-git-send-email-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 1.8.3.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150113_042922_620974_AF1A0A7E X-CRM114-Status: UNSURE ( 9.03 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.7 (/) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-0.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.212.171 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.212.171 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders Cc: Ard Biesheuvel X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ard.biesheuvel@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.177 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Tools like hwclock attempt to enable the RTC update interrupt (UIE) to maximize the accuracy of the reported time value. The EFI rtc does not have interrupt capability so this is a pointless exercise to begin with, but the generic RTC framework ends up issuing a SetWakeupTime() Runtime Services call before drawing that conclusion on its own. Instead, we can mark UIE as unsupported at driver probe time. The net result is the same, but without the spurious SetWakeupTime() call. Signed-off-by: Ard Biesheuvel --- drivers/rtc/rtc-efi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/rtc/rtc-efi.c b/drivers/rtc/rtc-efi.c index b37b0c80bd5a..cb989cd00b14 100644 --- a/drivers/rtc/rtc-efi.c +++ b/drivers/rtc/rtc-efi.c @@ -218,6 +218,7 @@ static int __init efi_rtc_probe(struct platform_device *dev) if (IS_ERR(rtc)) return PTR_ERR(rtc); + rtc->uie_unsupported = 1; platform_set_drvdata(dev, rtc); return 0;