From patchwork Sun Jul 20 11:59:48 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 33935 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qc0-f199.google.com (mail-qc0-f199.google.com [209.85.216.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 3F45F202DA for ; Sun, 20 Jul 2014 12:02:09 +0000 (UTC) Received: by mail-qc0-f199.google.com with SMTP id c9sf17783312qcz.6 for ; Sun, 20 Jul 2014 05:02:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:subject:date:message-id :in-reply-to:references:in-reply-to:references:cc:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :mime-version:sender:errors-to:x-original-sender :x-original-authentication-results:mailing-list:content-type :content-transfer-encoding; bh=XvPjrQak3WBNf/LodJ4UbzF4fb48VwyEj5+ceK8pOgw=; b=MYItyvWojJ8iT87v0w+yLmIALGrp+UzD0Py/skxtwhMOvz0x8j5nRWPL4NlLBMm6tX DRDgmWLzLz4maqwOIw0krfzSTCPaEnRL0VN80AJgurkY8Exfi6/mI1Fm2GVzhCKh6yCC eG6KMmwTa/JbM552qgOHBZ2TiHlSAVqg0o+SybvtiG+YhkijmfT2af5p0QbGOBI5yyzr RnwdSZGbuCJcAu4UCiAYphnb7MAEdlKNmmi0nYBZxTh/b3EQ6zKJGKVCZ52tIOahdDlI kxUnRFLazAEKbYD/IcsGMiyrwhEy8cYHD/IV4mgXuFii+KmAtZ16IXqGcTlAv/lZ1N1M 87zA== X-Gm-Message-State: ALoCoQnf5iz6Tw9hOwTD8qkdOpqa7syN0MYToj5rCt22nAgKiHrFDiI4TPlq2BECfWIG4pUHewhh X-Received: by 10.236.164.106 with SMTP id b70mr7767406yhl.1.1405857728874; Sun, 20 Jul 2014 05:02:08 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.51.3 with SMTP id t3ls1531963qga.82.gmail; Sun, 20 Jul 2014 05:02:08 -0700 (PDT) X-Received: by 10.221.38.129 with SMTP id ti1mr9476340vcb.9.1405857728764; Sun, 20 Jul 2014 05:02:08 -0700 (PDT) Received: from mail-vc0-f169.google.com (mail-vc0-f169.google.com [209.85.220.169]) by mx.google.com with ESMTPS id r1si9183441vey.41.2014.07.20.05.02.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 20 Jul 2014 05:02:08 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.169 as permitted sender) client-ip=209.85.220.169; Received: by mail-vc0-f169.google.com with SMTP id hu12so10561113vcb.28 for ; Sun, 20 Jul 2014 05:02:08 -0700 (PDT) X-Received: by 10.52.244.138 with SMTP id xg10mr17404388vdc.40.1405857728542; Sun, 20 Jul 2014 05:02:08 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp37695vcb; Sun, 20 Jul 2014 05:02:08 -0700 (PDT) X-Received: by 10.66.150.228 with SMTP id ul4mr18210115pab.16.1405857727697; Sun, 20 Jul 2014 05:02:07 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id z15si5516062pdj.50.2014.07.20.05.02.07 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 20 Jul 2014 05:02:07 -0700 (PDT) Received-SPF: none (google.com: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org does not designate permitted sender hosts) client-ip=2001:1868:205::9; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1X8pn9-0006ir-Ja; Sun, 20 Jul 2014 12:00:35 +0000 Received: from mail-pa0-f47.google.com ([209.85.220.47]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1X8pn7-0006eq-7G for linux-arm-kernel@lists.infradead.org; Sun, 20 Jul 2014 12:00:33 +0000 Received: by mail-pa0-f47.google.com with SMTP id kx10so7942964pab.20 for ; Sun, 20 Jul 2014 05:00:09 -0700 (PDT) X-Received: by 10.68.194.202 with SMTP id hy10mr7208433pbc.94.1405857609652; Sun, 20 Jul 2014 05:00:09 -0700 (PDT) Received: from localhost ([122.172.242.64]) by mx.google.com with ESMTPSA id qw8sm5089875pab.17.2014.07.20.05.00.05 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 20 Jul 2014 05:00:09 -0700 (PDT) From: Viresh Kumar To: arnd@linaro.org, olof@lixom.net, arm@kernel.org Subject: [PATCH 2/2] PCI: spear: Remove spear13xx_pcie_remove() Date: Sun, 20 Jul 2014 17:29:48 +0530 Message-Id: X-Mailer: git-send-email 2.0.0.rc2 In-Reply-To: <76576b662613369d0c71db30ceed4ed5ae1343d2.1405857442.git.viresh.kumar@linaro.org> References: <76576b662613369d0c71db30ceed4ed5ae1343d2.1405857442.git.viresh.kumar@linaro.org> In-Reply-To: <76576b662613369d0c71db30ceed4ed5ae1343d2.1405857442.git.viresh.kumar@linaro.org> References: <76576b662613369d0c71db30ceed4ed5ae1343d2.1405857442.git.viresh.kumar@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140720_050033_285705_048D0C6C X-CRM114-Status: GOOD ( 12.71 ) X-Spam-Score: -0.7 (/) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-0.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.47 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.220.47 listed in wl.mailspike.net] Cc: pratyush.anand@st.com, linux-pci@vger.kernel.org, spear-devel@list.st.com, Viresh Kumar , mohit.kumar@st.com, bhelgaas@google.com, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.169 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Following compilation warning occurs when compiled with: CONFIG_DEBUG_SECTION_MISMATCH=y WARNING: vmlinux.o(.init.data+0x3338): Section mismatch in reference from the variable spear13xx_pcie_driver to the function .exit.text:spear13xx_pcie_remove() This driver isn't allowed to unload, and so doesn't have a *_exit() routine. But it still has spear13xx_pcie_remove() marked with __exit. As this driver can't unload, .remove() would never be called, right? So get rid of it. Fixes: 51b66a6 (PCI: spear: Add PCIe driver for ST Microelectronics SPEAr13xx) Signed-off-by: Viresh Kumar --- drivers/pci/host/pcie-spear13xx.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/pci/host/pcie-spear13xx.c b/drivers/pci/host/pcie-spear13xx.c index 67315ea..6dea9e4 100644 --- a/drivers/pci/host/pcie-spear13xx.c +++ b/drivers/pci/host/pcie-spear13xx.c @@ -365,17 +365,6 @@ static int __init spear13xx_pcie_probe(struct platform_device *pdev) return ret; } -static int __exit spear13xx_pcie_remove(struct platform_device *pdev) -{ - struct spear13xx_pcie *spear13xx_pcie = platform_get_drvdata(pdev); - - clk_disable_unprepare(spear13xx_pcie->clk); - - phy_exit(spear13xx_pcie->phy); - - return 0; -} - static const struct of_device_id spear13xx_pcie_of_match[] = { { .compatible = "st,spear1340-pcie", }, {}, @@ -384,7 +373,6 @@ MODULE_DEVICE_TABLE(of, spear13xx_pcie_of_match); static struct platform_driver spear13xx_pcie_driver __initdata = { .probe = spear13xx_pcie_probe, - .remove = spear13xx_pcie_remove, .driver = { .name = "spear-pcie", .owner = THIS_MODULE,