mbox series

[v10,00/12] Add soundcard support for sc7280 based platforms.

Message ID 1650636521-18442-1-git-send-email-quic_srivasam@quicinc.com
Headers show
Series Add soundcard support for sc7280 based platforms. | expand

Message

Srinivasa Rao Mandadapu April 22, 2022, 2:08 p.m. UTC
This patch set is to add bolero digital macros, WCD and maxim codecs nodes
for audio on sc7280 based platforms.

This patch set depends on:
    -- https://patchwork.kernel.org/project/linux-arm-msm/list/?series=631506
    -- https://patchwork.kernel.org/project/linux-arm-msm/list/?series=601249
    -- https://patchwork.kernel.org/project/linux-arm-msm/list/?series=634203
    -- Clock reset control patches

Changes Since V9:
    -- Move wcd codec and digital codec nodes to sc7280-qcard file.
    -- Modify the reg property as per link number in sound node.
    -- Fix the us-euro pin control usage in wcd codec node.
    -- Move wcd pin control nodes to specific crd board files.
    -- Sort max98360a codec node in alphabetical order.
    -- Modify the commit messages.
Changes Since V8:
    -- Split patches as per sc7280 CRD revision 3, 4 and 5 boards.
    -- Add corresponding dt nodes for herobrine crd boards.
    -- Update dai-link node names as per dt-bindings in sound node.
    -- Add reg property in sound node as per dt-bindings which was removed in previous series.
    -- Fix typo errors.
    -- Update wcd codec pin control properties in board specific files.
Changes Since V7:
    -- Remove redundant interrupt names in soundwire node.
    -- Fix typo errors.
    -- Remove redundant reg property in sound node.
    -- Rebased on top of latest kernel tip.
Changes Since V6:
    -- Modify link-names and audio routing in a sound node.
    -- Move amp_en pin control node to appropriate consumer patch.
    -- Split patches as per digital macro codecs and board specific codecs and sort it.
    -- Modify label and node names to lpass specific.
Changes Since V5:
    -- Move soc specific bolero digital codec nodes to soc specific file.
    -- Bring wcd938x codec reset pin control and US/EURO HS selection nodes from other series.
    -- Change node name and remove redundant status property in sound node.
Changes Since V4:
    -- Update nodes in sorting order.
    -- Update DTS node names as per dt-bindings.
    -- Update Node properties in proper order.
    -- Update missing pinctrl properties like US/EURO HS selection, wcd reset control.
    -- Remove redundant labels.
    -- Remove unused size cells and address cells in tx macro node.
    -- Keep all same nodes at one place, which are defined in same file.
    -- Add max98360a codec node to herobrine board specific targets.
Changes Since V3:
    -- Move digital codec macro nodes to board specific dtsi file.
    -- Update pin controls in lpass cpu node.
    -- Update dependency patch list.
    -- Create patches on latest kernel.
Changes Since V2:
    -- Add power domains to digital codec macro nodes.
    -- Change clock node usage in lpass cpu node.
    -- Add codec mem clock to lpass cpu node.
    -- Modify the node names to be generic.
    -- Move sound and codec nodes to root node.
    -- sort dai links as per reg.
    -- Fix typo errors.
Changes Since V1:
    -- Update the commit message of cpu node patch.
    -- Add gpio control property to support Euro headset in wcd938x node.
    -- Fix clock properties in lpass cpu and digital codec macro node.

Srinivasa Rao Mandadapu (12):
  arm64: dts: qcom: sc7280: Add nodes for soundwire and va tx rx digital
    macro codecs
  arm64: dts: qcom: sc7280: Enable digital codecs and soundwire for CRD
    1.0/2.0 and IDP boards
  arm64: dts: qcom: sc7280: Enable digital codecs and soundwire for CRD
    3.0/3.1
  arm64: dts: qcom: sc7280: Add wcd9385 codec node for CRD 1.0/2.0 and
    IDP boards
  arm64: dts: qcom: sc7280: Add wcd9385 codec node for CRD 3.0/3.1
  arm64: dts: qcom: sc7280: Add max98360a codec for CRD 1.0/2.0 and IDP
    boards
  arm64: dts: qcom: sc7280: herobrine: Add max98360a codec node
  arm64: dts: qcom: sc7280: Add lpass cpu node
  arm64: dts: qcom: sc7280: Enable lpass cpu node for CRD 1.0/2.0 and
    IDP boards.
  arm64: dts: qcom: sc7280: Enable lpass cpu node for CRD 3.0/3.1
  arm64: dts: qcom: sc7280: Add sound node for CRD 1.0/2.0 and IDP
    boards
  arm64: dts: qcom: sc7280: Add sound node for CRD 3.0/3.1

 arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts        |  37 ++++
 arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts | 150 +++++++++++++++
 arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi    |   8 +
 arch/arm64/boot/dts/qcom/sc7280-idp.dtsi          | 218 ++++++++++++++++++++++
 arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi        |  75 ++++++++
 arch/arm64/boot/dts/qcom/sc7280.dtsi              | 190 +++++++++++++++++++
 6 files changed, 678 insertions(+)

Comments

Matthias Kaehlcke April 22, 2022, 4:58 p.m. UTC | #1
On Fri, Apr 22, 2022 at 07:38:36PM +0530, Srinivasa Rao Mandadapu wrote:
> Add max98360a codec node for audio use case on all herobrine boards.
> 
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>

Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Matthias Kaehlcke April 22, 2022, 5:05 p.m. UTC | #2
On Fri, Apr 22, 2022 at 07:38:41PM +0530, Srinivasa Rao Mandadapu wrote:
> Add dt nodes for sound card support on rev5+ (aka CRD 3.0/3.1) boards,
> which is using WCD9385 headset playback, capture, I2S speaker playback
> and DMICs via VA macro.
> 
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>

Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Matthias Kaehlcke April 25, 2022, 6:30 p.m. UTC | #3
On Fri, Apr 22, 2022 at 07:38:29PM +0530, Srinivasa Rao Mandadapu wrote:
> This patch set is to add bolero digital macros, WCD and maxim codecs nodes
> for audio on sc7280 based platforms.
> 
> This patch set depends on:
>     -- https://patchwork.kernel.org/project/linux-arm-msm/list/?series=631506

There's a newer version (v10) [1]

which should be ready to land now that 'Add pin control support for lpass
sc7280' [2] has landed in Linus' pinctrl tree

>     -- https://patchwork.kernel.org/project/linux-arm-msm/list/?series=601249

These are flagged as 'Queued', so probably landing soon.

>     -- https://patchwork.kernel.org/project/linux-arm-msm/list/?series=634203

There is a newer version [3] which seems ready to land.

>     -- Clock reset control patches

What is this? I don't think I have seen an upstream version of this.
Please provide a link, or if it hasn't be posted upstream yet make sure
it is done ASAP.

[1]https://patchwork.kernel.org/project/linux-arm-msm/list/?series=632316
[2] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=633019&state=*
[3] https://patchwork.kernel.org/project/linux-arm-msm/patch/1650621734-10297-1-git-send-email-quic_srivasam@quicinc.com/
Srinivasa Rao Mandadapu April 26, 2022, 6:59 a.m. UTC | #4
On 4/26/2022 12:00 AM, Matthias Kaehlcke wrote:
> On Fri, Apr 22, 2022 at 07:38:29PM +0530, Srinivasa Rao Mandadapu wrote:
>> This patch set is to add bolero digital macros, WCD and maxim codecs nodes
>> for audio on sc7280 based platforms.
>>
>> This patch set depends on:
>>      -- https://patchwork.kernel.org/project/linux-arm-msm/list/?series=631506
> There's a newer version (v10) [1]
>
> which should be ready to land now that 'Add pin control support for lpass
> sc7280' [2] has landed in Linus' pinctrl tree
Yes. It's ready for landing. But will post the next version, as per new 
herobrine dts files for rev5+ boards.
>
>>      -- https://patchwork.kernel.org/project/linux-arm-msm/list/?series=601249
> These are flagged as 'Queued', so probably landing soon.
Yes. They may land soon.
>
>>      -- https://patchwork.kernel.org/project/linux-arm-msm/list/?series=634203
> There is a newer version [3] which seems ready to land.
Yes. It's reviewed.
>
>>      -- Clock reset control patches
> What is this? I don't think I have seen an upstream version of this.
> Please provide a link, or if it hasn't be posted upstream yet make sure
> it is done ASAP.
These patches are yet to upstream by Clock team. Requested them to do ASAP.
>
> [1]https://patchwork.kernel.org/project/linux-arm-msm/list/?series=632316
> [2] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=633019&state=*
> [3] https://patchwork.kernel.org/project/linux-arm-msm/patch/1650621734-10297-1-git-send-email-quic_srivasam@quicinc.com/