| Message ID | 1674120444-23706-1-git-send-email-quic_srivasam@quicinc.com |
|---|---|
| Headers | show |
| Series | Add resets for ADSP based audio clock controller driver | expand |
On 19/01/2023 10:27, Srinivasa Rao Mandadapu wrote: > Merge lpasscc clocks into lpass_aon clk_regmap structure as they > are using same register space. > In existing implementation, lpasscc clocks and lpass_aon clocks are > being registered exclusively and overlapping if both of them are > to be used. > This is required to avoid such overlapping and to register > lpasscc clocks and lpass_aon clocks simultaneously. > > Fixes: 0cbcfbe50cbf ("clk: qcom: lpass: Handle the regmap overlap of lpasscc and lpass_aon") I don't think this is suitable. > Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> > Tested-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com> > --- > drivers/clk/qcom/lpassaudiocc-sc7280.c | 20 ++------------------ > 1 file changed, 2 insertions(+), 18 deletions(-) > > diff --git a/drivers/clk/qcom/lpassaudiocc-sc7280.c b/drivers/clk/qcom/lpassaudiocc-sc7280.c > index 1339f92..18f7a50 100644 > --- a/drivers/clk/qcom/lpassaudiocc-sc7280.c > +++ b/drivers/clk/qcom/lpassaudiocc-sc7280.c > @@ -642,11 +642,6 @@ static struct gdsc lpass_aon_cc_lpass_audio_hm_gdsc = { > .flags = RETAIN_FF_ENABLE, > }; > > -static struct clk_regmap *lpass_cc_sc7280_clocks[] = { > - [LPASS_Q6SS_AHBM_CLK] = &lpass_q6ss_ahbm_clk.clkr, > - [LPASS_Q6SS_AHBS_CLK] = &lpass_q6ss_ahbs_clk.clkr, > -}; This is now an ABI break because these IDs will stop working. Additionally it is an ABI break marked for backporting to v6.1... Best regards, Krzysztof
Add resets and remove qdsp6ss clcok controller for audioreach based platforms. Changes since v3: -- Remove duplicate clock resets patch. -- Add binding headers for q6 clocks. -- Create new patch for merging lpasscc q6 clocks into lpass_aon. -- Create new patches for handling conflicts of ADSP and bypass solution. Changes since v2: -- Revert removing qdsp6ss clock control. -- Add Conditional check for qdsp6ss clock registration. Changes since v1: -- Update commit message. -- Remove qdsp6ss clock control. Srinivasa Rao Mandadapu (6): dt-bindings: clock: qcom,sc7280-lpasscc: Add qcom,adsp-pil-mode property dt-bindings: clock: lpassaudiocc-sc7280: Add binding headers for lpasscc clk: qcom: lpasscc-sc7280: Skip qdsp6ss clock registration clk: qcom: lpasscorecc-sc7280: Skip lpasscorecc registration clk: qcom: lpassaudiocc-sc7280: Merge lpasscc into lpass_aon clk: qcom: lpassaudiocc-sc7280: Skip lpass_aon_cc_pll config .../bindings/clock/qcom,sc7280-lpasscc.yaml | 7 +++++++ drivers/clk/qcom/lpassaudiocc-sc7280.c | 23 ++++------------------ drivers/clk/qcom/lpasscc-sc7280.c | 12 ++++++----- drivers/clk/qcom/lpasscorecc-sc7280.c | 3 +++ .../dt-bindings/clock/qcom,lpassaudiocc-sc7280.h | 2 ++ 5 files changed, 23 insertions(+), 24 deletions(-)