mbox series

[V6,0/3] Implement Shutdown callback for geni-i2c

Message ID 20201030145959.505-1-rojay@codeaurora.org
Headers show
Series Implement Shutdown callback for geni-i2c | expand

Message

Roja Rani Yarubandi Oct. 30, 2020, 2:59 p.m. UTC 
Roja Rani Yarubandi (3):
  soc: qcom: geni: Remove "iova" check
  i2c: i2c-qcom-geni: Store DMA mapping data in geni_i2c_dev struct
  i2c: i2c-qcom-geni: Add shutdown callback for i2c

 drivers/i2c/busses/i2c-qcom-geni.c | 104 ++++++++++++++++++++++++-----
 drivers/soc/qcom/qcom-geni-se.c    |   4 +-
 2 files changed, 90 insertions(+), 18 deletions(-)

Comments

Bjorn Andersson Nov. 22, 2020, 3:27 a.m. UTC | #1 
On Fri 30 Oct 09:59 CDT 2020, Roja Rani Yarubandi wrote:

> Remove "iova" check from geni_se_tx_dma_unprep and geni_se_rx_dma_unprep

> functions as checking with dma_mapping_error() is enough.

> 


Applied this patch towards v5.11.

Thank you,
Bjorn

> Signed-off-by: Roja Rani Yarubandi <rojay@codeaurora.org>

> ---

> Changes in V5:

>  - This is newly added patch in V5. As per Stephen's comments separted

>    this patch from shutdown callback patch.

> 

> Changes in V6:

>  - Fixed nit-picks in commit text.

> 

>  drivers/soc/qcom/qcom-geni-se.c | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c

> index d0e4f520cff8..0216b38c1e9a 100644

> --- a/drivers/soc/qcom/qcom-geni-se.c

> +++ b/drivers/soc/qcom/qcom-geni-se.c

> @@ -705,7 +705,7 @@ void geni_se_tx_dma_unprep(struct geni_se *se, dma_addr_t iova, size_t len)

>  {

>  	struct geni_wrapper *wrapper = se->wrapper;

>  

> -	if (iova && !dma_mapping_error(wrapper->dev, iova))

> +	if (!dma_mapping_error(wrapper->dev, iova))

>  		dma_unmap_single(wrapper->dev, iova, len, DMA_TO_DEVICE);

>  }

>  EXPORT_SYMBOL(geni_se_tx_dma_unprep);

> @@ -722,7 +722,7 @@ void geni_se_rx_dma_unprep(struct geni_se *se, dma_addr_t iova, size_t len)

>  {

>  	struct geni_wrapper *wrapper = se->wrapper;

>  

> -	if (iova && !dma_mapping_error(wrapper->dev, iova))

> +	if (!dma_mapping_error(wrapper->dev, iova))

>  		dma_unmap_single(wrapper->dev, iova, len, DMA_FROM_DEVICE);

>  }

>  EXPORT_SYMBOL(geni_se_rx_dma_unprep);

> -- 

> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 

> of Code Aurora Forum, hosted by The Linux Foundation

>