mbox series

[v3,0/2] spmi: pmic-arb: Add support for PMIC v7

Message ID 20220201134108.2677578-1-vkoul@kernel.org
Headers show
Series spmi: pmic-arb: Add support for PMIC v7 | expand

Message

Vinod Koul Feb. 1, 2022, 1:41 p.m. UTC
Hello,

The is version 3 of support for PMIC v7. I have added a new property
qcom,bus-id for supporting v7 and then add driver changes for v7

This depends on yaml conversion patch:
https://lore.kernel.org/linux-arm-msm/20211227170151.73116-1-david@ixit.cz/

Changes since v2:
 - Drop yaml conversion patch
 - Fix author for spmi patch
Changes since v1:
 - Add yaml conversion patch and new binding
 - fix driver bug report by Jonathan

David Collins (1):
  spmi: pmic-arb: Add support for PMIC v7

Vinod Koul (1):
  dt-bindings: spmi: Add qcom,bus-id

 .../bindings/spmi/qcom,spmi-pmic-arb.yaml     |  11 +
 drivers/spmi/spmi-pmic-arb.c                  | 233 ++++++++++++++++--
 2 files changed, 225 insertions(+), 19 deletions(-)

Comments

Rob Herring (Arm) Feb. 7, 2022, 9:45 p.m. UTC | #1
On Tue, 01 Feb 2022 19:11:07 +0530, Vinod Koul wrote:
> PMIC arbiter version 7 and beyond we need to define if we are using
> primary or secondary bus, so add a new property of qcom,bus-id
> 
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
>  .../devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml  | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
Vinod Koul Feb. 22, 2022, 4:53 p.m. UTC | #2
On 01-02-22, 19:11, Vinod Koul wrote:
> Hello,
> 
> The is version 3 of support for PMIC v7. I have added a new property
> qcom,bus-id for supporting v7 and then add driver changes for v7
> 
> This depends on yaml conversion patch:
> https://lore.kernel.org/linux-arm-msm/20211227170151.73116-1-david@ixit.cz/

Any feedback on this...

> 
> Changes since v2:
>  - Drop yaml conversion patch
>  - Fix author for spmi patch
> Changes since v1:
>  - Add yaml conversion patch and new binding
>  - fix driver bug report by Jonathan
> 
> David Collins (1):
>   spmi: pmic-arb: Add support for PMIC v7
> 
> Vinod Koul (1):
>   dt-bindings: spmi: Add qcom,bus-id
> 
>  .../bindings/spmi/qcom,spmi-pmic-arb.yaml     |  11 +
>  drivers/spmi/spmi-pmic-arb.c                  | 233 ++++++++++++++++--
>  2 files changed, 225 insertions(+), 19 deletions(-)
> 
> -- 
> 2.31.1
Linus Walleij June 28, 2022, 12:46 p.m. UTC | #3
On Sat, Jun 18, 2022 at 5:30 PM Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
> On 01/05/2022 22:41, Dmitry Baryshkov wrote:
> > On 22/02/2022 19:53, Vinod Koul wrote:
> >> On 01-02-22, 19:11, Vinod Koul wrote:
> >>> Hello,
> >>>
> >>> The is version 3 of support for PMIC v7. I have added a new property
> >>> qcom,bus-id for supporting v7 and then add driver changes for v7
> >>>
> >>> This depends on yaml conversion patch:
> >>> https://lore.kernel.org/linux-arm-msm/20211227170151.73116-1-david@ixit.cz/
> >>>
> >>
> >> Any feedback on this...
> >
> > Another gracious reminder about these patches. At this moment this is
> > one of the important pieces lacking for the full SM8450 support in the
> > upstream kernel.
>
> Stephen, yet another ping. This is the blocking point for the further
> SM8450 progress.

Pending since february!

I would rather suspect something is wrong and it somehow goes
into the spam or wrong inbox on Stephen's end.

Sounds like something Bjorn could solve if Stephen don't have time
to manage the SPMI subsystem right now? If it's OK with Stephen
or he simply don't respond we can just queue the stuff in the SoC
tree I assume?

Yours,
Linus Walleij
Stephen Boyd Aug. 29, 2022, 10:25 p.m. UTC | #4
Quoting Dmitry Baryshkov (2022-06-18 08:29:58)
> On 01/05/2022 22:41, Dmitry Baryshkov wrote:
> > On 22/02/2022 19:53, Vinod Koul wrote:
> >> On 01-02-22, 19:11, Vinod Koul wrote:
> >>> Hello,
> >>>
> >>> The is version 3 of support for PMIC v7. I have added a new property
> >>> qcom,bus-id for supporting v7 and then add driver changes for v7
> >>>
> >>> This depends on yaml conversion patch:
> >>> https://lore.kernel.org/linux-arm-msm/20211227170151.73116-1-david@ixit.cz/ 
> >>>
> >>
> >> Any feedback on this...
> > 
> > Another gracious reminder about these patches. At this moment this is 
> > one of the important pieces lacking for the full SM8450 support in the 
> > upstream kernel.
> 
> Stephen, yet another ping. This is the blocking point for the further 
> SM8450 progress.
> 

Sorry I completely missed this one as it fell off the end of my inbox
into the abyss.
Vinod Koul Aug. 30, 2022, 4:36 a.m. UTC | #5
On 29-08-22, 15:25, Stephen Boyd wrote:
> Quoting Dmitry Baryshkov (2022-06-18 08:29:58)
> > On 01/05/2022 22:41, Dmitry Baryshkov wrote:
> > > On 22/02/2022 19:53, Vinod Koul wrote:
> > >> On 01-02-22, 19:11, Vinod Koul wrote:
> > >>> Hello,
> > >>>
> > >>> The is version 3 of support for PMIC v7. I have added a new property
> > >>> qcom,bus-id for supporting v7 and then add driver changes for v7
> > >>>
> > >>> This depends on yaml conversion patch:
> > >>> https://lore.kernel.org/linux-arm-msm/20211227170151.73116-1-david@ixit.cz/ 
> > >>>
> > >>
> > >> Any feedback on this...
> > > 
> > > Another gracious reminder about these patches. At this moment this is 
> > > one of the important pieces lacking for the full SM8450 support in the 
> > > upstream kernel.
> > 
> > Stephen, yet another ping. This is the blocking point for the further 
> > SM8450 progress.
> > 
> 
> Sorry I completely missed this one as it fell off the end of my inbox
> into the abyss.

Thanks for the reply. Is this applied now or you have some feedback for
me to address..

Thanks
Stephen Boyd Aug. 30, 2022, 9:11 p.m. UTC | #6
Quoting Vinod Koul (2022-08-29 21:36:00)
> On 29-08-22, 15:25, Stephen Boyd wrote:
> > Quoting Dmitry Baryshkov (2022-06-18 08:29:58)
> > > On 01/05/2022 22:41, Dmitry Baryshkov wrote:
> > > > On 22/02/2022 19:53, Vinod Koul wrote:
> > > >> On 01-02-22, 19:11, Vinod Koul wrote:
> > > >>> Hello,
> > > >>>
> > > >>> The is version 3 of support for PMIC v7. I have added a new property
> > > >>> qcom,bus-id for supporting v7 and then add driver changes for v7
> > > >>>
> > > >>> This depends on yaml conversion patch:
> > > >>> https://lore.kernel.org/linux-arm-msm/20211227170151.73116-1-david@ixit.cz/ 
> > > >>>
> > > >>
> > > >> Any feedback on this...
> > > > 
> > > > Another gracious reminder about these patches. At this moment this is 
> > > > one of the important pieces lacking for the full SM8450 support in the 
> > > > upstream kernel.
> > > 
> > > Stephen, yet another ping. This is the blocking point for the further 
> > > SM8450 progress.
> > > 
> > 
> > Sorry I completely missed this one as it fell off the end of my inbox
> > into the abyss.
> 
> Thanks for the reply. Is this applied now or you have some feedback for
> me to address..
> 

Does it apply along with the series from qcom[1]? I have to check and
make sure they both work together.

[1] https://lore.kernel.org/r/1651108369-11059-1-git-send-email-quic_fenglinw@quicinc.com
Vinod Koul Sept. 14, 2022, 11:23 a.m. UTC | #7
On 30-08-22, 14:11, Stephen Boyd wrote:
> Quoting Vinod Koul (2022-08-29 21:36:00)
> > On 29-08-22, 15:25, Stephen Boyd wrote:
> > > Quoting Dmitry Baryshkov (2022-06-18 08:29:58)
> > > > On 01/05/2022 22:41, Dmitry Baryshkov wrote:
> > > > > On 22/02/2022 19:53, Vinod Koul wrote:
> > > > >> On 01-02-22, 19:11, Vinod Koul wrote:
> > > > >>> Hello,
> > > > >>>
> > > > >>> The is version 3 of support for PMIC v7. I have added a new property
> > > > >>> qcom,bus-id for supporting v7 and then add driver changes for v7
> > > > >>>
> > > > >>> This depends on yaml conversion patch:
> > > > >>> https://lore.kernel.org/linux-arm-msm/20211227170151.73116-1-david@ixit.cz/ 
> > > > >>>
> > > > >>
> > > > >> Any feedback on this...
> > > > > 
> > > > > Another gracious reminder about these patches. At this moment this is 
> > > > > one of the important pieces lacking for the full SM8450 support in the 
> > > > > upstream kernel.
> > > > 
> > > > Stephen, yet another ping. This is the blocking point for the further 
> > > > SM8450 progress.
> > > > 
> > > 
> > > Sorry I completely missed this one as it fell off the end of my inbox
> > > into the abyss.
> > 
> > Thanks for the reply. Is this applied now or you have some feedback for
> > me to address..
> > 
> 
> Does it apply along with the series from qcom[1]? I have to check and
> make sure they both work together.

There were conflicts, I have resolved, tested on top of spmi/next again
and posted the v4 now.. Hope this would get in.