From patchwork Tue Oct 25 07:32:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 618203 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDA87C04A95 for ; Tue, 25 Oct 2022 07:33:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231788AbiJYHdW (ORCPT ); Tue, 25 Oct 2022 03:33:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231800AbiJYHdM (ORCPT ); Tue, 25 Oct 2022 03:33:12 -0400 Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 527B7150F86 for ; Tue, 25 Oct 2022 00:33:09 -0700 (PDT) Received: by mail-pf1-x442.google.com with SMTP id i3so11038159pfc.11 for ; Tue, 25 Oct 2022 00:33:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=bQgCaWbgbYow1rgq+ZxN/4mds+e7cc6gBHNrup7NClQ=; b=Rma508W6fqDHDy8X+To2mg/1uAtZ5IaQzmUr+YHjGOFAm4K11fJ25xDB9x97fQxp/3 pAKuwa1y4LTFa8ZDVIeGc19yNb7KXcCb+0AOl/V3heAVwMucficS7vVofz3MjMfyBIrg q2snNTbRNOGZZHmSCdmCsxRXmoPl2il6PecioXpJjR3hpNMVYC5QsBqovcnNEEaaISjg 3xze1FffCERBHcsduLW2v6CbzBJhCgU6sBtADSoqt+uSNbsh2lekpDISmVou0xgQDKyU uNBfwCinnyjyrretyJKoOpQt+rtCZr4OvQ/S3WnEjDRoWOx2HKV7moWlSfKVAaOcALwZ NuUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bQgCaWbgbYow1rgq+ZxN/4mds+e7cc6gBHNrup7NClQ=; b=6IifJCfHeegXyd6QIt82MHH/oJ3ov0mQMtLoxpihYuht6swRUQXzliR/3n88Q/tTNW xkS8RxDVQGnx4b2WG9IfEpSQH15vpAQ/USa721JbsTiO9ZW0gLcfi5dA5Ai9GCfcRhPv MrcWk3KzCqFZklPaKXrBLOcRopaBled0pYpcxHKAVrn+aegXXwWGPS4zAaBcyRWuSkrn HV5R6D4BD0FLlXmQyVii41z7vlB9aX9Ki3Z+VTfaRA/sBfXf2iGgdcRBVxjNXtV7De6n wTDFoTW2hxNA3WHy5HcicBQz8Az5KYOCgNvp9QIkboBz++qRwvL4jYiA3SMlp01+vH+V u+XA== X-Gm-Message-State: ACrzQf13l5upodamHKUO1oiER7IOslRt2YR8aQpOIgjcXSUuNQugjZFy O7g+TM2uJTJWy7UeWv8+c5BL X-Google-Smtp-Source: AMsMyM4DsarYjZkBTgiETVgHPPe5/NCMxK4F2rPLgYezcHMrAG64Jaa7kPSXcD3GLtirzsSbLhqGzg== X-Received: by 2002:a05:6a00:1a47:b0:52e:6a8c:5430 with SMTP id h7-20020a056a001a4700b0052e6a8c5430mr36915826pfv.48.1666683189162; Tue, 25 Oct 2022 00:33:09 -0700 (PDT) Received: from localhost.localdomain ([117.193.211.146]) by smtp.gmail.com with ESMTPSA id c1-20020a17090a4d0100b0020dda7efe61sm5048369pjg.5.2022.10.25.00.33.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 00:33:06 -0700 (PDT) From: Manivannan Sadhasivam To: andersson@kernel.org, viresh.kumar@linaro.org, krzysztof.kozlowski+dt@linaro.org, rafael@kernel.org, robh+dt@kernel.org Cc: johan@kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH v2 0/7] qcom-cpufreq-hw: Add CPU clock provider support Date: Tue, 25 Oct 2022 13:02:47 +0530 Message-Id: <20221025073254.1564622-1-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hello, This series adds clock provider support to the Qcom CPUFreq driver for supplying the clocks to the CPU cores in Qcom SoCs. The Qualcomm platforms making use of CPUFreq HW Engine (EPSS/OSM) supply clocks to the CPU cores. But this is not represented clearly in devicetree. There is no clock coming out of the CPUFreq HW node to the CPU. This created an issue [1] with the OPP core when a recent enhancement series was submitted. Eventhough the issue got fixed in the OPP framework in the meantime, that's not a proper solution and this series aims to fix it properly. There was also an attempt made by Viresh [2] to fix the issue by moving the clocks supplied to the CPUFreq HW node to the CPU. But that was not accepted since those clocks belong to the CPUFreq HW node only. The proposal here is to add clock provider support to the Qcom CPUFreq HW driver to supply clocks to the CPUs that comes out of the EPSS/OSM block. This correctly reflects the hardware implementation. The clock provider is a simple one that just provides the frequency of the clocks supplied to each frequency domain in the SoC using .recalc_rate() callback. The frequency supplied by the driver will be the actual frequency that comes out of the EPSS/OSM block after the DCVS operation. This frequency is not same as what the CPUFreq framework has set but it is the one that gets supplied to the CPUs after throttling by LMh. This series has been tested on SM8450 based dev board with the OPP hack removed and hence there is a DTS change only for that platform. Once this series gets accepted, rest of the platform DTS can also be modified and finally the hack on the OPP core can be dropped. Thanks, Mani [1] https://lore.kernel.org/lkml/YsxSkswzsqgMOc0l@hovoldconsulting.com/ [2] https://lore.kernel.org/lkml/20220801054255.GA12039@thinkpad/t/ Changes in v2: * Moved the qcom_cpufreq_data allocation to probe * Added single clock provider with multiple clks for each freq domain * Moved soc_data to qcom_cpufreq struct * Added Rob's review for binding Manivannan Sadhasivam (7): dt-bindings: cpufreq: cpufreq-qcom-hw: Add cpufreq clock provider arm64: dts: qcom: sm8450: Supply clock from cpufreq node to CPUs cpufreq: qcom-hw: Remove un-necessary cpumask_empty() check cpufreq: qcom-hw: Allocate qcom_cpufreq_data during probe cpufreq: qcom-hw: Use cached dev pointer in probe() cpufreq: qcom-hw: Move soc_data to struct qcom_cpufreq cpufreq: qcom-hw: Add CPU clock provider support .../bindings/cpufreq/cpufreq-qcom-hw.yaml | 12 ++ arch/arm64/boot/dts/qcom/sm8450.dtsi | 9 + drivers/cpufreq/qcom-cpufreq-hw.c | 166 ++++++++++-------- 3 files changed, 118 insertions(+), 69 deletions(-)