From patchwork Wed Nov 16 16:27:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 625547 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F2E4C43219 for ; Wed, 16 Nov 2022 16:36:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232906AbiKPQgB (ORCPT ); Wed, 16 Nov 2022 11:36:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233854AbiKPQfd (ORCPT ); Wed, 16 Nov 2022 11:35:33 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AC9E5B5A5 for ; Wed, 16 Nov 2022 08:28:06 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id o4so30643872wrq.6 for ; Wed, 16 Nov 2022 08:28:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pNFHDkn6ncnlygTA2saZMCRROi8LNNLnuC/3Q5k3vSo=; b=bfLhrL4tNGeDEAWaOYNAAs4mUSpqOy0W5a3lbFF6EQS8ojp3Zy28i8NkTB2/D1fhr0 2ly8RziHT+jwoTKMxAYR9aSzn9GzU0PvhIk5OOQE0jTlvru3M20k0pQt2in1p6C4tvMt EfbuU+Zt2r8WmUSXsrIHoHTwNfQpAuLThC9WuNEOd/+tlN5lP5CaEQKtCPSp92at1+/J Gn2mT9KZcGHaewqAMcXixD5memmT3Wqqj7sGQ9mhFb2jeuUDQ4bRcf4S4orn3To2s+zE Pjb2Ggk4A3i1kkx8gw7csGx3sjWKnTcJfmMNK6Q/7vsALiKHNKD0bnD2DTxiIVy12sw0 +yvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pNFHDkn6ncnlygTA2saZMCRROi8LNNLnuC/3Q5k3vSo=; b=rj72zsSMn1Jr34yMHKw9EcZ9Qu2637gqbKineMaycAPy0bUk4jkDgm1KWI1yXUw/lB OLJf4qN9+M1xognYOUx1Tq73YHRSFNQ/eFMvnxcbuhuMq18fsM9NpuR7sbAQKNAwj6zr Q9wACaAY4WcMK/AmcAq7CuF/i7tRl8/W2PUicFw6lVVneH9dMrmMfVDzF7ZDuyqKsyyj Zw/9eRSM4dprs0nqGwcJ62/2Enhm/fi+SpLSMhqkpjqPsMocuVkEsDiwcipsByw9ja/M SOM+e1rtGsBzHsCdA3ri2y6aklkY2QaCh7K5r66i4YVCLxX0RRQKie7tYpQBjMJOGNIl zOHQ== X-Gm-Message-State: ANoB5pmEQlelwWBHSTba/IBZ4OxN8+JweI6bDvvTymLH0pVTTRk+Y5kz FHNo3EFlFTWin0nENk1Kb+NVlg== X-Google-Smtp-Source: AA0mqf7+DB0FtqxZYnK760Z7jKL2/gwCEwPmIAXMya3QlVEVEgd48oqgym6b/T4Tt32gfWmyG825kQ== X-Received: by 2002:adf:e892:0:b0:228:c1a8:6ef0 with SMTP id d18-20020adfe892000000b00228c1a86ef0mr14267698wrm.584.1668616085099; Wed, 16 Nov 2022 08:28:05 -0800 (PST) Received: from localhost.localdomain (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id s3-20020adfecc3000000b0022e653f5abbsm15459168wro.69.2022.11.16.08.28.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 08:28:04 -0800 (PST) From: Bryan O'Donoghue To: robert.foss@linaro.org, todor.too@gmail.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@somainline.org, mchehab@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, dmitry.baryshkov@linaro.org, vladimir.zapolskiy@linaro.org Cc: sakari.ailus@iki.fi, hverkuil@xs4all.nl, laurent.pinchart@ideasonboard.com, quic_mmitkov@quicinc.com, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Bryan O'Donoghue Subject: [PATCH v6 0/7] CAMSS fixes for rb3, switch on IMX577 for RB5 Date: Wed, 16 Nov 2022 16:27:54 +0000 Message-Id: <20221116162801.546737-1-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org V6: - Squashes down ok/okay disable/disabled - Adds Rb as indicated by Laurent, Konrad - Alphabetizes existing rb3 dts and new rb5 dts for camera - Adds in ports@ definition per Laurent's suggestion for sm8250 - Adds in ports@ in dtsi for sdm845 - Drops reg = in port definition of sdm845-db845c - ov9282 for rb5 is omitted as more work needs to be done to get this sensor delivering CSI data. - ov7251 left as-is upstream, disabled on rb3 - Plan to look at overlaying both of these in the future but there may be bootloader blockages for that so left alone for the moment. - Tested on linux-next as at today Previous https://lore.kernel.org/all/20221112172650.127280-1-bryan.odonoghue@linaro.org/ Bootable https://git.linaro.org/people/bryan.odonoghue/kernel.git/log/?h=linux-next-22-11-15-sm8250-camss-vc V5: - Rolls three identified dts non-confirmances into three separate patches - Konrad - Fixes the "both" left in the git log - Konrad Previous https://lore.kernel.org/all/20221112124126.86815-1-bryan.odonoghue@linaro.org/ V4: - Rebases on top of Konrad's comment fixes to migrate into rb3 mezz.dts -Bjorn - Adds -state suffix - Bjorn - Adds -pins suffix - Bjorn - Removes redundant newline - Krzysztof Previous https://lore.kernel.org/all/20221108021816.213084-1-bryan.odonoghue@linaro.org/ Dependency for the imx577 should be merged in 6.2 https://git.linuxtv.org/sailus/media_tree.git/log/?h=for-6.2-2-signed&ofs=50 V3: - Ordering patch was applied separately, now dropped from this series. - camcc disable patch similarly is already applied, dropped here. - RB5 and RB3 now have separate camera specific DTSI files per perferences expressed on the mailing list by Konrad, Vladimir and Bjorn. - Agreeing a imx412 change spiralled a bit into a wider discussion however after a good bit of debate and testing on different hardware there is a series to add imx577 as a compat string to the imx412.c driver. So this series depends on that series being merged. https://www.spinics.net/lists/linux-media/msg219989.html Given the addition of mezzanine specific dtsi I thought it was worthwhile to kick off a review now since the sensor name change is agreed but not yet applied and all other outstanding comments have been addressed. V2: - Adds fix for bug identified by Vladimir The CCI i2c_adapter_add() and pm_runtime_enable() are racy. This is a generic problem not related to the rb5/imx577 but, for the sake of our conversation/review's context I'll add it into this series. - Include Vladimir's camcc patch I've also opted to include Vladimir's disable of camcc to make the enable of it in my patchset logical. - Move address/size cells Konrad - Remove newline in pin definitions - Konrad - Remove sensor 'status = "okay"' - Konrad - Add comment to qrb5165-rb5.dts re: imx412 and imx577 difference - Konrad - Move pin definitions to 8250 dtsi - Vladimir - Drop power domain from sensor definition - Vladimir - Correct to "add to cam2" not "cam1" in commit log - bod To make verification of the CCI race eaiser I've provided a defconfig both with and without modules enabled. Link: https://git.linaro.org/people/bryan.odonoghue/kernel.git/log/?h=linux-next-24-05-22%2bimx577-rb5 Link: https://git.linaro.org/people/bryan.odonoghue/kernel.git/log/?h=linux-next-24-05-22%2bimx577-rb5-compiled-in git diff linaro/linux-next-22-05-22+imx577-rb5 linaro/linux-next-24-05-22+imx577-rb5 V1: Linux-next now has everything we need to switch on this sensor both in the qcom DTS and in the imx412 driver. After this, no further dts or driver work is required to capture images on the RB5. Here's a bootable linux-next with a kernel config. I added Vladimir's power-domain changes on-top to verify nothing breaks for me. https://git.linaro.org/people/bryan.odonoghue/kernel.git/log/?h=linux-next-18-05-22%2bimx577-rb5 Bryan O'Donoghue (7): arm64: dts: qcom: sdm845: Define the number of available ports arm64: dts: qcom: sdm845-db845c: Drop redundant address-cells, size-cells declaration arm64: dts: qcom: sdm845-db845c: Drop redundant reg = in port arm64: dts: qcom: sdm845-db845c: Use okay not ok, disabled not disable for status arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: Add navigation mezzanine dts arm64: dts: qcom: sm8250: camss: Define ports and ports address/size cells arm64: dts: qcom: qrb5165-rb5-vision-mezzanine: Add vision mezzanine arch/arm64/boot/dts/qcom/Makefile | 2 + .../dts/qcom/qrb5165-rb5-vision-mezzanine.dts | 62 +++++++++++ .../sdm845-db845c-navigation-mezzanine.dts | 104 ++++++++++++++++++ arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 101 ----------------- arch/arm64/boot/dts/qcom/sdm845.dtsi | 16 +++ arch/arm64/boot/dts/qcom/sm8250.dtsi | 62 +++++++++++ 6 files changed, 246 insertions(+), 101 deletions(-) create mode 100644 arch/arm64/boot/dts/qcom/qrb5165-rb5-vision-mezzanine.dts create mode 100644 arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dts