mbox series

[v4,0/4] arm64: dts: qcom: sc8280xp: Enable external display

Message ID 20230213215619.1362566-1-quic_bjorande@quicinc.com
Headers show
Series arm64: dts: qcom: sc8280xp: Enable external display | expand

Message

Bjorn Andersson Feb. 13, 2023, 9:56 p.m. UTC 
This introduces support for external display on the SC8280XP laptops.

Support for swapping orientation and changing the mode of the SuperSpeed
lanes is being implemented in the QMP driver, so at this point in time
this is not supported.

Bjorn Andersson (4):
  arm64: dts: qcom: sc8280xp: Add USB-C-related DP blocks
  arm64: dts: qcom: sc8280xp-crd: Introduce pmic_glink
  arm64: dts: qcom: sc8280xp-x13s: Enable external display
  arm64: defconfig: Enable DisplayPort on SC8280XP laptops

 arch/arm64/boot/dts/qcom/sc8280xp-crd.dts     | 196 +++++++++++++++++-
 .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts    | 180 +++++++++++++++-
 arch/arm64/boot/dts/qcom/sc8280xp.dtsi        | 189 ++++++++++++++++-
 arch/arm64/configs/defconfig                  |   2 +
 4 files changed, 559 insertions(+), 8 deletions(-)

Comments

Bjorn Andersson Feb. 15, 2023, 5:23 p.m. UTC | #1 
On Wed, Feb 15, 2023 at 10:47:40AM +0100, Johan Hovold wrote:
> On Mon, Feb 13, 2023 at 01:56:17PM -0800, Bjorn Andersson wrote:
[..]
> > +&mdss0_dp0_out {
> > +	data-lanes = <0 1>;
> 
> This does not work as the drm driver expects 'data-lanes' to be defined
> in the controller node where you had it in the previous versions:
> 
> 	[    6.669325] [drm] Invalid property "data-lanes", default max DP lanes = 4
> 
> Moving it to the endpoint nodes would require updating both binding and
> driver it seems.
> 

I will go back and double-check, but this should be taken care of in
d25cfeeec064 ("drm/msm/dp: parse data-lanes as property of dp_out
endpoint").

Regards,
Bjorn