| Message ID | 20230531-topic-8998_mmssclk-v1-0-2b5a8fc90991@linaro.org |
|---|---|
| Headers | show |
| Series | MMCC MSM8998 fixes | expand |
On Wed, May 31, 2023 at 11:01 AM Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > The MMSS SMMU has been abusingly consuming the exposed RPM interconnect > clock and not describing the power domain it needs. Put an end to that. > > Fixes: 05ce21b54423 ("arm64: dts: qcom: msm8998: Configure the multimedia subsystem iommu") > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > arch/arm64/boot/dts/qcom/msm8998.dtsi | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi > index f0e943ff0046..a4016085b750 100644 > --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi > @@ -2737,10 +2737,10 @@ mmss_smmu: iommu@cd00000 { > > clocks = <&mmcc MNOC_AHB_CLK>, > <&mmcc BIMC_SMMU_AHB_CLK>, > - <&rpmcc RPM_SMD_MMAXI_CLK>, > <&mmcc BIMC_SMMU_AXI_CLK>; > - clock-names = "iface-mm", "iface-smmu", > - "bus-mm", "bus-smmu"; > + clock-names = "iface-mm", > + "iface-smmu", > + "bus-smmu"; > > #global-interrupts = <0>; > interrupts = > @@ -2764,6 +2764,8 @@ mmss_smmu: iommu@cd00000 { > <GIC_SPI 261 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH>; > + > + power-domains = <&mmcc BIMC_SMMU_GDSC>; > }; > > remoteproc_adsp: remoteproc@17300000 { > > -- > 2.40.1 > I think you should split this up. This should be two patches. One to describe the power-domain and another for the removal of interconnect clocks. I guess none of the multi-media connected stuff on 8998 works ... no venus, mdp, camera - which would surely fail without the multi-media AXI clock being on.. Anyway please split this patch up !
8998 has a couple of issues related to its clock controllers. This series attemps to fix some of them. The DT patch should go in first for bisectability, otherwise clk/pd_ignore_unused will need to be used, as the SMMU GDSC is no longer considered always-on. This series results in less "clk stuck at 'on/off'" messages and should marginally reduce power consumption. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- Konrad Dybcio (4): arm64: dts: qcom: msm8998: Properly describe MMSS SMMU clk: qcom: gcc-msm8998: Don't check halt bit on some branch clks clk: qcom: mmcc-msm8998: Don't check halt bit on some branch clks clk: qcom: mmcc-msm8998: Fix the SMMU GDSC arch/arm64/boot/dts/qcom/msm8998.dtsi | 8 +++++--- drivers/clk/qcom/gcc-msm8998.c | 6 +++--- drivers/clk/qcom/mmcc-msm8998.c | 7 ++++++- 3 files changed, 14 insertions(+), 7 deletions(-) --- base-commit: d4cee89031c80066ec461bb77b5e13a4f37d5fd2 change-id: 20230531-topic-8998_mmssclk-fd4b2fb7f8c1 Best regards,