| Message ID | 20231118123944.2202630-1-quic_skakitap@quicinc.com |
|---|---|
| Headers | show |
| Series | Add runtime PM support for videocc on SM8150 | expand |
On 18.11.2023 13:39, Satya Priya Kakitapalli wrote: > Add runtime support for videocc on SM8150 and update the resets > and video_pll0_config configuration. > > Satya Priya Kakitapalli (4): > dt-bindings: clock: Update the videocc resets for sm8150 > clk: qcom: videocc-sm8150: Update the videocc resets > clk: qcom: videocc-sm8150: Add missing PLL config properties > clk: qcom: videocc-sm8150: Add runtime PM support Hi, it's good practive to include a link to the previous revision and a summary of changes. The b4 tool [1] does that for you, please consider using it. Konrad [1] https://b4.docs.kernel.org/en/latest/index.html
On 28.11.2023 17:11, Satya Priya Kakitapalli (Temp) wrote: > > On 11/20/2023 5:18 PM, Konrad Dybcio wrote: >> On 18.11.2023 13:39, Satya Priya Kakitapalli wrote: >>> Add runtime support for videocc on SM8150 and update the resets >>> and video_pll0_config configuration. >>> >>> Satya Priya Kakitapalli (4): >>> dt-bindings: clock: Update the videocc resets for sm8150 >>> clk: qcom: videocc-sm8150: Update the videocc resets >>> clk: qcom: videocc-sm8150: Add missing PLL config properties >>> clk: qcom: videocc-sm8150: Add runtime PM support >> Hi, it's good practive to include a link to the previous revision >> and a summary of changes. >> >> The b4 tool [1] does that for you, please consider using it. > > > Hi, I have installed b4 and followed all the steps, but it doesn't populate my cover letter with change log and previous series link, do i need to use some option for that? You probably did something like this: b4 prep -n 8150vidcc --from-thread 26b69814-201b-8d07-d844-27e804aa3016@quicinc.com Then if you do: b4 prep --edit-cover you'll see a note like EDITME: Imported from f26b69814-201b-8d07-d844-27e804aa3016@quicinc.com Please review before sending. so you need to do it manually. Generally, when the series has been sent at least once with b4 already, you'll notice that `b4 send` appends something like this to the cover letter: Changes in v2: - EDITME: describe what is new in this series revision. - EDITME: use bulletpoints and terse descriptions. - Link to v1: https://lore.kernel.org/r/20230830-topic-refgenphy-v1-0-892db196a1c0@linaro.org This should be only necessary to do by hand once, since as mentioned it's the first time b4 sees this series Konrad
On 11/29/2023 7:30 PM, Konrad Dybcio wrote: > On 28.11.2023 17:11, Satya Priya Kakitapalli (Temp) wrote: >> On 11/20/2023 5:18 PM, Konrad Dybcio wrote: >>> On 18.11.2023 13:39, Satya Priya Kakitapalli wrote: >>>> Add runtime support for videocc on SM8150 and update the resets >>>> and video_pll0_config configuration. >>>> >>>> Satya Priya Kakitapalli (4): >>>> dt-bindings: clock: Update the videocc resets for sm8150 >>>> clk: qcom: videocc-sm8150: Update the videocc resets >>>> clk: qcom: videocc-sm8150: Add missing PLL config properties >>>> clk: qcom: videocc-sm8150: Add runtime PM support >>> Hi, it's good practive to include a link to the previous revision >>> and a summary of changes. >>> >>> The b4 tool [1] does that for you, please consider using it. >> >> Hi, I have installed b4 and followed all the steps, but it doesn't populate my cover letter with change log and previous series link, do i need to use some option for that? > You probably did something like this: > > b4 prep -n 8150vidcc --from-thread 26b69814-201b-8d07-d844-27e804aa3016@quicinc.com > > Then if you do: > > b4 prep --edit-cover > > you'll see a note like > > EDITME: Imported from f26b69814-201b-8d07-d844-27e804aa3016@quicinc.com > Please review before sending. > > so you need to do it manually. > > > Generally, when the series has been sent at least once with b4 already, > you'll notice that `b4 send` appends something like this to the cover > letter: > > Changes in v2: > - EDITME: describe what is new in this series revision. > - EDITME: use bulletpoints and terse descriptions. > - Link to v1: https://lore.kernel.org/r/20230830-topic-refgenphy-v1-0-892db196a1c0@linaro.org > > > This should be only necessary to do by hand once, since as mentioned it's > the first time b4 sees this series > Thanks for the information, will add them manually. > Konrad