mbox series

[0/2] arm64: dts: qcom: sc8280xp: Make pmic thermal-zones report temperature

Message ID 20240210-sc8280xp-pmic-thermal-v1-0-a1c215a17d10@quicinc.com
Headers show
Series arm64: dts: qcom: sc8280xp: Make pmic thermal-zones report temperature | expand

Message

Bjorn Andersson via B4 Relay Feb. 11, 2024, 4:41 a.m. UTC 
The "pm8280-[12]-thermal" thermal zones always report 37C, fix this.

Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
---
Bjorn Andersson (2):
      arm64: dts: qcom: sc8280xp-crd: Add PMIC die-temp vadc channels
      arm64: dts: qcom: sc8280xp-pmics: Define adc for temp-alarms

 .../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts     | 37 +-------------------
 arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi       | 39 +++++++++++++++++++++-
 2 files changed, 39 insertions(+), 37 deletions(-)
---
base-commit: 445a555e0623387fa9b94e68e61681717e70200a
change-id: 20240210-sc8280xp-pmic-thermal-fb56e166507e

Best regards,

Comments

Konrad Dybcio Feb. 12, 2024, 11:08 a.m. UTC | #1 
On 11.02.2024 05:42, Bjorn Andersson via B4 Relay wrote:
> From: Bjorn Andersson <quic_bjorande@quicinc.com>
> 
> sc8280xp-pmics define the two thermal zones "pm8280-1-thermal" and
> "pm8280-2-thermal", but the related temp-alarm instances are not tied to
> any adc channels, and as such continuously report the bogus temperature
> of 37C.
> 
> After previously defining these adc channels across all boards using
> sc8280xp-pmics.dtsi, we can now add these references.
> 
> This does however mean that we have a non-disabled node referencing
> default-disabled nodes, requiring each board to enable the pmk8280_vadc.
> Avoid this by marking pmk8280_vadc okay.

Thanks for addressing my P1 review comments in a way that indicates time
travel has been achieved ;)

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad