mbox series

[00/31] Clean up thermal zone polling-delay

Message ID 20240319-topic-msm-polling-cleanup-v1-0-e0aee1dbcd78@linaro.org
Headers show
Series Clean up thermal zone polling-delay | expand

Message

Konrad Dybcio March 19, 2024, 4:13 p.m. UTC
A trivial follow-up on the changes introduced in Commit 488164006a28
("thermal/of: Assume polling-delay(-passive) 0 when absent").

Should probably wait until v6.9-rc1 so that the patch in question is
in the base tree, otherwise TZs will fail to register.

FWIW, Compile-tested only (except 8280).

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
Konrad Dybcio (31):
      arm64: dts: qcom: ipq6018-*: Remove thermal zone polling delays
      arm64: dts: qcom: ipq8074-*: Remove thermal zone polling delays
      arm64: dts: qcom: ipq9574-*: Remove thermal zone polling delays
      arm64: dts: qcom: msm8916-*: Remove thermal zone polling delays
      arm64: dts: qcom: msm8939-*: Remove thermal zone polling delays
      arm64: dts: qcom: msm8953-*: Remove thermal zone polling delays
      arm64: dts: qcom: msm8976-*: Remove thermal zone polling delays
      arm64: dts: qcom: msm8996-*: Remove thermal zone polling delays
      arm64: dts: qcom: msm8998-*: Remove thermal zone polling delays
      arm64: dts: qcom: pm7550ba: Remove thermal zone polling delays
      arm64: dts: qcom: pms405: Remove thermal zone polling delays
      arm64: dts: qcom: pmx75: Remove thermal zone polling delays
      arm64: dts: qcom: qcm2290-*: Remove thermal zone polling delays
      arm64: dts: qcom: qcs404-*: Remove thermal zone polling delays
      arm64: dts: qcom: sa8775p-*: Remove thermal zone polling delays
      arm64: dts: qcom: sc7180-*: Remove thermal zone polling delays
      arm64: dts: qcom: sc7280-*: Remove thermal zone polling delays
      arm64: dts: qcom: sc8180x-*: Remove thermal zone polling delays
      arm64: dts: qcom: sc8280xp-*: Remove thermal zone polling delays
      arm64: dts: qcom: sdm660-*: Remove thermal zone polling delays
      arm64: dts: qcom: sdm845-*: Remove thermal zone polling delays
      arm64: dts: qcom: sm6115-*: Remove thermal zone polling delays
      arm64: dts: qcom: sm6125-*: Remove thermal zone polling delays
      arm64: dts: qcom: sm6350-*: Remove thermal zone polling delays
      arm64: dts: qcom: sm6375-*: Remove thermal zone polling delays
      arm64: dts: qcom: sm8150-*: Remove thermal zone polling delays
      arm64: dts: qcom: sm8250-*: Remove thermal zone polling delays
      arm64: dts: qcom: sm8350-*: Remove thermal zone polling delays
      arm64: dts: qcom: sm8450-*: Remove thermal zone polling delays
      arm64: dts: qcom: sm8550-*: Remove thermal zone polling delays
      arm64: dts: qcom: sm8650-*: Remove thermal zone polling delays

 arch/arm64/boot/dts/qcom/ipq6018.dtsi              |  14 --
 arch/arm64/boot/dts/qcom/ipq8074.dtsi              |  36 -----
 arch/arm64/boot/dts/qcom/ipq9574.dtsi              |  26 ----
 arch/arm64/boot/dts/qcom/msm8916.dtsi              |  15 ---
 arch/arm64/boot/dts/qcom/msm8939.dtsi              |  27 ----
 arch/arm64/boot/dts/qcom/msm8953.dtsi              |  18 ---
 arch/arm64/boot/dts/qcom/msm8976.dtsi              |  26 ----
 arch/arm64/boot/dts/qcom/msm8996.dtsi              |  42 ------
 arch/arm64/boot/dts/qcom/msm8998.dtsi              |  57 --------
 arch/arm64/boot/dts/qcom/pm6125.dtsi               |   3 -
 arch/arm64/boot/dts/qcom/pm6150.dtsi               |   2 -
 arch/arm64/boot/dts/qcom/pm6150l.dtsi              |   3 -
 arch/arm64/boot/dts/qcom/pm6350.dtsi               |   3 -
 arch/arm64/boot/dts/qcom/pm660.dtsi                |   3 -
 arch/arm64/boot/dts/qcom/pm660l.dtsi               |   3 -
 arch/arm64/boot/dts/qcom/pm7250b.dtsi              |   3 -
 arch/arm64/boot/dts/qcom/pm7325.dtsi               |   2 -
 arch/arm64/boot/dts/qcom/pm7550ba.dtsi             |   3 -
 arch/arm64/boot/dts/qcom/pm8010.dtsi               |   6 -
 arch/arm64/boot/dts/qcom/pm8150.dtsi               |   3 -
 arch/arm64/boot/dts/qcom/pm8150b.dtsi              |   3 -
 arch/arm64/boot/dts/qcom/pm8150l.dtsi              |   3 -
 arch/arm64/boot/dts/qcom/pm8350.dtsi               |   2 -
 arch/arm64/boot/dts/qcom/pm8350b.dtsi              |   2 -
 arch/arm64/boot/dts/qcom/pm8350c.dtsi              |   2 -
 arch/arm64/boot/dts/qcom/pm8450.dtsi               |   3 -
 arch/arm64/boot/dts/qcom/pm8550.dtsi               |   3 -
 arch/arm64/boot/dts/qcom/pm8550b.dtsi              |   3 -
 arch/arm64/boot/dts/qcom/pm8550ve.dtsi             |   3 -
 arch/arm64/boot/dts/qcom/pm8550vs.dtsi             |  12 --
 arch/arm64/boot/dts/qcom/pm8953.dtsi               |   3 -
 arch/arm64/boot/dts/qcom/pm8994.dtsi               |   3 -
 arch/arm64/boot/dts/qcom/pm8998.dtsi               |   3 -
 arch/arm64/boot/dts/qcom/pmi632.dtsi               |   3 -
 arch/arm64/boot/dts/qcom/pmm8155au_1.dtsi          |   3 -
 arch/arm64/boot/dts/qcom/pmm8155au_2.dtsi          |   3 -
 arch/arm64/boot/dts/qcom/pmr735a.dtsi              |   2 -
 arch/arm64/boot/dts/qcom/pmr735b.dtsi              |   2 -
 arch/arm64/boot/dts/qcom/pmr735d_a.dtsi            |   3 -
 arch/arm64/boot/dts/qcom/pmr735d_b.dtsi            |   3 -
 arch/arm64/boot/dts/qcom/pms405.dtsi               |   3 -
 arch/arm64/boot/dts/qcom/pmx75.dtsi                |   3 -
 arch/arm64/boot/dts/qcom/qcm2290.dtsi              |  30 -----
 arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts |  14 --
 arch/arm64/boot/dts/qcom/qcs404.dtsi               |  30 -----
 arch/arm64/boot/dts/qcom/qrb5165-rb5.dts           |  10 --
 arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi        |   8 --
 arch/arm64/boot/dts/qcom/sa8775p.dtsi              | 150 ---------------------
 .../arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi |   3 -
 .../boot/dts/qcom/sc7180-trogdor-homestar.dtsi     |   3 -
 .../arm64/boot/dts/qcom/sc7180-trogdor-pompom.dtsi |   3 -
 .../boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi  |   3 -
 arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi       |   3 -
 arch/arm64/boot/dts/qcom/sc7180.dtsi               |  75 -----------
 arch/arm64/boot/dts/qcom/sc7280.dtsi               |  81 -----------
 arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi        |   6 -
 arch/arm64/boot/dts/qcom/sc8180x.dtsi              |  78 -----------
 .../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts     |   2 -
 arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi       |   4 -
 arch/arm64/boot/dts/qcom/sc8280xp.dtsi             |  33 -----
 arch/arm64/boot/dts/qcom/sdm630.dtsi               |  27 ----
 arch/arm64/boot/dts/qcom/sdm845-mtp.dts            |  12 --
 arch/arm64/boot/dts/qcom/sdm845.dtsi               |  63 ---------
 arch/arm64/boot/dts/qcom/sm6115.dtsi               |  32 -----
 .../dts/qcom/sm6125-sony-xperia-seine-pdx201.dts   |   8 --
 .../boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts  |   6 -
 arch/arm64/boot/dts/qcom/sm6350.dtsi               |  81 -----------
 arch/arm64/boot/dts/qcom/sm6375.dtsi               |  78 -----------
 arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts  |   4 -
 arch/arm64/boot/dts/qcom/sm8150.dtsi               |  84 ------------
 arch/arm64/boot/dts/qcom/sm8250-mtp.dts            |  14 --
 arch/arm64/boot/dts/qcom/sm8250.dtsi               |  75 -----------
 arch/arm64/boot/dts/qcom/sm8350.dtsi               |  87 ------------
 arch/arm64/boot/dts/qcom/sm8450-hdk.dts            |  16 ---
 arch/arm64/boot/dts/qcom/sm8450.dtsi               |  64 ---------
 arch/arm64/boot/dts/qcom/sm8550.dtsi               |  82 -----------
 arch/arm64/boot/dts/qcom/sm8650.dtsi               |  88 ------------
 77 files changed, 1722 deletions(-)
---
base-commit: 226d3c72fcde130a99d760895ebdd20e78e02cb5
change-id: 20240319-topic-msm-polling-cleanup-2616a8bece70

Best regards,

Comments

Daniel Lezcano March 21, 2024, 5:25 p.m. UTC | #1
On 19/03/2024 17:13, Konrad Dybcio wrote:
> A trivial follow-up on the changes introduced in Commit 488164006a28
> ("thermal/of: Assume polling-delay(-passive) 0 when absent").
> 
> Should probably wait until v6.9-rc1 so that the patch in question is
> in the base tree, otherwise TZs will fail to register.
> 
> FWIW, Compile-tested only (except 8280).
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---

Are you sure these changes are correct. They are not related to commit 
488164006a28.

If the sensor has interrupt support, then it can specify:

	polling-delay = <0>;

As a zero polling value can be omitted in the DT then it can be removed.


Then when a trip point is crossed, the interrupt fires but then it must 
sample the temperature of the thermal zone to do the mitigation.

I doubt polling-delay-passive must be removed. The changes you 
introduced just disable the mitigation and that will lead to board wild 
reboots.