mbox series

[00/20] arm64: dts: qcom: minor display-related fixups

Message ID 20250415-drm-msm-dts-fixes-v1-0-90cd91bdd138@oss.qualcomm.com
Headers show
Series arm64: dts: qcom: minor display-related fixups | expand

Message

Dmitry Baryshkov April 15, 2025, 10:25 a.m. UTC 
Based on the patch review by Konrad:
- Change VBIF size to 0x3000 as defined by memory map
- Use new DSI clock defines on SC7280
- Use TAG_ALWAYS for MDP->EBI memory interface on SA8775P

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
Dmitry Baryshkov (20):
      arm64: dts: qcom: sc7280: Use the header with DSI phy clock IDs
      arm64: dts: qcom: sa8775p: mark MDP interconnects as ALWAYS on
      arm64: dts: qcom: msm8998: use correct size for VBIF regions
      arm64: dts: qcom: qcm2290: use correct size for VBIF regions
      arm64: dts: qcom: sa8775p: use correct size for VBIF regions
      arm64: dts: qcom: sc7180: use correct size for VBIF regions
      arm64: dts: qcom: sc7280: use correct size for VBIF regions
      arm64: dts: qcom: sc8180x: use correct size for VBIF regions
      arm64: dts: qcom: sc8280xp: use correct size for VBIF regions
      arm64: dts: qcom: sdm670: use correct size for VBIF regions
      arm64: dts: qcom: sdm845: use correct size for VBIF regions
      arm64: dts: qcom: sm6115: use correct size for VBIF regions
      arm64: dts: qcom: sm6125: use correct size for VBIF regions
      arm64: dts: qcom: sm6350: use correct size for VBIF regions
      arm64: dts: qcom: sm8150: use correct size for VBIF regions
      arm64: dts: qcom: sm8250: use correct size for VBIF regions
      arm64: dts: qcom: sm8350: use correct size for VBIF regions
      arm64: dts: qcom: sm8450: use correct size for VBIF regions
      arm64: dts: qcom: sm8550: use correct size for VBIF regions
      arm64: dts: qcom: sm8650: use correct size for VBIF regions

 arch/arm64/boot/dts/qcom/msm8998.dtsi  |  4 ++--
 arch/arm64/boot/dts/qcom/qcm2290.dtsi  |  2 +-
 arch/arm64/boot/dts/qcom/sa8775p.dtsi  | 10 +++++-----
 arch/arm64/boot/dts/qcom/sc7180.dtsi   |  2 +-
 arch/arm64/boot/dts/qcom/sc7280.dtsi   | 13 ++++++++-----
 arch/arm64/boot/dts/qcom/sc8180x.dtsi  |  2 +-
 arch/arm64/boot/dts/qcom/sc8280xp.dtsi |  4 ++--
 arch/arm64/boot/dts/qcom/sdm670.dtsi   |  2 +-
 arch/arm64/boot/dts/qcom/sdm845.dtsi   |  2 +-
 arch/arm64/boot/dts/qcom/sm6115.dtsi   |  2 +-
 arch/arm64/boot/dts/qcom/sm6125.dtsi   |  2 +-
 arch/arm64/boot/dts/qcom/sm6350.dtsi   |  2 +-
 arch/arm64/boot/dts/qcom/sm8150.dtsi   |  2 +-
 arch/arm64/boot/dts/qcom/sm8250.dtsi   |  2 +-
 arch/arm64/boot/dts/qcom/sm8350.dtsi   |  2 +-
 arch/arm64/boot/dts/qcom/sm8450.dtsi   |  2 +-
 arch/arm64/boot/dts/qcom/sm8550.dtsi   |  2 +-
 arch/arm64/boot/dts/qcom/sm8650.dtsi   |  2 +-
 18 files changed, 31 insertions(+), 28 deletions(-)
---
base-commit: 5b37f7bfff3b1582c34be8fb23968b226db71ebd
change-id: 20250415-drm-msm-dts-fixes-70664ff6fc96

Best regards,

Comments

Konrad Dybcio April 15, 2025, 10:36 a.m. UTC | #1 
On 4/15/25 12:25 PM, Dmitry Baryshkov wrote:
> Use the header with DSI phy clock IDs to make code more readable.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad
Konrad Dybcio April 15, 2025, 10:37 a.m. UTC | #2 
On 4/15/25 12:26 PM, Dmitry Baryshkov wrote:
> Use allocated region size for VBIF regions as defined by the docs
> (0x3000) instead of just using the last register address.
> 
> Suggested-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad
Konrad Dybcio April 15, 2025, 10:41 a.m. UTC | #3 
On 4/15/25 12:26 PM, Dmitry Baryshkov wrote:
> Use allocated region size for VBIF regions as defined by the docs
> (0x3000) instead of just using the last register address.
> 
> Suggested-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad
Konrad Dybcio April 15, 2025, 10:42 a.m. UTC | #4 
On 4/15/25 12:26 PM, Dmitry Baryshkov wrote:
> Use allocated region size for VBIF regions as defined by the docs
> (0x3000) instead of just using the last register address.
> 
> Suggested-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad
Konrad Dybcio April 15, 2025, 10:43 a.m. UTC | #5 
On 4/15/25 12:26 PM, Dmitry Baryshkov wrote:
> Use allocated region size for VBIF regions as defined by the docs
> (0x3000) instead of just using the last register address.
> 
> Suggested-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad
Konrad Dybcio April 15, 2025, 10:47 a.m. UTC | #6 
On 4/15/25 12:26 PM, Dmitry Baryshkov wrote:
> Use allocated region size for VBIF regions as defined by the docs
> (0x3000) instead of just using the last register address.
> 
> Suggested-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---

Can't 100% confirm, but holds true on sister socs, so:

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad
Neil Armstrong April 15, 2025, 11:52 a.m. UTC | #7 
On 15/04/2025 12:26, Dmitry Baryshkov wrote:
> Use allocated region size for VBIF regions as defined by the docs
> (0x3000) instead of just using the last register address.
> 
> Suggested-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
>   arch/arm64/boot/dts/qcom/sm8550.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> index a2732e04896e2f6dcdcd019d90d23731ad0d15a7..82cabf777cd2c1dc87457aeede913873e7322ec2 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> @@ -3374,7 +3374,7 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
>   			mdss_mdp: display-controller@ae01000 {
>   				compatible = "qcom,sm8550-dpu";
>   				reg = <0 0x0ae01000 0 0x8f000>,
> -				      <0 0x0aeb0000 0 0x2008>;
> +				      <0 0x0aeb0000 0 0x3000>;
>   				reg-names = "mdp", "vbif";
>   
>   				interrupt-parent = <&mdss>;
> 

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Bjorn Andersson April 16, 2025, 6:10 p.m. UTC | #8 
On Tue, 15 Apr 2025 13:25:58 +0300, Dmitry Baryshkov wrote:
> Based on the patch review by Konrad:
> - Change VBIF size to 0x3000 as defined by memory map
> - Use new DSI clock defines on SC7280
> - Use TAG_ALWAYS for MDP->EBI memory interface on SA8775P
> 
> 

Applied, thanks!

[01/20] arm64: dts: qcom: sc7280: Use the header with DSI phy clock IDs
        commit: 33e020b942cb4bcf2f3870b573470973e6464bd5
[02/20] arm64: dts: qcom: sa8775p: mark MDP interconnects as ALWAYS on
        commit: 8725fb400542a6c88c1cc918d96064eedc8c94c4
[03/20] arm64: dts: qcom: msm8998: use correct size for VBIF regions
        commit: 31e18ebef09a596ea87277c24411e1a86eb56470
[04/20] arm64: dts: qcom: qcm2290: use correct size for VBIF regions
        commit: bacf203baa1ef896ac2bb4f9bf43b19f15a6ae26
[05/20] arm64: dts: qcom: sa8775p: use correct size for VBIF regions
        commit: 180f990ed061cefdac620d02f34b03387210a2b7
[06/20] arm64: dts: qcom: sc7180: use correct size for VBIF regions
        commit: 74e18dc4aef0e8e2989815856e48c737820ebca8
[07/20] arm64: dts: qcom: sc7280: use correct size for VBIF regions
        commit: 545b26b926ae20640a7d464e1b830ce4ce021fd5
[08/20] arm64: dts: qcom: sc8180x: use correct size for VBIF regions
        commit: a24e1cb954a6915983280e757c36d04fd5e6ce34
[09/20] arm64: dts: qcom: sc8280xp: use correct size for VBIF regions
        commit: 7b5160ce90a3c6c8e6202f727c3e6cd2c0911cbd
[10/20] arm64: dts: qcom: sdm670: use correct size for VBIF regions
        commit: acc206fed3698554a16cf70e5a2fc0e4f1e1a5fc
[11/20] arm64: dts: qcom: sdm845: use correct size for VBIF regions
        commit: e50450aae01ea23e17e10f59cdbdc7aa59108250
[12/20] arm64: dts: qcom: sm6115: use correct size for VBIF regions
        commit: c7f4216765891939e6d2dfa8809883bae978582f
[13/20] arm64: dts: qcom: sm6125: use correct size for VBIF regions
        commit: e24c7cb72b9b1286deee43fecf87d0248fa430cc
[14/20] arm64: dts: qcom: sm6350: use correct size for VBIF regions
        commit: 7cfcd1a3c519d0aff10af2db06aa6d2291393bd8
[15/20] arm64: dts: qcom: sm8150: use correct size for VBIF regions
        commit: 130e9aacc40176b5fa2954e7861d9b5f28f373ae
[16/20] arm64: dts: qcom: sm8250: use correct size for VBIF regions
        commit: 4e851ff6a3a12ce616e3cc902af0ae2efb2e8137
[17/20] arm64: dts: qcom: sm8350: use correct size for VBIF regions
        commit: d55fe5da78836835f9a88c29dd2fb3086b4a3720
[18/20] arm64: dts: qcom: sm8450: use correct size for VBIF regions
        commit: 62acfd77a5783948ba3593fb169720ab7495c380
[19/20] arm64: dts: qcom: sm8550: use correct size for VBIF regions
        commit: 9e9d8349e76252d5b7e060cc0ca4823a3f062052
[20/20] arm64: dts: qcom: sm8650: use correct size for VBIF regions
        commit: d8203fff4e6849cc5799fcf51105f7622e13c46d

Best regards,