From patchwork Mon Jul 16 13:32:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Niklas Cassel X-Patchwork-Id: 142022 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2433130ljj; Mon, 16 Jul 2018 06:33:14 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcl1jofb+iX6uPghvykK7k/n3QIVBSX4xAepiVFih5dZyaQOdO5NIwvMDdOFAHLqAx/Uafp X-Received: by 2002:a63:1811:: with SMTP id y17-v6mr15393261pgl.356.1531747994233; Mon, 16 Jul 2018 06:33:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531747994; cv=none; d=google.com; s=arc-20160816; b=CSbqOShCsJjhcDuc1er22pHDVmkfOBW5hyk7CY4iVjRIbhSVUu5h+L3TpfvNKw3EKu npitWStuMLfIIqKDM3D1ABDz/F9e9k0dqIcOp8GC5ywqRUbZxPkYejscRb9eV3hHDTnQ yMzu5qdHgMOKPpjpj/di4QQcdfb5S8CUUe1tZGqICN2q8P0XZ4uO20qpwdlXzhU8ohg9 h0nT1WC0+Q40KY8q4jpKig9w7XstJEhFyqkQRKoqehwvdTsPFA5BjF8kMlvxK/bTrEyG SPbbRKcSG753088R8A3ynzuJvPxfcdwZ9eQTlCv8+ym4Rj8a9KJuSYMZMnOZ6yysY4Gu FA6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=KT3Y7P/CKN2vI8I8KIBtcx7uSNuZG+LX2uD52Etc+vk=; b=0RObJxA47s1+b6cp30S9ytu27VJo7bZGwyP/wz6Vxitv2/izVvu/2GS/W9MMXvu/ai LWoXK5y/q2+WpqTvc1HdI6pvVgJ3ELz91uKbkrMimdFiwiZ6q5N7hzAhduTKSytgBeZH NeSmIltcp/B9r4EZX8kFoE09uyHjmjaGjh/qx1RseAUH6xNGG1R8CXQm1WZoLMCrgj8D soExJZS4KnmJN6mten7GuZNSjI+Q/zeFVSuKO1efqR/CuaZYxde6AFMr81bJFerpUgEc BtkIUmAfm5Ohfv1KiEZr5o6w5/jwnJkj8V0AIqWsqy80+KyvfYld8Zw6Ze5mZVJzMXcy 9EFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=VM4ZEEep; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x186-v6si30610395pgd.259.2018.07.16.06.33.14; Mon, 16 Jul 2018 06:33:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=VM4ZEEep; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727332AbeGPOAk (ORCPT + 13 others); Mon, 16 Jul 2018 10:00:40 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:35759 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727514AbeGPOAk (ORCPT ); Mon, 16 Jul 2018 10:00:40 -0400 Received: by mail-lj1-f194.google.com with SMTP id p10-v6so24548975ljg.2 for ; Mon, 16 Jul 2018 06:33:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=dwR2q+9R0Xn4F9WJrQYTuFQ7eo4wf2FGRuz3XTsXO5E=; b=VM4ZEEepBQdpvDkIYJyrX+AcUPwTplq3DYEGWYBEysIBrbVAFY1rEFiLgPK/L3f2+u ahPKw6l/5cLtn7Cp7z1gMybsjgifdaOm6lP117X4rFyvGjqjJEK6kAL0pBCvcJp7ICpk 9Y3lQw6uaMAAZWTXTMqNhPpqSU7K30hmSxQvE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=dwR2q+9R0Xn4F9WJrQYTuFQ7eo4wf2FGRuz3XTsXO5E=; b=YoXOyPx5I+ETQ9Kmh/lqOA8TwXQkY7aY16ON7CyNMVIoLfqwLUPpw+EnmcxJnEFumv dh7wZr21ySA4NZCWPBkOvcUr9PUt7QTYX3zlwS/kbUEaK+GGSJuEArYkEXGyPrjyjFBB jgUkwS/1sqYyQnoTVuLv4KDUDqBoYUDpquAAvL6iFfHHoUs3BvoX1e488uJ+J04pV+xa 4ceyDnHzwshRi0RfoZ1bfKWN5opLOqb1v7XVz20JgS3aqBICjmNG8tzdWjIJUFtMOo2O lA+priXvrSQDuFDLWUyhFGM40QZfM8Ls9XY3tvizHOZY7b6y+CEnlHpn0MOV1VVmFmW3 BIhw== X-Gm-Message-State: AOUpUlGiIG9GOhDXRtAQJChswpsxKr7+zMEFtdCgaIMt61DBAn2EpTsi I8wDyMbe3OVrP9NV13BGg2RYNA== X-Received: by 2002:a2e:869a:: with SMTP id l26-v6mr5770782lji.48.1531747990542; Mon, 16 Jul 2018 06:33:10 -0700 (PDT) Received: from centauri.lan (h-229-118.A785.priv.bahnhof.se. [5.150.229.118]) by smtp.gmail.com with ESMTPSA id a14-v6sm3820390ljb.49.2018.07.16.06.33.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Jul 2018 06:33:10 -0700 (PDT) From: Niklas Cassel To: broonie@kernel.org, Liam Girdwood Cc: linux-arm-msm@vger.kernel.org, johan@kernel.org, Niklas Cassel , linux-kernel@vger.kernel.org Subject: [PATCH v2 2/4] regulator: qcom_spmi: Use correct regmap when checking for error Date: Mon, 16 Jul 2018 15:32:52 +0200 Message-Id: <20180716133255.1506-3-niklas.cassel@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180716133255.1506-1-niklas.cassel@linaro.org> References: <20180716133255.1506-1-niklas.cassel@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Since we have just assigned saw_regmap, and since the error message refers to saw_regmap, it feels safe to assume that it is saw_regmap, and not regmap, that should be checked for errors. Fixes: 0caecaa87202 ("regulator: qcom_spmi: Add support for SAW") Signed-off-by: Niklas Cassel --- drivers/regulator/qcom_spmi-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/regulator/qcom_spmi-regulator.c b/drivers/regulator/qcom_spmi-regulator.c index 4cc14c65d86b..ba3d5e63ada6 100644 --- a/drivers/regulator/qcom_spmi-regulator.c +++ b/drivers/regulator/qcom_spmi-regulator.c @@ -1775,7 +1775,7 @@ static int qcom_spmi_regulator_probe(struct platform_device *pdev) syscon = of_parse_phandle(node, "qcom,saw-reg", 0); saw_regmap = syscon_node_to_regmap(syscon); of_node_put(syscon); - if (IS_ERR(regmap)) + if (IS_ERR(saw_regmap)) dev_err(dev, "ERROR reading SAW regmap\n"); }