From patchwork Wed Aug 29 07:57:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Niklas Cassel X-Patchwork-Id: 145400 Delivered-To: patch@linaro.org Received: by 2002:a2e:1648:0:0:0:0:0 with SMTP id 8-v6csp380045ljw; Wed, 29 Aug 2018 00:58:08 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdag8pfaTIpzgyCSPk00Dm0pjA++tQHAOMtaj2yzjn7J6e0ixfGQY8FaB9QuR5DLFuKcbKwG X-Received: by 2002:a17:902:7102:: with SMTP id a2-v6mr4863584pll.217.1535529488111; Wed, 29 Aug 2018 00:58:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535529488; cv=none; d=google.com; s=arc-20160816; b=bCJvw2xbrEbGkcxwKt8bYoU10PgnyDjQzZV5vyQJDJACZ6MifT+n8Ro4GkUVb2HSz6 sWMkjAcpjvABlsbD5FVECLzETR71us1QdZQXuADrFEBdwkXnOHJQPG5k7sdI7u21Bd2N VqTHuxNHrTN9hd4PRzrOEUymCcluPYE3JPinokUyZmda9R8h4jSkdqysh0CqQ7goPBTr nN71pXf2+OJrd6jmUSNvi+qAowhjVx8v+ATnokbcc9pW/bmNtcg41UBtXKJnNn7kI466 80SotjCKANvWCYzS4LqH23PtSbI5EqRvv0X8gEYMEAIE7JpHv/pVb3h4B0+XyWzTY9gC FVJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=n5N7rzo2Yz6ToBgcoJnkbL1OiPAx5DE6sy5tATHXNvo=; b=BKDpFWI/AgXjT/zu7clII+2cx+x2CWzrTC2q7zzH56nmSt74G1EdpaoYcFuzSciKkz DDTuomOavzbHufM8GQ5dmF+Fabnqd1tzwXMArzw4IOrsqORGy0u1piHpGzeb8g28kyCh uflbfzg4P1uCRL108Kfp9ff3ygERZs+uZhNVxxwGSl1mm9DCH6MkN1ACYhAp4Zs0momx mWS2gLPrkz2DmHKTjF6AzMKSy+nEtVN7zHtNnZEUxykiVX25nHu/uIugODWcuAW/AOVw ldN/c9pQ4mLL7CZ7UKWr0972O6MHCV4xTeX+fVAPcgwMDXSAMLFKRIOfoj5elxYJIDAX U7Sw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZiPY7gA7; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w7-v6si3347997plq.198.2018.08.29.00.58.07; Wed, 29 Aug 2018 00:58:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZiPY7gA7; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728039AbeH2Lxn (ORCPT + 13 others); Wed, 29 Aug 2018 07:53:43 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:34322 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728023AbeH2Lxn (ORCPT ); Wed, 29 Aug 2018 07:53:43 -0400 Received: by mail-lf1-f67.google.com with SMTP id g9-v6so3533750lfh.1 for ; Wed, 29 Aug 2018 00:58:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=n5N7rzo2Yz6ToBgcoJnkbL1OiPAx5DE6sy5tATHXNvo=; b=ZiPY7gA7J17PKABvvERsIGACUT9ycbQk2koUQRQauwaRddCew4S4x2tgVFCDLveVQV v2Ch4TRSQRXa/LbP1LDqpYFCPtmyRpx+27sAp02/nC2WtpJED7y5JAzd7s6poancIZf6 owWVvwdR8w15N7PTsFemdubA4Vd5eQGaUwke4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=n5N7rzo2Yz6ToBgcoJnkbL1OiPAx5DE6sy5tATHXNvo=; b=teRx1s5TrbTphgWbxVR19jMXOdJO5+UIdIdQWCQWyka0vZgP2GsTmAR6OIbKGiEh73 7aTGaf83BwPGmguZbFAxw/o17gG6Veq0J9VmaFLl6JqWid2K4q+KZ7b2YEr1yhp1njTY +5Hbemr0bMO5Af8b6aAKmJNxv/Np7x5lSoDvnvFBqy9MJNEm217F/SjZYdeLtN4v2X/w oj+i+qSn/PBkunkplre0/uZrZGrweIJk9XrRzWVm4WQg5InQh6CanNkfhlIHyC1U4ye9 YxZDzl/ayHoJLSu1Is9Z11pi3SoVvkHB1wuZROY91/5T2VR6PkbEgG1iWyszGZti2krO zbqw== X-Gm-Message-State: APzg51CA3b2RGJh9LBWNtJZJhZ0PoUjqPNHFNZUj2vCA2Q4vzuAQt9WO 8NEYDkX9InnTxudshEZa3fwBMQ== X-Received: by 2002:a19:9355:: with SMTP id v82-v6mr3418687lfd.134.1535529485106; Wed, 29 Aug 2018 00:58:05 -0700 (PDT) Received: from centauri.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id j9-v6sm592303ljh.40.2018.08.29.00.58.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 Aug 2018 00:58:04 -0700 (PDT) From: Niklas Cassel To: Andy Gross , David Brown Cc: Niklas Cassel , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 7/9] soc: qcom: wcnss_ctrl: Avoid string overflow Date: Wed, 29 Aug 2018 09:57:21 +0200 Message-Id: <20180829075724.9095-8-niklas.cassel@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180829075724.9095-1-niklas.cassel@linaro.org> References: <20180829075724.9095-1-niklas.cassel@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org 'chinfo.name' is used as a NUL-terminated string, but using strncpy() with the length equal to the buffer size may result in lack of the termination: drivers//soc/qcom/wcnss_ctrl.c: In function 'qcom_wcnss_open_channel': drivers//soc/qcom/wcnss_ctrl.c:284:2: warning: 'strncpy' specified bound 32 equals destination size [-Wstringop-truncation] strncpy(chinfo.name, name, sizeof(chinfo.name)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ This changes it to use the safer strscpy() instead. Signed-off-by: Niklas Cassel --- drivers/soc/qcom/wcnss_ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 Reviewed-by: Bjorn Andersson diff --git a/drivers/soc/qcom/wcnss_ctrl.c b/drivers/soc/qcom/wcnss_ctrl.c index df3ccb30bc2d..373400dd816d 100644 --- a/drivers/soc/qcom/wcnss_ctrl.c +++ b/drivers/soc/qcom/wcnss_ctrl.c @@ -281,7 +281,7 @@ struct rpmsg_endpoint *qcom_wcnss_open_channel(void *wcnss, const char *name, rp struct rpmsg_channel_info chinfo; struct wcnss_ctrl *_wcnss = wcnss; - strncpy(chinfo.name, name, sizeof(chinfo.name)); + strscpy(chinfo.name, name, sizeof(chinfo.name)); chinfo.src = RPMSG_ADDR_ANY; chinfo.dst = RPMSG_ADDR_ANY;